Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: gg1d: exploratory data analysis using tiled one-dimensional graphics #7531

Closed
editorialbot opened this issue Nov 26, 2024 · 14 comments
Labels
HTML pre-review query-scope Submissions of uncertain scope for JOSS R rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @selkamand (Sam El-Kamand)
Repository: https://github.com/selkamand/gg1d
Branch with paper.md (empty if default branch):
Version: 0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/31ced9f0aa76ee3df80621fcbf54d981"><img src="https://joss.theoj.org/papers/31ced9f0aa76ee3df80621fcbf54d981/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/31ced9f0aa76ee3df80621fcbf54d981/status.svg)](https://joss.theoj.org/papers/31ced9f0aa76ee3df80621fcbf54d981)

Author instructions

Thanks for submitting your paper to JOSS @selkamand. Currently, there isn't a JOSS editor assigned to your paper.

@selkamand if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 26, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1002/imt2.43 is OK
- 10.1101/gr.239244.118 is OK
- 10.1093/bioinformatics/btw325 is OK
- 10.32614/CRAN.package.ggiraph is OK
- 10.32614/cran.package.patchwork is OK
- 10.32614/CRAN.package.ggplot2 is OK
- 10.1038/s41587-020-0546-8 is OK
- 10.1016/j.cels.2018.03.002 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (438.1 files/s, 278391.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              5              0              0          13154
HTML                             6            676              5           5846
R                                7            167            236            726
CSV                              3              0              0            410
Markdown                         4             65              0            198
Rmd                              3             80            126            142
XML                              1              0              0            133
YAML                             5             28              8            131
TeX                              1              9              0            101
-------------------------------------------------------------------------------
SUM:                            35           1025            375          20841
-------------------------------------------------------------------------------

Commit count by author:

    65	Sam El-Kamand
    51	selkamand
     1	=

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 512

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

tidyHeatmap: an R package for modular heatmap production based on tidy principles
Submitting author: @stemangiola
Handling editor: @karthik (Retired)
Reviewers: @rlbarter, @AliciaSchep
Similarity score: 0.7622

ggparliament: A ggplot2 extension for parliament plots in R
Submitting author: @zmeers
Handling editor: @cMadan (Retired)
Reviewers: @andrewheiss
Similarity score: 0.7507

ggvoronoi: Voronoi Diagrams and Heatmaps with ggplot2
Submitting author: @garretrc
Handling editor: @yochannah (Retired)
Reviewers: @trinker, @corybrunson
Similarity score: 0.7449

dtrackr: An R package for tracking the provenance of data
Submitting author: @robchallen
Handling editor: @ajstewartlang (Active)
Reviewers: @debruine, @craig-willis
Similarity score: 0.7404

ggeffects: Tidy Data Frames of Marginal Effects from Regression Models
Submitting author: @strengejacke
Handling editor: @leeper (Retired)
Reviewers: @cdcrabtree
Similarity score: 0.7359

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @selkamand - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. This will also discuss if this is research software as defined by JOSS. You should hear back in a week or two.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Nov 26, 2024
@danielskatz
Copy link

👋 @selkamand - We've now completed this review. We do see this as research software and appreciate the work, but don't think it meets our substantial scholarly effort criterion due mostly to the small number of lines of code.

Additionally, one editor suggests that this may not work well for intermediate and larger size datasets (n>100) where parallel coordinate plots may be a better tool to achieve the same thing.

👋 @selkamand - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. This will also discuss if this is research software as defined by JOSS. You should hear back in a week or two.

@danielskatz
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

@selkamand
Copy link

Thanks @danielskatz (& the other editors). I really appreciate the suggestion about coordinate plots. Would be a great visualisation to add.

Will work towards expanding gg1d and look forward to resubmitting once it grows in scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML pre-review query-scope Submissions of uncertain scope for JOSS R rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants