Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: cellular_raza: Cellular Agent-based Modeling from a Clean Slate #7520

Open
editorialbot opened this issue Nov 23, 2024 · 48 comments
Assignees
Labels
pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 23, 2024

Submitting author: @jonaspleyer (Jonas Pleyer)
Repository: https://github.com/jonaspleyer/cellular_raza
Branch with paper.md (empty if default branch): paper
Version: 0.1.6
Editor: @mahfuz05062
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7a0a13c37e57776edc21132f518ef36a"><img src="https://joss.theoj.org/papers/7a0a13c37e57776edc21132f518ef36a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7a0a13c37e57776edc21132f518ef36a/status.svg)](https://joss.theoj.org/papers/7a0a13c37e57776edc21132f518ef36a)

Author instructions

Thanks for submitting your paper to JOSS @jonaspleyer. Currently, there isn't a JOSS editor assigned to your paper.

@jonaspleyer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 23, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3389/fphy.2022.968409 is OK
- 10.1016/j.cosrev.2017.03.001 is OK
- 10.1145/327070.327215 is OK
- 10.1006/jtbi.1997.0462 is OK
- 10.1016/S0378-4371(97)00511-6 is OK
- 10.1371/journal.pbio.0060141 is OK
- 10.1038/s41467-017-02285-7 is OK
- 10.1098/rstb.1952.0012 is OK
- 10.1177/00375497211068820 is OK
- 10.1104/pp.110.167619 is OK
- 10.1016/j.bpj.2013.11.4498 is OK
- 10.1371/journal.pcbi.1005569 is OK
- 10.1126/science.141.3579.401 is OK
- 10.1103/physrevlett.69.2013 is OK
- 10.1128/mmbr.00001-06 is OK
- 10.1111/j.1574-6976.2007.00098.x is OK
- 10.1038/ncomms15370 is OK
- 10.21105/joss.01848 is OK
- 10.1093/bioinformatics/btu498 is OK
- 10.1093/bioinformatics/btab649 is OK
- 10.1091/mbc.e16-01-0013 is OK
- 10.1002/cso2.1032 is OK
- 10.1038/ncomms13929 is OK
- 10.1038/ncomms13929 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: jonaspleyer/cr_trichome
- No DOI given, and none found for title: NetLogo

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (500.2 files/s, 98548.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2             72              0            352
TeX                              1             25              0            333
Bourne Shell                     1              0              0              6
-------------------------------------------------------------------------------
SUM:                             4             97              0            691
-------------------------------------------------------------------------------

Commit count by author:

     2	Jonas Pleyer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 2826

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Fast and flexible simulation and parameter estimation for synthetic biology using bioscrape
Submitting author: @ayush9pandey
Handling editor: @csoneson (Active)
Reviewers: @Farnazmdi, @Robaina
Similarity score: 0.6910

pylattica: a package for prototyping lattice models in chemistry and materials science
Submitting author: @mcgalcode
Handling editor: @richardjgowers (Retired)
Reviewers: @riesben, @amkrajewski
Similarity score: 0.6883

Tyssue: an epithelium simulation library
Submitting author: @glyg
Handling editor: @pdebuyl (Active)
Reviewers: @fcooper8472, @SergeDmi
Similarity score: 0.6846

CellPyLib: A Python Library for working with Cellular Automata
Submitting author: @lantunes
Handling editor: @jbytecode (Active)
Reviewers: @blsqr, @szhorvat
Similarity score: 0.6787

AgentPy: A package for agent-based modeling in Python
Submitting author: @JoelForamitti
Handling editor: @sbenthall (Active)
Reviewers: @jamesdamillington, @martibosch
Similarity score: 0.6756

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @jonaspleyer - Thanks for your submission.

However, note that your paper is about 3 times longer than the maximum recommended JOSS paper length. Please take a at the example paper. Please use the command @editorialbot generate pdf after making changes to the .md file to make a new PDF. You can also use the command @editorialbot check references to check a number of things, including the paper length. editorialbot commands need to be the first entry in a new comment.

In addition, the branch with your paper does not seem to include the software as well, but only has the paper. Typically, the paper branch is the same as the main branch, with the addition of the paper. Can you fix this?

@jonaspleyer
Copy link

@danielskatz Thanks for initiating the pre-review process. I was aware that my paper is longer than the expected maximum size. I am very happy to trim it down. Is it reasonable to make this decision via the review process or would you like me to make these changes before advancing?

@jonaspleyer
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @jonaspleyer, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@jonaspleyer
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.24 s (1283.6 files/s, 165768.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Rust                           111           3077           5334          26564
Python                          17            367            185           2023
TOML                            30             68             11            545
Markdown                        11             96              0            474
SVG                              3              0              0            334
TeX                              1             25              0            333
Jupyter Notebook                 2              0            290            254
HTML                             3              1              4            185
YAML                            17             39              7            170
JSON                           115              0              0            115
Bourne Shell                     4             11              3             35
-------------------------------------------------------------------------------
SUM:                           314           3684           5834          31032
-------------------------------------------------------------------------------

Commit count by author:

  2530	Jonas Pleyer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 2826

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v2.0 (Check here for OSI approval)

@jonaspleyer
Copy link

In addition, the branch with your paper does not seem to include the software as well, but only has the paper. Typically, the paper branch is the same as the main branch, with the addition of the paper. Can you fix this?

@danielskatz
I have updated the paper branch to also include the most recent version of cellular_raza. The editorialbot seems to pick up the corresponding information correctly.

@danielskatz
Copy link

@danielskatz Thanks for initiating the pre-review process. I was aware that my paper is longer than the expected maximum size. I am very happy to trim it down. Is it reasonable to make this decision via the review process or would you like me to make these changes before advancing?

You need to reduce it before we start.

@jonaspleyer
Copy link

Thanks for the quick reply. I will reduce it in the coming week.

@jonaspleyer
Copy link

jonaspleyer commented Nov 25, 2024

@danielskatz It seems that the editorialbot has counted words which were commented out. I had left some previous sections in comments in the source code of the paper.md file in case we need access to this information. When removing these paragraphs, the total word-count is approximately half (1345 words)
It seems that only the source file paper.md is scanned which also includes the preamble and other commands that will be compiled (such as figures). Without checking, it seems that the wc utility of the GNU coreutils is being used. When accounting for some of these additional contributions and gradually reducing the file, we obtain the following table.

Removed via Compilation Wordcount
Full 2826
Without Comments 1345
Without Preamble 1293
Without Figures 1266
Others
Without Headings 1220
Without inline Citations 1199
Without Acknowledgements 1160

It is clear that we are still over the desired 1000 words but much closer than thought initially. We will nevertheless try to compact the paper.

@jonaspleyer
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.25 s (1247.2 files/s, 160213.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Rust                           111           3077           5334          26564
Python                          17            367            185           2023
TOML                            30             68             11            545
SVG                              3              0              0            334
TeX                              1             25              0            333
Markdown                        11             55              0            302
Jupyter Notebook                 2              0            290            254
HTML                             3              1              4            185
YAML                            17             39              7            170
JSON                           115              0              0            115
Bourne Shell                     4             11              3             35
-------------------------------------------------------------------------------
SUM:                           314           3643           5834          30860
-------------------------------------------------------------------------------

Commit count by author:

  2531	Jonas Pleyer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1345

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v2.0 (Check here for OSI approval)

@danielskatz
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Cacatoo: building, exploring, and sharing spatially structured models of biological systems
Submitting author: @bramvandijk88
Handling editor: @Bisaloo (Retired)
Reviewers: @emilydolson, @TimKam
Similarity score: 0.6876

CellPyLib: A Python Library for working with Cellular Automata
Submitting author: @lantunes
Handling editor: @jbytecode (Active)
Reviewers: @blsqr, @szhorvat
Similarity score: 0.6786

pylattica: a package for prototyping lattice models in chemistry and materials science
Submitting author: @mcgalcode
Handling editor: @richardjgowers (Retired)
Reviewers: @riesben, @amkrajewski
Similarity score: 0.6755

REvoSim v3: A fast evolutionary simulation tool with ecological processes
Submitting author: @Euan-Furness
Handling editor: @Bisaloo (Retired)
Reviewers: @bramvandijk88, @emilydolson
Similarity score: 0.6612

AgentPy: A package for agent-based modeling in Python
Submitting author: @JoelForamitti
Handling editor: @sbenthall (Active)
Reviewers: @jamesdamillington, @martibosch
Similarity score: 0.6608

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @jonaspleyer - is this ready now from your point of view?

@editorialbot editorialbot added Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 26, 2024
@jonaspleyer
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.28 s (1112.4 files/s, 142846.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Rust                           111           3077           5334          26564
Python                          17            367            185           2023
TOML                            30             68             11            545
SVG                              3              0              0            334
TeX                              1             25              0            333
Markdown                        11             54              0            286
Jupyter Notebook                 2              0            290            254
HTML                             3              1              4            185
YAML                            17             39              7            170
JSON                           115              0              0            115
Bourne Shell                     4             11              3             35
-------------------------------------------------------------------------------
SUM:                           314           3642           5834          30844
-------------------------------------------------------------------------------

Commit count by author:

  2536	Jonas Pleyer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1159

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v2.0 (Check here for OSI approval)

@jonaspleyer
Copy link

👋 @jonaspleyer - is this ready now from your point of view?

Yes I would be happy to advance. 👍

@danielskatz
Copy link

danielskatz commented Nov 26, 2024

@jonaspleyer - We've switched the track this is in, so @Kevin-Mattheus-Moerman will be handling it from here. Thanks for your work to get it ready to be assigned to an editor.

@jonaspleyer
Copy link

@Kevin-Mattheus-Moerman Just wanted to know if there is anything that I should do before we enter the review stage?

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Cacatoo: building, exploring, and sharing spatially structured models of biological systems
Submitting author: @bramvandijk88
Handling editor: @Bisaloo (Retired)
Reviewers: @emilydolson, @TimKam
Similarity score: 0.6862

CellPyLib: A Python Library for working with Cellular Automata
Submitting author: @lantunes
Handling editor: @jbytecode (Active)
Reviewers: @blsqr, @szhorvat
Similarity score: 0.6821

pylattica: a package for prototyping lattice models in chemistry and materials science
Submitting author: @mcgalcode
Handling editor: @richardjgowers (Retired)
Reviewers: @riesben, @amkrajewski
Similarity score: 0.6749

AgentPy: A package for agent-based modeling in Python
Submitting author: @JoelForamitti
Handling editor: @sbenthall (Active)
Reviewers: @jamesdamillington, @martibosch
Similarity score: 0.6583

RingsPy: A Python package for Voronoi mesh generation of cellular solids with radial growth pattern
Submitting author: @kingyin3613
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @niallmadden, @mahtab-vafaee
Similarity score: 0.6580

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@jonaspleyer
Copy link

@Kevin-Mattheus-Moerman Hi sorry to bother you again. Since this submission has changed tracks and Managing EiC, I would simpliy like to clarify if there is anything which I should do.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added waitlisted Submissions in the JOSS backlog due to reduced service mode. and removed paused labels Jan 10, 2025
@Kevin-Mattheus-Moerman
Copy link
Member

@jonaspleyer apologies for the delays encountered here so far. We have a big of a backlog of submissions to go through. As such many editors are per-occupied with other submissions. I will assign a handling editor as soon as one becomes available.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @mahfuz05062 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@mahfuz05062 since one of your submissions is nearly done, do you think you can help edit this one? Thanks

@mahfuz05062
Copy link

@editorialbot assign @mahfuz05062 as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @mahfuz05062 is now the editor

@mahfuz05062
Copy link

Hi @jonaspleyer, do you have any suggestions for potential reviewers? If so, please mention them here (without tagging them with an @). You can search the list of people who have already agreed to review and may be suitable for this submission. I will then reach out to the potential reviewers to finalize the reviewers for this submission.

@jonaspleyer
Copy link

Hi there! Thanks for advancing this submission and apologies for the slow response on my end.
I have looked at the list of people and found some names which might be suitable.

https://reviewers.joss.theoj.org/reviewers/5922
https://reviewers.joss.theoj.org/reviewers/3276
https://reviewers.joss.theoj.org/reviewers/3961
https://reviewers.joss.theoj.org/reviewers/2247

@mahfuz05062
Copy link

Hi @Armavica, @finsberg, @johanneskoester, and @lazear - any of you interessted in reviewing this article?

@finsberg
Copy link

Hi @Armavica, @finsberg, @johanneskoester, and @lazear - any of you interessted in reviewing this article?

Hi @mahfuz05062, I would be happy to review this one👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

6 participants