Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Multi-Device UART Communication with the dwiBus Library #7447

Closed
editorialbot opened this issue Nov 11, 2024 · 37 comments
Closed
Assignees
Labels
C++ pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics withdrawn

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 11, 2024

Submitting author: @dralicimen (Ali ÇİMEN)
Repository: https://github.com/dralicimen/dwiBus
Branch with paper.md (empty if default branch):
Version: v1.0.2
Editor: @danielskatz
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5191d942e22ad415bbaef4d86e074c9f"><img src="https://joss.theoj.org/papers/5191d942e22ad415bbaef4d86e074c9f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5191d942e22ad415bbaef4d86e074c9f/status.svg)](https://joss.theoj.org/papers/5191d942e22ad415bbaef4d86e074c9f)

Author instructions

Thanks for submitting your paper to JOSS @dralicimen. Currently, there isn't a JOSS editor assigned to your paper.

@dralicimen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 11, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/EESCO.2015.7253788 is OK
- 10.1109/SBESC.2012.12 is OK
- 10.1016/j.ijcip.2016.08.001 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Future-oriented UART protocols for industrial auto...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 10.12720/sgce.8.2.123-130 is INVALID

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (774.4 files/s, 53731.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2             99              0            217
Arduino Sketch                   6             67             46            199
C++                              1             20              8             89
C/C++ Header                     1             12              6             53
TeX                              1              5              0             44
YAML                             1              4              0             19
JSON                             1              0              0             14
-------------------------------------------------------------------------------
SUM:                            13            207             60            635
-------------------------------------------------------------------------------

Commit count by author:

    23	dralicimen

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1179

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PYDAQ: Data Acquisition and Experimental Analysis with Python
Submitting author: @samirmartins
Handling editor: @kyleniemeyer (Active)
Reviewers: @galessiorob, @nataliakeles
Similarity score: 0.5705

SwiftVISA: Controlling Instrumentation with a Swift-based Implementation of the VISA Communication Protocol
Submitting author: @ohildreth
Handling editor: @dhhagan (Retired)
Reviewers: @MatthieuDartiailh, @jarrah42
Similarity score: 0.5694

SimpleFOC: A Field Oriented Control (FOC) Library for Controlling Brushless Direct Current (BLDC) and Stepper Motors
Submitting author: @askuric
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sea-bass, @ixjlyons
Similarity score: 0.5663

Pyripherals: A Python Package for Communicating with Peripheral Electronic Devices
Submitting author: @Ajstros
Handling editor: @danielskatz (Active)
Reviewers: @untzag, @askuric
Similarity score: 0.5634

Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library
Submitting author: @eidheim
Handling editor: @gkthiruvathukal (Active)
Reviewers: @ts-adi, @HaoZeke
Similarity score: 0.5613

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@dralicimen - thanks for your submission.

As track editor, I have some things you should work on before we can move forward:

  • Please add your country in your affiliation.
  • editorialbot suggests one of your DOIs is incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right (or after you add your country to your affiliation) to make a new PDF. editorialbot commands need to be the first entry in a new comment.
  • Your compiled paper does not include a References section or any compiled references. Please follow the example paper. Again, use the command @editorialbot generate pdf to make a new PDF.
  • For JOSS to find reviewers for this, we need to understand the requirements of a user in order to install and test it. Is there specific hardware needed to do this? Or anything else?

@danielskatz
Copy link

@dralicimen - I'm marking this as paused for now - please ping me when you want to proceed.

@dralicimen
Copy link

@editorialbot generate pdf

@dralicimen
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/EESCO.2015.7253788 is OK
- 10.1109/SBESC.2012.12 is OK
- 10.1016/j.ijcip.2016.07.001 is OK
- 10.1155/2019/7010717 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@dralicimen
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dralicimen
Copy link

@danielskatz Sorry for the mistake. I saved the changes. You can change the status.

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SwiftVISA: Controlling Instrumentation with a Swift-based Implementation of the VISA Communication Protocol
Submitting author: @ohildreth
Handling editor: @dhhagan (Retired)
Reviewers: @MatthieuDartiailh, @jarrah42
Similarity score: 0.5759

PYDAQ: Data Acquisition and Experimental Analysis with Python
Submitting author: @samirmartins
Handling editor: @kyleniemeyer (Active)
Reviewers: @galessiorob, @nataliakeles
Similarity score: 0.5721

SimpleFOC: A Field Oriented Control (FOC) Library for Controlling Brushless Direct Current (BLDC) and Stepper Motors
Submitting author: @askuric
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sea-bass, @ixjlyons
Similarity score: 0.5699

Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library
Submitting author: @eidheim
Handling editor: @gkthiruvathukal (Active)
Reviewers: @ts-adi, @HaoZeke
Similarity score: 0.5661

Pyripherals: A Python Package for Communicating with Peripheral Electronic Devices
Submitting author: @Ajstros
Handling editor: @danielskatz (Active)
Reviewers: @untzag, @askuric
Similarity score: 0.5626

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@dralicimen
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SwiftVISA: Controlling Instrumentation with a Swift-based Implementation of the VISA Communication Protocol
Submitting author: @ohildreth
Handling editor: @dhhagan (Retired)
Reviewers: @MatthieuDartiailh, @jarrah42
Similarity score: 0.5840

PYDAQ: Data Acquisition and Experimental Analysis with Python
Submitting author: @samirmartins
Handling editor: @kyleniemeyer (Active)
Reviewers: @galessiorob, @nataliakeles
Similarity score: 0.5789

SimpleFOC: A Field Oriented Control (FOC) Library for Controlling Brushless Direct Current (BLDC) and Stepper Motors
Submitting author: @askuric
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sea-bass, @ixjlyons
Similarity score: 0.5778

Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library
Submitting author: @eidheim
Handling editor: @gkthiruvathukal (Active)
Reviewers: @ts-adi, @HaoZeke
Similarity score: 0.5769

Pyripherals: A Python Package for Communicating with Peripheral Electronic Devices
Submitting author: @Ajstros
Handling editor: @danielskatz (Active)
Reviewers: @untzag, @askuric
Similarity score: 0.5674

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@dralicimen - the paper still has problems:

  1. At the end, there is a summary heading but no text in it
  2. There is no references heading, and no references are listed in the paper, so none appear at the end
  3. There is no acknowledgments section, though this is not required.

Please see the example paper again...

@dralicimen
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library
Submitting author: @eidheim
Handling editor: @gkthiruvathukal (Active)
Reviewers: @ts-adi, @HaoZeke
Similarity score: 0.6049

SwiftVISA: Controlling Instrumentation with a Swift-based Implementation of the VISA Communication Protocol
Submitting author: @ohildreth
Handling editor: @dhhagan (Retired)
Reviewers: @MatthieuDartiailh, @jarrah42
Similarity score: 0.5935

MAHOS: Measurement Automation Handling and Orchestration System
Submitting author: @ktahar
Handling editor: @arfon (Active)
Reviewers: @sidihamady, @aquilesC
Similarity score: 0.5913

BoboCEP: a Fault-Tolerant Complex Event Processing Engine for Edge Computing in Internet of Things
Submitting author: @r3w0p
Handling editor: @vissarion (Active)
Reviewers: @abhishektiwari, @mahsan321
Similarity score: 0.5895

SimpleFOC: A Field Oriented Control (FOC) Library for Controlling Brushless Direct Current (BLDC) and Stepper Motors
Submitting author: @askuric
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sea-bass, @ixjlyons
Similarity score: 0.5881

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@dralicimen
Copy link

@danielskatz .

@danielskatz
Copy link

@dralicimen - please remove the separators (the ---s) between the sections

@danielskatz
Copy link

👋 @dralicimen - thanks for your submission to JOSS. We're currently managing a backlog of submissions and the editors most appropriate for your area are already rather busy. For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@danielskatz danielskatz added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 20, 2024
@dralicimen
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Hardware-Control: Instrument control and automation package
Submitting author: @Grant-Giesbrecht
Handling editor: @timtroendle (Retired)
Reviewers: @aquilesC, @untzag, @garrettj403
Similarity score: 0.6002

SwiftVISA: Controlling Instrumentation with a Swift-based Implementation of the VISA Communication Protocol
Submitting author: @ohildreth
Handling editor: @dhhagan (Retired)
Reviewers: @MatthieuDartiailh, @jarrah42
Similarity score: 0.5922

MAHOS: Measurement Automation Handling and Orchestration System
Submitting author: @ktahar
Handling editor: @arfon (Active)
Reviewers: @sidihamady, @aquilesC
Similarity score: 0.5900

PyNGHam: A Python library of the NGHam protocol
Submitting author: @mgm8
Handling editor: @jbytecode (Active)
Reviewers: @pritchardn, @0xCoto
Similarity score: 0.5863

BoboCEP: a Fault-Tolerant Complex Event Processing Engine for Edge Computing in Internet of Things
Submitting author: @r3w0p
Handling editor: @vissarion (Active)
Reviewers: @abhishektiwari, @mahsan321
Similarity score: 0.5852

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@dralicimen - I'll take this as editor and get started.

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 28, 2024
@danielskatz
Copy link

👋 @dralicimen - note that I'm waiting for you on this

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

@danielskatz
Copy link

👋 @dralicimen - again, please note that I'm waiting for you on this ☝️. If I don't hear back from you by the end of the first week of the new year, I will mark this submission as withdrawn.

@danielskatz
Copy link

@editorialbot withdraw

@editorialbot
Copy link
Collaborator Author

Paper withdrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics withdrawn
Projects
None yet
Development

No branches or pull requests

3 participants