Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: aweSOM: a CPU/GPU-accelerated Self-organizing Map and Statistically Combined Ensemble Framework for Machine-learning Clustering Analysis #7355

Closed
editorialbot opened this issue Oct 15, 2024 · 33 comments
Assignees
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 15, 2024

Submitting author: @tvh0021 (Trung Ha)
Repository: https://github.com/tvh0021/aweSOM
Branch with paper.md (empty if default branch):
Version: 1.0.0
Editor: @gkthiruvathukal
Reviewers: @haniyeka, @Abinashbunty, @apizzuto
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b6995d7573124b56e82ec6b875f3b5d1"><img src="https://joss.theoj.org/papers/b6995d7573124b56e82ec6b875f3b5d1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b6995d7573124b56e82ec6b875f3b5d1/status.svg)](https://joss.theoj.org/papers/b6995d7573124b56e82ec6b875f3b5d1)

Author instructions

Thanks for submitting your paper to JOSS @tvh0021. Currently, there isn't a JOSS editor assigned to your paper.

@tvh0021 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Oct 15, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.15 s (557.8 files/s, 140966.0 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           44           2242           1731           6084
HTML                             11            866             33           5095
JavaScript                        6            131            195            817
CSS                               2            190             32            778
Jupyter Notebook                  2              0           1646            456
Markdown                          3            124              0            335
TeX                               1             24              0            266
reStructuredText                  8            134            133            165
YAML                              2              6             17             29
DOS Batch                         1              8              1             26
Bourne Again Shell                5             14            112             22
make                              1              4              7              9
--------------------------------------------------------------------------------
SUM:                             86           3743           3907          14082
--------------------------------------------------------------------------------

Commit count by author:

    99	tvh0021
     7	Trung Ha

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/CBO9780511525087 is OK
- 10.1017/S0022377823000946 is OK
- 10.1088/0004-637X/771/2/124 is OK
- 10.3847/1538-4357/aad4ff is OK
- 10.1007/978-3-030-01057-7_60 is OK
- 10.23860/thesis-yuan-li-2018 is OK
- 10.1016/j.image.2021.116450 is OK
- 10.1109/5.58325 is OK
- 10.1145/2833157.2833162 is OK
- 10.5281/zenodo.13819579 is OK
- 10.3389/frai.2021.761925 is OK
- 10.21203/rs.3.rs-87487/v1 is OK
- 10.3390/s24092741 is OK
- 10.1023/A:1023941307670 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: The Local Structure of Turbulence in Incompressibl...
- No DOI given, and none found for title: Machine-Learning Characterization of Intermittency...
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: MiniSom: minimalistic and NumPy-based implementati...
- No DOI given, and none found for title: Iris

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.asoc.2022.109972 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.envint.2008.01.006 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1585

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Scientific Computational Imaging Code (SCICO)
Submitting author: @bwohlberg
Handling editor: @danielskatz (Active)
Reviewers: @vitorsr, @DanNixon, @lucaferranti
Similarity score: 0.6644

mpi4jax: Zero-copy MPI communication of JAX arrays
Submitting author: @dionhaefner
Handling editor: @kellyrowland (Active)
Reviewers: @1313e, @Himscipy
Similarity score: 0.6633

cblearn: Comparison-based Machine Learning in Python
Submitting author: @dekuenstle
Handling editor: @mbarzegary (Active)
Reviewers: @haniyeka, @sherbold, @stsievert
Similarity score: 0.6548

Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference
Submitting author: @Edenhofer
Handling editor: @dfm (Active)
Reviewers: @Abinashbunty, @apizzuto
Similarity score: 0.6523

libEnsemble: A complete Python toolkit for dynamic ensembles of calculations
Submitting author: @jmlarson1
Handling editor: @jbytecode (Active)
Reviewers: @jsoishi, @SergeyYakubov
Similarity score: 0.6521

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

@editorialbot invite @gkthiruvathukal as editor

👋 @gkthiruvathukal - are you able to take this one on as editor? Thanks!

@gkthiruvathukal
Copy link

@crvernon Ok, sure! I will take it. A little swamped in general lately but as long as slow progress is better than no progress, I can manage it!

@crvernon
Copy link

@editorialbot assign @gkthiruvathukal as editor

@gkthiruvathukal - slow progress is indeed better than no progress in this case, so thank you!!

@editorialbot
Copy link
Collaborator Author

Assigned! @gkthiruvathukal is now the editor

@crvernon
Copy link

@editorialbot assign @gkthiruvathukal as editor

Doing this again because we had some system upgrades that were applied.

@editorialbot
Copy link
Collaborator Author

Assigned! @gkthiruvathukal is now the editor

@gkthiruvathukal
Copy link

@haniyeka, @sherbold, @stsievert: Please let me know if you are willing to contribute a review for this JOSS submission. I need at least 2 reviewers to proceed.

@stsievert
Copy link

@gkthiruvathukal sorry, I can't review. I don't have the bandwidth now.

I have taken a brief glance. I'd encourage the authors (@tvh0021, ...) to review the JOSS review guidelines. In particular, I think the main page should feature a clear statement of need and the answer to the question "what's the purpose of this project?" An FAQ page is not where I'd expect to find that answer.

@sherbold
Copy link

Sorry, I also have to decline, I currently have too many review and editor commitments.

@gkthiruvathukal
Copy link

@stsievert Even though you don't have the bandwidth, you already gave valuable feedback.
@tvh0021, can you please address this issue right away before I proceed with assigning reviewers? This will be a blocker for proceeding with your submission.

@tvh0021
Copy link

tvh0021 commented Dec 3, 2024

@stsievert thank you for your feedback!
@gkthiruvathukal, I have addressed this issue by including a brief statement of need on the front page of the documentation. A complete statement of need for the project is available in the manuscript.

@haniyeka
Copy link

haniyeka commented Dec 8, 2024

@haniyeka, @sherbold, @stsievert: Please let me know if you are willing to contribute a review for this JOSS submission. I need at least 2 reviewers to proceed.

Thanks for the invitation. I do have some time available to review this submission. Feel free to add me as reviewer.

@gkthiruvathukal
Copy link

@haniyeka Thank you for accepting my invitation!

@sherbold, @stsievert, can you let me know whether either of you can accept? I need one more reviewer. 🙏🏾

@gkthiruvathukal
Copy link

@editorialbot add @haniyeka as reviewer

@editorialbot
Copy link
Collaborator Author

@haniyeka added to the reviewers list!

@gkthiruvathukal
Copy link

@Abinashbunty, @apizzuto Can you let me know whether you can help with this JOSS submission? I need one more reviewer to proceed.

@Abinashbunty
Copy link

@gkthiruvathukal Yes. I can do the review for this. Thank you.

@apizzuto
Copy link

Sounds like it's covered now but I'm happy to help if anything falls through.

@gkthiruvathukal
Copy link

@apizzuto I actually need two. So I will take you up on it!

@gkthiruvathukal
Copy link

@editorialbot add @Abinashbunty as reviewer

@editorialbot
Copy link
Collaborator Author

@Abinashbunty added to the reviewers list!

@gkthiruvathukal
Copy link

@editorialbot add @apizzuto as reviewer

@editorialbot
Copy link
Collaborator Author

@apizzuto added to the reviewers list!

@gkthiruvathukal
Copy link

Thanks to both of you, @Abinashbunty and @apizzuto!

I've assigned you both and will now start review!

@gkthiruvathukal
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7613.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

9 participants