Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AliNe: A Flexible and Efficient Nextflow Pipeline for Read Alignmen #7348

Closed
editorialbot opened this issue Oct 14, 2024 · 41 comments
Assignees
Labels
Nextflow pre-review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 14, 2024

Submitting author: @Juke34 (Jacques Dainat)
Repository: https://github.com/Juke34/AliNe
Branch with paper.md (empty if default branch): main
Version: v1.0.0
Editor: @jromanowska
Reviewers: @rcannood, @gchure
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3691aa3dd83d8ccab8dfacce69c9b4c6"><img src="https://joss.theoj.org/papers/3691aa3dd83d8ccab8dfacce69c9b4c6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3691aa3dd83d8ccab8dfacce69c9b4c6/status.svg)](https://joss.theoj.org/papers/3691aa3dd83d8ccab8dfacce69c9b4c6)

Author instructions

Thanks for submitting your paper to JOSS @Juke34. Currently, there isn't a JOSS editor assigned to your paper.

@Juke34 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 14, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (345.6 files/s, 62208.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2             76              0            294
TeX                              1              0              0            272
YAML                             1              2              1             75
-------------------------------------------------------------------------------
SUM:                             4             78              1            641
-------------------------------------------------------------------------------

Commit count by author:

    41	Jacques Dainat

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/BIOINFORMATICS/BTP324 is OK
- 10.1093/BIOINFORMATICS/BTP698 is OK
- 10.1038/NMETH.1923 is OK
- 10.1093/NAR/GKT214 is OK
- 10.1093/bioinformatics/bts635 is OK
- 10.1371/journal.pone.0163962 is OK
- 10.1093/bioinformatics/btw354 is OK
- 10.1038/nmeth.4197 is OK
- 10.1038/nbt.3820 is OK
- 10.1371/JOURNAL.PCBI.1005944 is OK
- 10.1038/s41592-018-0001-7 is OK
- 10.1101/720458 is OK
- 10.1093/BIOINFORMATICS/BTAB705 is OK
- 10.1093/gigascience/giab008 is OK
- 10.1002/imt2.107 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: novoAlign | Novocraft
- No DOI given, and none found for title: BBMap
- No DOI given, and none found for title: Aligning sequence reads, clone sequences and assem...
- No DOI given, and none found for title: FastQC
- No DOI given, and none found for title: A Recent ( 2020 ) Comparative Analysis of Genome A...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 10.1186/GB-2013-14-4-R36/FIGURES/6 is INVALID

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 712

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

sam2lca: Lowest Common Ancestor for SAM/BAM/CRAM alignment files
Submitting author: @maxibor
Handling editor: @jmschrei (Active)
Reviewers: @fasnicar, @marouenbg
Similarity score: 0.7372

RNAsik: A Pipeline for complete and reproducible RNA-seq analysis that runs anywhere with speed and ease
Submitting author: @serine
Handling editor: @pjotrp (Retired)
Reviewers: @andrewyatz
Similarity score: 0.7187

reper: Genome-wide identification, classification and quantification of repetitive elements without an assembled genome
Submitting author: @nterhoeven
Handling editor: @mgymrek (Retired)
Reviewers: @jsgalan
Similarity score: 0.7062

ALPPACA - A tooL for Prokaryotic Phylogeny And Clustering Analysis
Submitting author: @hkaspersen
Handling editor: @csoneson (Active)
Reviewers: @mberacochea, @hseabolt, @rcannood
Similarity score: 0.7055

A reproducible Snakemake pipeline to analyse Illumina paired-end data from ChiP-Seq experiments
Submitting author: @mgalland
Handling editor: @brainstorm (Retired)
Reviewers: @vladsaveliev
Similarity score: 0.6999

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Oct 20, 2024

@Juke34 Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).
  • Since cloc does not count lines of nextflow code, could you help provide a summary of the number of lines of code contained in this submission (that are fully your own work). Thanks!
  • Please format the paper as per our guidelines, i.e. a Statement of Need section is needed. You can call @editorialbot generate pdf here to update the paper.

@Juke34
Copy link

Juke34 commented Oct 21, 2024

@editorialbot check reference

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@Juke34
Copy link

Juke34 commented Oct 21, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/BIOINFORMATICS/BTP324 is OK
- 10.1093/BIOINFORMATICS/BTP698 is OK
- 10.1038/NMETH.1923 is OK
- 10.1093/NAR/GKT214 is OK
- 10.1186/GB-2013-14-4-R36 is OK
- 10.1093/bioinformatics/bts635 is OK
- 10.1371/journal.pone.0163962 is OK
- 10.1093/bioinformatics/btw354 is OK
- 10.1038/nmeth.4197 is OK
- 10.1038/nbt.3820 is OK
- 10.1371/JOURNAL.PCBI.1005944 is OK
- 10.1038/s41592-018-0001-7 is OK
- 10.1101/720458 is OK
- 10.1093/BIOINFORMATICS/BTAB705 is OK
- 10.1093/gigascience/giab008 is OK
- 10.1002/imt2.107 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: novoAlign | Novocraft
- No DOI given, and none found for title: BBMap
- No DOI given, and none found for title: Aligning sequence reads, clone sequences and assem...
- No DOI given, and none found for title: FastQC
- No DOI given, and none found for title: A Recent ( 2020 ) Comparative Analysis of Genome A...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@Juke34
Copy link

Juke34 commented Oct 21, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/BIOINFORMATICS/BTP324 is OK
- 10.1093/BIOINFORMATICS/BTP698 is OK
- 10.1038/NMETH.1923 is OK
- 10.1093/NAR/GKT214 is OK
- 10.1186/GB-2013-14-4-R36 is OK
- 10.1093/bioinformatics/bts635 is OK
- 10.1371/journal.pone.0163962 is OK
- 10.1093/bioinformatics/btw354 is OK
- 10.1038/nmeth.4197 is OK
- 10.1038/nbt.3820 is OK
- 10.1371/JOURNAL.PCBI.1005944 is OK
- 10.1038/s41592-018-0001-7 is OK
- 10.1101/720458 is OK
- 10.1038/s41587-019-0201-4 is OK
- 10.1093/BIOINFORMATICS/BTAB705 is OK
- 10.1093/gigascience/giab008 is OK
- 10.1002/imt2.107 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: novoAlign | Novocraft
- No DOI given, and none found for title: BBMap
- No DOI given, and none found for title: Aligning sequence reads, clone sequences and assem...
- No DOI given, and none found for title: FastQC

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@Juke34
Copy link

Juke34 commented Oct 21, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

sam2lca: Lowest Common Ancestor for SAM/BAM/CRAM alignment files
Submitting author: @maxibor
Handling editor: @jmschrei (Active)
Reviewers: @fasnicar, @marouenbg
Similarity score: 0.7475

RNAsik: A Pipeline for complete and reproducible RNA-seq analysis that runs anywhere with speed and ease
Submitting author: @serine
Handling editor: @pjotrp (Retired)
Reviewers: @andrewyatz
Similarity score: 0.7246

reper: Genome-wide identification, classification and quantification of repetitive elements without an assembled genome
Submitting author: @nterhoeven
Handling editor: @mgymrek (Retired)
Reviewers: @jsgalan
Similarity score: 0.7173

A reproducible Snakemake pipeline to analyse Illumina paired-end data from ChiP-Seq experiments
Submitting author: @mgalland
Handling editor: @brainstorm (Retired)
Reviewers: @vladsaveliev
Similarity score: 0.7018

ALPPACA - A tooL for Prokaryotic Phylogeny And Clustering Analysis
Submitting author: @hkaspersen
Handling editor: @csoneson (Active)
Reviewers: @mberacochea, @hseabolt, @rcannood
Similarity score: 0.6958

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Juke34
Copy link

Juke34 commented Oct 21, 2024

Dear @Kevin-Mattheus-Moerman,

I have addressed all the issues you pointed out.
About the number of lines of code contained in this submission, it should be 3538 lines (counted using wc -l)

Best regards,

Jacques Dainat

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @jromanowska as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@jromanowska do you think you can help edit this one?

@jromanowska
Copy link

Sure!

@jromanowska
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @jromanowska is now the editor

@jromanowska
Copy link

Hi, @Juke34 👋
I will take care of the process from now on. I will try to find reviewers, but please let me know if you have any suggestions (or oppositions). When naming reviewers, write their GitHub handles without @, so that they won't get notified.

@Juke34
Copy link

Juke34 commented Nov 4, 2024

Hi @jromanowska, here a list of potential reviewers:

  • stevokeyo
  • rcannood
  • adrientaudiere
  • gchure

@jromanowska
Copy link

👋 @hkaspersen, @jhayer, @stevokeyo, @rcannood, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@jhayer
Copy link

jhayer commented Nov 12, 2024

Hi, I am sorry but I will have to decline for this review. We have a conflict of interest here.
Kind regards,
Juliette

@jromanowska
Copy link

Hi, I am sorry but I will have to decline for this review. We have a conflict of interest here. Kind regards, Juliette

Thank you for the reply, @jhayer. Could you suggest someone who might be able to review this software? (Preferentially not a cis-male)

@rcannood
Copy link

I can review!

I am a cis male, though, so not sure whether I'm still eligible 😅

@jromanowska
Copy link

I can review!

I am a cis male, though, so not sure whether I'm still eligible 😅

Thanks, @rcannood! Yes, you are eligible. ;) I was asking Juliette for recommendations for someone non cis-male because all the other people I could find were (assumingly) cis-male. It's always good to have a broad spectrum of reviewers, if possible.

@hkaspersen
Copy link

@jromanowska I am sorry I am unable to provide a review here, currently swamped! But thank you for the invitation!

@jromanowska
Copy link

@jromanowska I am sorry I am unable to provide a review here, currently swamped! But thank you for the invitation!

That's fine, thanks for letting us know. If you know anyone who could be willing to review this, write their emails or GitHub handles here (but without the '@' sign).

@jromanowska
Copy link

@editorialbot add @rcannood as reviewer

@editorialbot
Copy link
Collaborator Author

@rcannood added to the reviewers list!

@jromanowska
Copy link

👋 @adrientaudiere, @gchure, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@gchure
Copy link

gchure commented Dec 2, 2024

Hi @jromanowska, happy to review!

@jromanowska
Copy link

@editorialbot add @gchure as reviewer

@editorialbot
Copy link
Collaborator Author

@gchure added to the reviewers list!

@jromanowska
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nextflow pre-review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

8 participants