Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Control software for the open-source Broadly Reconfigurable and Expandable Automation Device (BREAD) System #7189

Closed
editorialbot opened this issue Sep 7, 2024 · 14 comments
Labels
C++ HTML pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @xanderchinxyz (Xander Chin)
Repository: https://github.com/FHafting/BREAD-Local-Software
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/70f05dd11aa66eb9468ecc3fa5293252"><img src="https://joss.theoj.org/papers/70f05dd11aa66eb9468ecc3fa5293252/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/70f05dd11aa66eb9468ecc3fa5293252/status.svg)](https://joss.theoj.org/papers/70f05dd11aa66eb9468ecc3fa5293252)

Author instructions

Thanks for submitting your paper to JOSS @xanderchinxyz. Currently, there isn't a JOSS editor assigned to your paper.

@xanderchinxyz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Sep 7, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.ohx.2023.e00467 is OK
- 10.1016/j.ohx.2020.e00137 is OK
- 10.1088/1361-6501/ac9994 is OK
- 10.1371/journal.pbio.3000014 is OK
- 10.3390/electronics12244893 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Plotly.js
- No DOI given, and none found for title: Arduino-ESP32
- No DOI given, and none found for title: ESPAsyncWebServer
- No DOI given, and none found for title: MOST_OpenReactor

❌ MISSING DOIs

- 10.1016/j.measurement.2014.05.010 may be a valid DOI for title: Low-cost open-source multifunction data acquisitio...
- 10.1109/nssmic.2014.7431254 may be a valid DOI for title: Design of the SLAC RCE Platform: A general purpose...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (474.9 files/s, 153551.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            118             12           1889
Arduino Sketch                   3            231            127           1383
TeX                              1             10              0            247
Markdown                         2             22              0             67
YAML                             1              1              4             19
JavaScript                       1              0             51             10
CSV                              3              0              0              9
JSON                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            13            382            194           3627
-------------------------------------------------------------------------------

Commit count by author:

    31	xanderchinxyz
     8	Xander Chin
     8	finnhafting
     1	Finn Hafting

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1124

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pybehave: a hardware agnostic, Python-based framework for controlling behavioral neuroscience experiments
Submitting author: @theonlydvr
Handling editor: @sappelhoff (Active)
Reviewers: @tuliofalmeida, @alustig3
Similarity score: 0.6535

jsPsych: Enabling an Open-Source Collaborative Ecosystem of Behavioral Experiments
Submitting author: @jodeleeuw
Handling editor: @oliviaguest (Active)
Reviewers: @pmcharrison, @xinyiguan, @chartgerink
Similarity score: 0.6305

CHAMP is a HPC Access and Metadata Portal
Submitting author: @cc-a
Handling editor: @crvernon (Active)
Reviewers: @thurber, @acrlakshman
Similarity score: 0.6272

Autosubmit GUI: A Javascript-based Graphical User Interface to Monitor Experiments Workflow Execution
Submitting author: @wuruchi
Handling editor: @arfon (Active)
Reviewers: @djmitche, @ikayz
Similarity score: 0.6264

Pyafscgap.org: Open source multi-modal Python-based tools for NOAA AFSC RACE GAP
Submitting author: @sampottinger
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @Kevin-Mattheus-Moerman
Similarity score: 0.6188

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Sep 7, 2024

@editorialbot query scope

@xanderchinxyz – many thanks for your submission to JOSS. I'm going to start a scope review amongst the JOSS editors to decide if this submission is research software as defined by JOSS. This does not mean that it is not software that is useful in research, but just that JOSS might not consider it in scope for review as research software.

This process will likely take a week or so to complete.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Sep 7, 2024
@arfon
Copy link
Member

arfon commented Sep 7, 2024

@xanderchinxyz – could you please explain how this software can be tested?

@xanderchinxyz
Copy link

@xanderchinxyz – could you please explain how this software can be tested?

Hi @arfon the software can be tested with a SparkFun ESP32 WROOM Thing Plus that has a mounted SD card. Sample data from the CSV file can then be shown and displayed when connecting to the locally hosted website. However, to test the control functionality, additional hardware from the BREAD system is required, which we're happy to provide if needed.

@kyleniemeyer
Copy link

@xanderchinxyz unfortunately, the JOSS editorial board has found your submission out of scope for the journal. Please take a look at alternate venues for reviewing and archiving software packages to get credit for your efforts.

@kyleniemeyer
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ HTML pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

4 participants