Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: seismolab: A Python package for analyzing space-based observations of variable stars #7095

Closed
editorialbot opened this issue Aug 9, 2024 · 22 comments
Closed

[PRE REVIEW]: seismolab: A Python package for analyzing space-based observations of variable stars #7095

editorialbot opened this issue Aug 9, 2024 · 22 comments
Assignees
@warrickball
Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 9, 2024 •
edited
Loading

Submitting author: @astrobatty (Attila Bódi)
Repository: https://github.com/konkolyseismolab/seismolab
Branch with paper.md (empty if default branch):
Version: v1.1.2
Editor: @warrickball
Reviewers: @keatonb, @darthoctopus
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/45d943030801e47eb71bbd445ca4b957"><img src="https://joss.theoj.org/papers/45d943030801e47eb71bbd445ca4b957/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/45d943030801e47eb71bbd445ca4b957/status.svg)](https://joss.theoj.org/papers/45d943030801e47eb71bbd445ca4b957)

Author instructions

Thanks for submitting your paper to JOSS @astrobatty. Currently, there isn't a JOSS editor assigned to your paper.

@astrobatty if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Aug 9, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1749-6632.1997.tb51656.x is OK
- 10.1111/j.1365-2966.2009.14625.x is OK
- 10.1051/0004-6361/201322361 is OK
- 10.3847/0004-637X/818/2/130 is OK
- 10.1051/aas:2000332 is OK
- 10.3847/1538-3881/abd806 is OK
- 10.3847/1538-4365/abd4e3 is OK
- 10.3847/1538-4365/ac2ee2 is OK
- 10.1093/mnras/stad556 is OK
- 10.1051/0004-6361/202346094 is OK

MISSING DOIs

- No DOI given, and none found for title: The O-C Diagram: Basic Procedures

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (848.1 files/s, 181540.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          30           1125           1392           3704
Jupyter Notebook                 6              0           3141            528
TeX                              1             10              0            181
reStructuredText                 5             79             85             66
YAML                             2              5              4             46
Markdown                         2             17              0             45
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                            49           1248           4630           4611
-------------------------------------------------------------------------------

Commit count by author:

   149	astrobatty
    20	Attila Bódi

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 459

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm
Copy link

dfm commented Aug 9, 2024

@astrobatty — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, please add a section called "Statement of need" to your paper and then comment @editorialbot generate pdf on this thread.

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Maelstrom: A Python package for identifying companions to pulsating stars from their light travel time variations
Submitting author: @danhey
Handling editor: @mbobra (Active)
Reviewers: @hpparvi, @mbobra
Similarity score: 0.7624

clustertools: A Python Package for Analyzing Star Cluster Simulations
Submitting author: @webbjj
Handling editor: @christinahedges (Retired)
Reviewers: @lwang-astro, @rieder
Similarity score: 0.7585

stingray: A modern Python library for spectral timing
Submitting author: @dhuppenkothen
Handling editor: @arfon (Active)
Reviewers: @Cadair
Similarity score: 0.7558

ZodiPy: A Python package for zodiacal light simulations
Submitting author: @MetinSa
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7462

The Dusty Evolved Star Kit (DESK): A Python package for fitting the Spectral Energy Distribution of Evolved Stars
Submitting author: @s-goldman
Handling editor: @arfon (Active)
Reviewers: @Deech08, @TomGoffrey
Similarity score: 0.7437

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@astrobatty
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Maelstrom: A Python package for identifying companions to pulsating stars from their light travel time variations
Submitting author: @danhey
Handling editor: @mbobra (Active)
Reviewers: @hpparvi, @mbobra
Similarity score: 0.7590

stingray: A modern Python library for spectral timing
Submitting author: @dhuppenkothen
Handling editor: @arfon (Active)
Reviewers: @Cadair
Similarity score: 0.7551

clustertools: A Python Package for Analyzing Star Cluster Simulations
Submitting author: @webbjj
Handling editor: @christinahedges (Retired)
Reviewers: @lwang-astro, @rieder
Similarity score: 0.7551

DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data
Submitting author: @finagle29
Handling editor: @arfon (Active)
Reviewers: @crhea93, @arjunsavel
Similarity score: 0.7473

ZodiPy: A Python package for zodiacal light simulations
Submitting author: @MetinSa
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7441

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@astrobatty
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Maelstrom: A Python package for identifying companions to pulsating stars from their light travel time variations
Submitting author: @danhey
Handling editor: @mbobra (Active)
Reviewers: @hpparvi, @mbobra
Similarity score: 0.7632

clustertools: A Python Package for Analyzing Star Cluster Simulations
Submitting author: @webbjj
Handling editor: @christinahedges (Retired)
Reviewers: @lwang-astro, @rieder
Similarity score: 0.7565

stingray: A modern Python library for spectral timing
Submitting author: @dhuppenkothen
Handling editor: @arfon (Active)
Reviewers: @Cadair
Similarity score: 0.7565

DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data
Submitting author: @finagle29
Handling editor: @arfon (Active)
Reviewers: @crhea93, @arjunsavel
Similarity score: 0.7536

ZodiPy: A Python package for zodiacal light simulations
Submitting author: @MetinSa
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7470

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@warrickball
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @warrickball is now the editor

@warrickball
Copy link

@editorialbot add @keatonb as reviewer

@editorialbot
Copy link
Collaborator Author

@keatonb added to the reviewers list!

@warrickball
Copy link

@editorialbot add @darthoctopus as reviewer

@editorialbot
Copy link
Collaborator Author

@darthoctopus added to the reviewers list!

@warrickball
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warrickball warrickball

Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dfm @warrickball @astrobatty @editorialbot