Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ggoncoplot: an R package for interactive visualisation of somatic mutation data from cancer patient cohorts #7072

Open
editorialbot opened this issue Aug 5, 2024 · 33 comments
Assignees
Labels
pre-review R TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 5, 2024

Submitting author: @selkamand (Sam El-Kamand)
Repository: https://github.com/selkamand/ggoncoplot
Branch with paper.md (empty if default branch):
Version: v0.1.0
Editor: @ppxasjsm
Reviewers: @zainabarshad
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bff5bd8f5c6aa0b55b83b5d7b7eb1d1f"><img src="https://joss.theoj.org/papers/bff5bd8f5c6aa0b55b83b5d7b7eb1d1f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bff5bd8f5c6aa0b55b83b5d7b7eb1d1f/status.svg)](https://joss.theoj.org/papers/bff5bd8f5c6aa0b55b83b5d7b7eb1d1f)

Author instructions

Thanks for submitting your paper to JOSS @selkamand. Currently, there isn't a JOSS editor assigned to your paper.

@selkamand if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Aug 5, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/imt2.43 is OK
- 10.1101/gr.239244.118 is OK
- 10.1093/bioinformatics/btw325 is OK
- 10.1038/s41587-020-0546-8 is OK
- 10.1016/j.cels.2018.03.002 is OK

MISSING DOIs

- 10.32614/cran.package.ggiraph may be a valid DOI for title: ggiraph: Make ’ggplot2’ Graphics Interactive
- 10.32614/cran.package.patchwork may be a valid DOI for title: patchwork: The Composer of Plots
- No DOI given, and none found for title: ggplot2: Elegant Graphics for Data Analysis

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1205.6 files/s, 248581.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               12            321           1473           1267
XML                              1              0              0           1122
CSV                              3              0              0            824
Markdown                         4             97              0            299
Rmd                              3            198            283            255
YAML                             5             25              7            112
TeX                              1              9              0             98
SVG                              2              0              0              2
-------------------------------------------------------------------------------
SUM:                            31            650           1763           3979
-------------------------------------------------------------------------------

Commit count by author:

    64	Sam El-Kamand
    36	Sam
    29	selkamand
    19	unknown

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 932

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

tidyHeatmap: an R package for modular heatmap production based on tidy principles
Submitting author: @stemangiola
Handling editor: @karthik (Retired)
Reviewers: @rlbarter, @AliciaSchep
Similarity score: 0.7298

HCP: A Matlab package to create beautiful heatmaps with richly annotated covariates
Submitting author: @ManuelaS
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @piermorel
Similarity score: 0.7265

dtrackr: An R package for tracking the provenance of data
Submitting author: @robchallen
Handling editor: @ajstewartlang (Active)
Reviewers: @debruine, @craig-willis
Similarity score: 0.7045

visxhclust: An R Shiny package for visual exploration of hierarchical clustering
Submitting author: @rhenkin
Handling editor: @osorensen (Active)
Reviewers: @jonjoncardoso, @wiljnich
Similarity score: 0.7018

MatSurv: Survival analysis and visualization in MATLAB
Submitting author: @jhcreed
Handling editor: @cMadan (Retired)
Reviewers: @dsurujon, @ManuelaS
Similarity score: 0.7014

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Aug 6, 2024

@selkamand Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

@selkamand
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/imt2.43 is OK
- 10.1101/gr.239244.118 is OK
- 10.1093/bioinformatics/btw325 is OK
- 10.32614/CRAN.package.ggiraph is OK
- 10.32614/cran.package.patchwork is OK
- 10.32614/CRAN.package.ggplot2 is OK
- 10.1038/s41587-020-0546-8 is OK
- 10.1016/j.cels.2018.03.002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@selkamand
Copy link

Thanks @Kevin-Mattheus-Moerman. Missing DOIs and a CONTRIBUTING.md have been added

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Aug 7, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

@selkamand thanks for making those changes. I've just added the query-scope label which will trigger a scope review by the editorial board. The objective of the scope review is to determine if the functionality offered by the work is substantial enough, is research software, and conforms to our substantial scholarly effort criteria. This is normal for projects that are on the small side and also for projects that appear to focus on visualization. The scope review should take about 2 weeks to complete.

@Kevin-Mattheus-Moerman
Copy link
Member

@selkamand I am pleased to inform the board has concluded this work may be in scope for JOSS. We will now proceed to seek a handling editor.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added waitlisted Submissions in the JOSS backlog due to reduced service mode. and removed query-scope Submissions of uncertain scope for JOSS labels Aug 19, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @ppxasjsm as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@ppxasjsm
Copy link

@editorialbot assign @ppxasjsm as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @ppxasjsm is now the editor

@ppxasjsm ppxasjsm removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 1, 2024
@ppxasjsm
Copy link

ppxasjsm commented Sep 1, 2024

@selkamand I'll be editing your submission.
If you could check suggestions for potential reviewers I would appreciate it as it will make the search easier for me. Please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission. Thanks for your help!

@selkamand
Copy link

Hi @ppxasjsm,

I've listed some potential reviewers (* next to those from the list linked above). Hope this helps
Jianhui Gong*
Nicola Cosgrove
Lei Chen
Kim-Anh Lê Cao

@ppxasjsm
Copy link

ppxasjsm commented Sep 5, 2024

Hi @@duncanjunegong would you be willing to review this JOSS submission?

@lpantano
Copy link

lpantano commented Sep 12, 2024

Hi, I am editor for joss (and I saw this), and my colleague @zainabarshad, can be a reviewer for this tool.

@ppxasjsm
Copy link

Hi @zainabarshad that would be amazing if you could review this submission!

@ppxasjsm
Copy link

HI @kelly-sovacool, I was wondering if you were available to review this submission. I am not sure if this fits your remit.

@zainabarshad
Copy link

Hi @ppxasjsm, Great! I'll begin reviewing the code shortly. Are there any specific instructions I should keep in mind in my review?

@kelly-sovacool
Copy link

HI @kelly-sovacool, I was wondering if you were available to review this submission. I am not sure if this fits your remit.

Sorry, I am too busy to review at this time

@ppxasjsm
Copy link

ppxasjsm commented Oct 9, 2024

@editorialbot add @zainabarshad as reviewer

@editorialbot
Copy link
Collaborator Author

@zainabarshad added to the reviewers list!

@ppxasjsm
Copy link

Hi @yafeiwang89, is there any chance you'd be available to review this JOSS submission?

@ppxasjsm
Copy link

Hi @allaway, is there any chance you are available to review this submission for JOSS?

@ppxasjsm
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

7 participants