Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AnalyZe: A MATLAB Application GUI for Visualizing and Analyzing Electrical Impedance Spectroscopy data in Biological Applications #7071

Closed
editorialbot opened this issue Aug 5, 2024 · 40 comments
Labels
HTML Matlab pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @Doug-vN (Douglas van Niekerk)
Repository: https://github.com/bestgroup-Camb/AnalyZe
Branch with paper.md (empty if default branch): JOSS-Submission
Version: v5.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d0c3487cab02b2ce2dc92e2720179527"><img src="https://joss.theoj.org/papers/d0c3487cab02b2ce2dc92e2720179527/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d0c3487cab02b2ce2dc92e2720179527/status.svg)](https://joss.theoj.org/papers/d0c3487cab02b2ce2dc92e2720179527)

Author instructions

Thanks for submitting your paper to JOSS @Doug-vN. Currently, there isn't a JOSS editor assigned to your paper.

@Doug-vN if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Aug 5, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (113.7 files/s, 155382.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                           5           2626           1152           9477
TeX                              1             12              3            160
Markdown                         2             57              0            141
YAML                             1              1              4             18
HTML                             1              2              0             14
-------------------------------------------------------------------------------
SUM:                            10           2698           1159           9810
-------------------------------------------------------------------------------

Commit count by author:

   112	Doug-vN
     2	bestgroup-Camb

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1941

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

@Doug-vN
Copy link

Doug-vN commented Aug 5, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @Doug-vN, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@Doug-vN
Copy link

Doug-vN commented Aug 5, 2024

Hello, here are my suggestions for potential reviewers:

  1. Julie-Fabre
  2. alberto-battistel
  3. larsenkg

@Doug-vN
Copy link

Doug-vN commented Aug 5, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@Doug-vN
Copy link

Doug-vN commented Aug 5, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

impedance.py: A Python package for electrochemical impedance analysis
Submitting author: @mdmurbach
Handling editor: @mbobra (Active)
Reviewers: @ma-sadeghi, @EricaEgg
Similarity score: 0.7164

fuelcell: A Python package and graphical user interface for electrochemical data analysis
Submitting author: @samaygarg
Handling editor: @jgostick (Active)
Reviewers: @jlopata21, @shimpalee
Similarity score: 0.6716

Viime: Visualization and Integration of Metabolomics Experiments
Submitting author: @waxlamp
Handling editor: @lpantano (Active)
Reviewers: @joannawolthuis, @rowlandm, @jkanche
Similarity score: 0.6662

OT_Analysis: a software for rich analysis of force curves when probing living cells with optical tweezers
Submitting author: @phpuech
Handling editor: @prashjha (Active)
Reviewers: @ryEllison, @florian-huber
Similarity score: 0.6593

RHEOS.jl -- A Julia Package for Rheology Data Analysis
Submitting author: @akabla
Handling editor: @jedbrown (Active)
Reviewers: @adambeall, @gbruer15, @HaoZeke
Similarity score: 0.6569

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK

MISSING DOIs

- No DOI given, and none found for title: Electrochemical methods: fundamentals and applicat...
- No DOI given, and none found for title: Electrochemical impedance spectroscopy
- Entry without DOI or title found
- No DOI given, and none found for title: ZView® For Windows — scribner.com
- No DOI given, and none found for title: NOVA — metrohm.com
- No DOI given, and none found for title: PSTrace - PalmSens — palmsens.com
- 10.21105/joss.02349 may be a valid DOI for title: impedance. py: A Python package for electrochemica...
- No DOI given, and none found for title: ZFit
- 10.1186/2045-8118-10-5 may be a valid DOI for title: Impedance-based cell monitoring: barrier propertie...
- 10.1016/0167-2738(86)90031-7 may be a valid DOI for title: A nonlinear least squares fit procedure for analys...
- No DOI given, and none found for title: Global Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Linear systems and signals
- No DOI given, and none found for title: Electrochemical impedance spectroscopy─ a tutorial
- No DOI given, and none found for title: Gaps in Globular Cluster Streams: Pal 5 and the Ga...
- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: Fidgit: An ungodly union of GitHub and Figshare

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@Doug-vN Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • The above code report shows 9477 lines of MATLAB code. In the case of GUIs or APPs it is often the case that significant portions of the code are "auto-generated" e.g. using "MATLABs App Designer utility". Therefore, could you please clarify what portion (or what files if you can link to them) where your own contribution? Usually this is the code responsible for functional analysis only, rather than the GUI handling.
  • In your paper affiliations, please spell out UK as United Kingdom.
  • I recommend adding a .gitignore file to your main repository folder and to add the following lines to help git ignore MATLAB's temporary backup files (.asv files).
# Ignore MATLAB temporary files
*.asv

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "-" (NAME) [#<BibTeX::Bibliography data=[1]>, "@", #<BibTeX::Entry >, {:title=>["Electrochemical impedance spectroscopy"], :author=>["Wang, Shangshang and Zhang, Jianbo and Gharbi, Ouma{\\\"\\i}ma and Vivier, Vincent and Gao, Ming and Orazem, Mark E"], :journal=>["Nature Reviews Methods Primers"], :volume=>["1"], :number=>["1"], :pages=>["41"], :year=>["2021"], :publisher=>["Nature Publishing Group UK London"]}, ",", "doi"]

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "doi" (NAME) [#<BibTeX::Bibliography data=[8]>, "@", #<BibTeX::Entry >, {:title=>["Impedance-based cell monitoring: barrier properties and beyond"], :author=>["Benson, Kathrin and Cramer, Sandra and Galla, Hans-Joachim"], :journal=>["Fluids and Barriers of the CNS"], :volume=>["10"], :pages=>["1--11"], :year=>["2013"], :publisher=>["Springer"]}]

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s43586-021-00039-w is OK
- 10.21105/joss.02349 is OK
- 10.1186/2045-8118-10-5 is OK
- 10.1016/0167-2738(86)90031-7 is OK
- 10.1021/acsmeasuresciau.2c00070 is OK

MISSING DOIs

- No DOI given, and none found for title: Electrochemical methods: fundamentals and applicat...
- Entry without DOI or title found
- No DOI given, and none found for title: ZView® For Windows — scribner.com
- No DOI given, and none found for title: NOVA — metrohm.com
- No DOI given, and none found for title: PSTrace - PalmSens — palmsens.com
- No DOI given, and none found for title: ZFit
- No DOI given, and none found for title: Global Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Linear systems and signals

INVALID DOIs

- None

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "author" (NAME) [#<BibTeX::Bibliography data=[2]>, "@", #<BibTeX::Entry >, {:title=>["EC-Lab --- biologic.com"]}]

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s43586-021-00039-w is OK
- 10.21105/joss.02349 is OK
- 10.1186/2045-8118-10-5 is OK
- 10.1016/0167-2738(86)90031-7 is OK
- 10.1021/acsmeasuresciau.2c00070 is OK

MISSING DOIs

- No DOI given, and none found for title: Electrochemical methods: fundamentals and applicat...
- No DOI given, and none found for title: EC-Lab — biologic.com
- No DOI given, and none found for title: ZView® For Windows — scribner.com
- No DOI given, and none found for title: NOVA — metrohm.com
- No DOI given, and none found for title: PSTrace - PalmSens — palmsens.com
- No DOI given, and none found for title: ZFit
- No DOI given, and none found for title: Global Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Optimization Toolbox — uk.mathworks.com
- No DOI given, and none found for title: Linear systems and signals

INVALID DOIs

- None

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

impedance.py: A Python package for electrochemical impedance analysis
Submitting author: @mdmurbach
Handling editor: @mbobra (Active)
Reviewers: @ma-sadeghi, @EricaEgg
Similarity score: 0.7168

fuelcell: A Python package and graphical user interface for electrochemical data analysis
Submitting author: @samaygarg
Handling editor: @jgostick (Active)
Reviewers: @jlopata21, @shimpalee
Similarity score: 0.6721

Viime: Visualization and Integration of Metabolomics Experiments
Submitting author: @waxlamp
Handling editor: @lpantano (Active)
Reviewers: @joannawolthuis, @rowlandm, @jkanche
Similarity score: 0.6668

RHEOS.jl -- A Julia Package for Rheology Data Analysis
Submitting author: @akabla
Handling editor: @jedbrown (Active)
Reviewers: @adambeall, @gbruer15, @HaoZeke
Similarity score: 0.6603

OT_Analysis: a software for rich analysis of force curves when probing living cells with optical tweezers
Submitting author: @phpuech
Handling editor: @prashjha (Active)
Reviewers: @ryEllison, @florian-huber
Similarity score: 0.6593

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Doug-vN
Copy link

Doug-vN commented Aug 6, 2024

Hi @Kevin-Mattheus-Moerman thanks so much for your comment!

I've now:

  • included all doi's where available.
  • updated paper affiliations text.
  • included a .gitignore file

My code contribution (barring tests) is contained in the file AnalyZe.m.
The autogenerated code produced by the MATLAB App designer consists of lines:

  • 1-558
  • 9170-12212 (end)

My code responsible for functional analysis is included in lines: 559-2037.
The remainder of the code (lines: 2038-9169) was written by me but primarily consists (with a few exceptions) of the On-Event callback functions used by the application to handle user input, data, visualizations and other GUI functionality.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Aug 7, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

@Doug-vN thanks for the detailed response, and for making those changes. I've just added the query-scope label which will trigger a scope review by the editorial board. The objective of the scope review is to determine if the functionality offered by the work is substantial enough, is research software, and conforms to our substantial scholarly effort criteria. This is normal for projects that are on the small side, or which appear to focus on visualization, or which are mostly an GUI/App. The scope review should take about 2 weeks to complete.

@Kevin-Mattheus-Moerman
Copy link
Member

Note to editors, executing cloc on lines 559-2037 in Analyze.m returns:

-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                           1            371            103           1005
-------------------------------------------------------------------------------

@Doug-vN
Copy link

Doug-vN commented Aug 7, 2024

Sounds good, thanks @Kevin-Mattheus-Moerman!

@Doug-vN
Copy link

Doug-vN commented Aug 22, 2024

Hi @Kevin-Mattheus-Moerman, just checking in! Was there anything more that you needed from me at this time?

@Doug-vN
Copy link

Doug-vN commented Sep 10, 2024

Hi @Kevin-Mattheus-Moerman, any word on the scope review?

@Kevin-Mattheus-Moerman
Copy link
Member

@Doug-vN apologies for the slower than usual scope review. Unfortunately, after review by the JOSS editorial team we've determined that this work is not in scope for JOSS.

The scope decision was based largely on the relatively small size of the core code developed (see also our substantial scholarly effort criteria), and also the project organisation (core functionality is capture by a single MATLAB file featuring both original and autogenerated code).

We will next proceed to reject this submission.

One possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML Matlab pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

3 participants