Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AstroLink: A Python package for robust and interpretable astrophysical clustering #7058

Closed
editorialbot opened this issue Jul 30, 2024 · 17 comments
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @william-h-oliver (William Oliver)
Repository: https://github.com/william-h-oliver/astrolink
Branch with paper.md (empty if default branch):
Version: e.g. v0.2.0
Editor: Pending
Reviewers: Pending
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/420243da27511961ca92ee3cb5cc5a73"><img src="https://joss.theoj.org/papers/420243da27511961ca92ee3cb5cc5a73/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/420243da27511961ca92ee3cb5cc5a73/status.svg)](https://joss.theoj.org/papers/420243da27511961ca92ee3cb5cc5a73)

Author instructions

Thanks for submitting your paper to JOSS @william-h-oliver. Currently, there isn't a JOSS editor assigned to your paper.

@william-h-oliver if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jul 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1046/j.1365-8711.2001.04912.x is OK
- 10.1088/0067-0049/182/2/608 is OK
- 10.1088/0004-637x/762/2/109 is OK
- 10.1017/pasa.2019.12 is OK
- 10.1086/152650 is OK
- 10.1086/163168 is OK
- 10.1086/340957 is OK
- 10.1086/177418 is OK
- 10.1111/j.1365-2966.2011.18690.x is OK
- 10.1093/mnras/stx2937 is OK
- 10.1093/mnras/sty912 is OK
- 10.1088/0004-637x/703/1/1061 is OK
- 10.1093/mnras/staa3879 is OK
- 10.1093/mnras/stac1701 is OK
- 10.1093/mnras/stae1029 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1051/0004-6361/201629719 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (933.7 files/s, 95744.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5            138            283            577
Markdown                         6            125              0            333
TeX                              1             15              0            228
YAML                             7             28             14            133
Jupyter Notebook                 1              0            521            113
TOML                             1              6             13             55
DOS Batch                        1              8              1             26
reStructuredText                 3              7             10             12
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            26            331            849           1486
-------------------------------------------------------------------------------

Commit count by author:

    71	william-h-oliver

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 759

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

A-SLOTH: Ancient Stars and Local Observables by Tracing Halos
Submitting author: @HartwigTilman
Handling editor: @dfm (Active)
Reviewers: @gregbryan, @kaleybrauer
Similarity score: 0.7390

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.7317

CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies
Submitting author: @tibordome
Handling editor: @adonath (Active)
Reviewers: @benediktdiemer, @phil-mansfield
Similarity score: 0.7240

MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM
Submitting author: @kyleaoman
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7190

scida: scalable analysis for scientific big data
Submitting author: @cbyrohl
Handling editor: @mbobra (Active)
Reviewers: @egaraldi, @kyleaoman
Similarity score: 0.7061

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@dfm
Copy link

dfm commented Jul 30, 2024

@editorialbot query scope

@william-h-oliver — Thanks for your submission! Given the small size and history of this code base, I have submitted this pre-review for editorial review (see the "substantial scholarly effort" criterion). This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jul 30, 2024
@william-h-oliver
Copy link

Fixed invalid doi

@william-h-oliver
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

A-SLOTH: Ancient Stars and Local Observables by Tracing Halos
Submitting author: @HartwigTilman
Handling editor: @dfm (Active)
Reviewers: @gregbryan, @kaleybrauer
Similarity score: 0.7365

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.7305

CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies
Submitting author: @tibordome
Handling editor: @adonath (Active)
Reviewers: @benediktdiemer, @phil-mansfield
Similarity score: 0.7251

MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM
Submitting author: @kyleaoman
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7201

scida: scalable analysis for scientific big data
Submitting author: @cbyrohl
Handling editor: @mbobra (Active)
Reviewers: @egaraldi, @kyleaoman
Similarity score: 0.7101

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@william-h-oliver
Copy link

Hi @dfm, I was wondereing if I could get an update on the progress of the pre-review?

@dfm
Copy link

dfm commented Sep 21, 2024

@william-h-oliver — I'm so sorry about the slow turnaround on this! We've had a real backlog coming out of the summer and everything has been slow here at JOSS, but we're catching up now. Thank you for your patience!!

Unfortunately, in the end, the editorial team has decided that this submission does not satisfy our criteria for "substantial scholarly effort" given the small size and history of the code base. This means that we won't move this submission on to review, because it is not considered in scope for JOSS. I want to emphasize that this is not a judgement of the quality of the work, and I recommend considering other venues for publishing your software or otherwise creating a citable entity (some suggestions can be found here).

Thanks again for your patience, and I'm sorry about the negative outcome on the scope query!

@dfm
Copy link

dfm commented Sep 21, 2024

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

3 participants