Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: WeibullR.plotly: Interactive Weibull Probability Plots #6994

Closed
editorialbot opened this issue Jul 16, 2024 · 23 comments
Closed
Labels
C++ HTML pre-review query-scope Submissions of uncertain scope for JOSS R rejected SCSS TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 16, 2024

Submitting author: @paulgovan (Paul Govan)
Repository: https://github.com/paulgovan/WeibullR.plotly
Branch with paper.md (empty if default branch): main
Version: v0.2.1
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1afecf20794f86fdba8ec11b19a04d3e"><img src="https://joss.theoj.org/papers/1afecf20794f86fdba8ec11b19a04d3e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1afecf20794f86fdba8ec11b19a04d3e/status.svg)](https://joss.theoj.org/papers/1afecf20794f86fdba8ec11b19a04d3e)

Author instructions

Thanks for submitting your paper to JOSS @paulgovan. Currently, there isn't a JOSS editor assigned to your paper.

@paulgovan if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jul 16, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: learnr: Interactive Tutorials for R
- 10.1201/9780429447273 may be a valid DOI for title: Interactive Web-Based Data Visualization with R, p...
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: shiny: Web Application Framework for R
- No DOI given, and none found for title: WeibullR: Weibull Analysis for Reliability Enginee...
- 10.32614/cran.package.weibullr.learnr may be a valid DOI for title: WeibullR.learnr: An Interactive Introduction to Li...
- 10.32614/cran.package.weibullr.plotly may be a valid DOI for title: WeibullR.plotly: Interactive Weibull Probability P...
- No DOI given, and none found for title: WeibullR.shiny: A ’Shiny’ App for Weibull Analysis...
- No DOI given, and none found for title: The new Weibull handbook

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.54 s (1562.4 files/s, 372154.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                  1064          68521          29009         215841
HTML                           126           3840            231          49031
Sass                           423          11874          10180          41652
JavaScript                      82           8066           6100          31311
CSS                            189           4568            680          25104
R                              223           4246           4847          13794
Markdown                        43           5039              0           9723
C++                             86           1633           2206           5810
Rmd                             74           4301           8663           3534
TeX                              9            122             26           1092
SVG                             28              3              2           1006
Lua                              7            161            251            670
JSON                            10              0              0            497
XML                             12              0              0            240
LESS                            10             13              7            102
C                                6             32             15            101
YAML                             9             10              7             87
CSV                              3              0              0             84
MATLAB                           3              7              8             53
Bourne Shell                     3             11              9             32
make                             2             19              9             31
-------------------------------------------------------------------------------
SUM:                          2412         112466          62250         399795
-------------------------------------------------------------------------------

Commit count by author:

    61	Paul Govan

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 468

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Visualizations with statistical details: The ggstatsplot approach
Submitting author: @IndrajeetPatil
Handling editor: @csoneson (Active)
Reviewers: @njtierney, @kevinrue
Similarity score: 0.6974

FielDHub: A Shiny App for Design of Experiments in Life Sciences
Submitting author: @DidierMurilloF
Handling editor: @csoneson (Active)
Reviewers: @Prof-ThiagoOliveira, @dlebauer
Similarity score: 0.6856

lifelines: survival analysis in Python
Submitting author: @CamDavidsonPilon
Handling editor: @trallard (Retired)
Reviewers: @becarioprecario, @sunhwan
Similarity score: 0.6847

dtrackr: An R package for tracking the provenance of data
Submitting author: @robchallen
Handling editor: @ajstewartlang (Active)
Reviewers: @debruine, @craig-willis
Similarity score: 0.6790

BayesianNetwork: Interactive Bayesian Network Modeling and Analysis
Submitting author: @paulgovan
Handling editor: @katyhuff (Retired)
Reviewers: @rgiordan
Similarity score: 0.6774

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @paulgovan - how can we understand what the software is specifically in this submission? The code is the repository seems quite large for the functionality described in the paper. Can you explain?

@paulgovan
Copy link

Hi @danielskatz,

This software is intended to serve as an add-on to the WeibullR package, a well-known R package for life data analysis, reliability analysis, and Weibull analysis. It enhances Weibull modeling by enabling interactive, web-based plotting options—a feature commonly found in commercial software but, to the best of my knowledge, not available in open source software.

In addition to the core code, the software package includes documentation, tutorials, unit tests, and other supporting resources, which may contribute to its larger size.

@danielskatz
Copy link

Is there a "diff" that I could use to understand what was written for this package vs what already existed? E.g., are all the 200k lines of C/C++ headers original to this package?

@paulgovan
Copy link

I just reviewed the report above, and something seems off. The software is primarily written in R, and is a few hundred lines of code. It appears that some of the HTML, CSS, and JavaScript files might be pulled from the gh-pages branch (website), while the core code is in the main branch.

@danielskatz
Copy link

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@danielskatz
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (928.4 files/s, 93455.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1             84              5            457
R                                6             64             91            429
Markdown                         5            102              0            242
Rmd                              2             39             75             73
TeX                              1              8              0             65
YAML                             3             10              7             61
-------------------------------------------------------------------------------
SUM:                            18            307            178           1327
-------------------------------------------------------------------------------

Commit count by author:

    62	Paul Govan

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 468

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@danielskatz
Copy link

👋 @paulgovan - thanks, that was the issue. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jul 17, 2024
@danielskatz
Copy link

👋 @paulgovan - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

@danielskatz
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ HTML pre-review query-scope Submissions of uncertain scope for JOSS R rejected SCSS TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants