Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: solids4foam-v2.1: A toolbox for performing solid mechanics and fluid-solid interaction simulations in OpenFOAM #6989

Closed
editorialbot opened this issue Jul 15, 2024 · 29 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 15, 2024

Submitting author: @philipcardiff (Philip Cardiff)
Repository: https://github.com/solids4foam/solids4foam
Branch with paper.md (empty if default branch): joss
Version: v2.1
Editor: @kyleniemeyer
Reviewers: @MakisH, @mohd-afeef-badri
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377"><img src="https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377/status.svg)](https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377)

Author instructions

Thanks for submitting your paper to JOSS @philipcardiff. Currently, there isn't a JOSS editor assigned to your paper.

@philipcardiff if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jul 15, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1808.10736 is OK
- 10.1002/nag.2361 is OK
- 10.1016/j.jmbbm.2022.105498 is OK
- 10.1016/j.compbiomed.2023.107178 is OK
- 10.1016/j.apm.2021.09.009 is OK
- 10.1002/nme.7302 is OK
- 10.1016/j.commatsci.2012.03.011 is OK
- 10.1016/j.cma.2013.09.008 is OK
- 10.1016/j.compstruc.2016.07.004 is OK
- 10.1002/nme.5345 is OK
- 10.21278/TOF.42301 is OK
- 10.1007/978-3-319-60846-4_1 is OK
- 10.1016/j.compstruc.2008.11.013 is OK

MISSING DOIs

- No DOI given, and none found for title: OpenFOAM.com
- No DOI given, and none found for title: OpenFOAM.org
- No DOI given, and none found for title: foam-extend project

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.71 s (1271.4 files/s, 310953.2 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                             364          25062          22528         103345
C/C++ Header                    348          15669          18459          23230
Markdown                         38           1816              0           4135
Bourne Again Shell              120            702            646           1931
m4                                7            136              0            772
Bourne Shell                     10            128            261            625
TeX                               1             15              0            177
YAML                              4             20              8            131
XML                               2             14              0            125
Fortran 77                        1              7              5             52
Dockerfile                        4             27             43             39
HLSL                              1              0              0              8
--------------------------------------------------------------------------------
SUM:                            900          43596          41950         134570
--------------------------------------------------------------------------------

Commit count by author:

   959	Philip Cardiff
    63	Danial Khazaei
    16	Iago Lessa de Oliveira
     6	philipcardiff
     3	Jeff Heylmun
     3	wyldckat
     2	Saber Mohammadi
     2	Zeljko Tukovic
     2	iagolessa
     2	scottlevie97
     1	Cyrille Bonamy
     1	Karen FitzGerald
     1	Philipp Milovic
     1	Sindeev Sergey
     1	emadtandis

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 668

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Ocellaris: a DG FEM solver for free-surface flows
Submitting author: @TormodLandet
Handling editor: @labarba (Retired)
Reviewers: @inducer, @piyueh
Similarity score: 0.7351

scikit-fem: A Python package for finite element assembly
Submitting author: @kinnala
Handling editor: @meg-simula (Retired)
Reviewers: @thelfer, @AnjaliSandip
Similarity score: 0.7291

directChillFoam: an OpenFOAM application for direct-chill casting
Submitting author: @blebon
Handling editor: @meg-simula (Retired)
Reviewers: @chennachaos, @bzindovic
Similarity score: 0.7183

$hp\mathrm{3D}$: A Scalable MPI/OpenMP $hp$-Adaptive Finite Element Software Library for Complex Multiphysics Applications
Submitting author: @stefanhenneking
Handling editor: @jedbrown (Active)
Reviewers: @peterrum, @likask
Similarity score: 0.7102

Gridap: An extensible Finite Element toolbox in Julia
Submitting author: @fverdugo
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC
Similarity score: 0.7029

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

For full disclosure, @philipcardiff is a JOSS editor.

@kyleniemeyer
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kyleniemeyer is now the editor

@philipcardiff
Copy link

@ztukovic @iBatistic, this is the pre-review thread.

@kyleniemeyer
Copy link

@TJFord @sthavishtha @mohd-afeef-badri @MakisH would any of you be able to review this submission for JOSS? It is a toolbox for simulating solid mechanics and fluid-solid interactions in OpenFOAM. Thanks!

@MakisH
Copy link

MakisH commented Oct 22, 2024

@kyleniemeyer I am available and have the can review this submission.

For full disclosure, I have met @philipcardiff in conferences and he has previously contributed solids4foam-related extensions to the preCICE OpenFOAM adapter and tutorials (which I work on), for which reason we appear together in a dataset publication (2022): https://darus.uni-stuttgart.de/dataset.xhtml?persistentId=doi:10.18419/darus-3576 In the same context, he has been invited speaker to a workshop I and colleagues organized in February 2023: https://precice.org/precice-workshop-2023.html

From my side, I have had no involvement to the solids4foam so far, but I have shortly used it before in the context of preCICE. I also know the project from many references in the literature. I think I can be give an objective review, and I am interested in seeing how the project evolved since the last time I had a look into it.

@sthavishtha
Copy link

thanks @kyleniemeyer for the invite, but I am unfortunately unavailable until the end of this year.

@kyleniemeyer
Copy link

Thanks @MakisH! That sounds fine to me.

@kyleniemeyer
Copy link

@editorialbot add @MakisH as reviewer

@editorialbot
Copy link
Collaborator Author

@MakisH added to the reviewers list!

@mohd-afeef-badri
Copy link

@kyleniemeyer hello,

Thank you for the invite, you can add me as a reviewer. I would definitely do my best to review this one.

@kyleniemeyer
Copy link

@editorialbot add @mohd-afeef-badri as editor

Thank you!

@editorialbot
Copy link
Collaborator Author

Assigned! @mohd-afeef-badri is now the editor

@kyleniemeyer
Copy link

@editorialbot assign me as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@kyleniemeyer
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kyleniemeyer is now the editor

@kyleniemeyer
Copy link

@editorialbot add @mohd-afeef-badri as reviewer

@editorialbot
Copy link
Collaborator Author

@mohd-afeef-badri added to the reviewers list!

@kyleniemeyer
Copy link

Whoops, sorry for the erroneous commands. I'm actually surprised editorialbot didn't raise an error for the editor assignment...

We have two reviewers, so I'm going to start the review issue now.

@kyleniemeyer
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants