Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference #6382

Closed
editorialbot opened this issue Feb 19, 2024 · 36 comments
Assignees
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 19, 2024

Submitting author: @Edenhofer (Gordian Edenhofer)
Repository: https://github.com/nifty-ppl/nifty
Branch with paper.md (empty if default branch): paper
Version: v8.5
Editor: @dfm
Reviewers: @Abinashbunty, @apizzuto
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9e0b78f8d981abdec4fc84605e46786a"><img src="https://joss.theoj.org/papers/9e0b78f8d981abdec4fc84605e46786a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9e0b78f8d981abdec4fc84605e46786a/status.svg)](https://joss.theoj.org/papers/9e0b78f8d981abdec4fc84605e46786a)

Author instructions

Thanks for submitting your paper to JOSS @Edenhofer. Currently, there isn't a JOSS editor assigned to your paper.

@Edenhofer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Feb 19, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.02 s (233.8 files/s, 106164.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1             30              0           1373
Python                           3             70             55            409
Markdown                         1             54              0            279
-------------------------------------------------------------------------------
SUM:                             5            154             55           2061
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 3216

@editorialbot
Copy link
Collaborator Author

Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Author (Reimar H. Leike) is missing affiliation.

@dfm
Copy link

dfm commented Feb 19, 2024

@editorialbot set NIFTy_8 as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now NIFTy_8

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00695 is OK
- 10.1046/j.1365-8711.2002.05881.x is OK
- 10.3847/1538-4365/ac4df7 is OK
- 10.1051/0004-6361/202141570 is OK
- 10.1051/0004-6361/202141249 is OK
- 10.48550/arXiv.2208.00211 is OK
- 10.48550/arXiv.2206.06143 is OK
- 10.48550/arXiv.2206.06205 is OK
- 10.3847/1538-4365/aafbea is OK
- 10.1086/498708 is OK
- 10.1088/0004-6256/140/6/1868 is OK
- 10.3847/1538-4357/ac1f96 is OK
- 10.48550/ARXIV.2206.10634 is OK
- 10.48550/arXiv.2308.01295 is OK
- 10.1371/journal.pone.0275011 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.48550/ARXIV.1901.11033 is OK
- 10.3390/e23070853 is OK
- 10.3390/psf2022005006 is OK
- 10.1109/TPAMI.2015.2448083 is OK
- 10.3847/1538-3881/aa9332 is OK
- 10.5281/zenodo.10463641 is OK
- 10.18637/jss.v076.i01 is OK
- 10.7717/peerj-cs.55 is OK
- 10.1086/670067 is OK
- 10.1093/mnras/staa278 is OK
- 10.5281/zenodo.8408702 is OK
- 10.48550/arXiv.1912.11554 is OK
- 10.1002/andp.201800290 is OK
- 10.1051/0004-6361/202243319 is OK
- 10.1051/0004-6361/202142846 is OK
- 10.1051/0004-6361/201834695 is OK
- 10.1051/0004-6361/201832832 is OK
- 10.1051/0004-6361/201730831 is OK
- 10.1093/mnras/sty3341 is OK
- 10.1051/0004-6361/202038708 is OK
- 10.1051/0004-6361/201833284 is OK
- 10.3847/2041-8213/ac67db is OK
- 10.1051/0004-6361/201628885 is OK
- 10.1051/0004-6361/202244784 is OK
- 10.1051/0004-6361/202141298 is OK
- 10.48550/arXiv.2204.11715 is OK
- 10.3847/1538-4357/ab5362 is OK
- 10.1093/mnras/sty1008 is OK
- 10.48550/arXiv.2303.03420 is OK
- 10.1051/0004-6361/201935765 is OK
- 10.1051/0004-6361/202142369 is OK
- 10.48550/arXiv.2303.09926 is OK
- 10.1051/0004-6361/201323195 is OK
- 10.48550/arXiv.2206.06710 is OK
- 10.1038/s41586-019-1874-z is OK
- 10.3847/1538-4365/abe465 is OK
- 10.3847/1538-3881/ab99c8 is OK
- 10.48550/arXiv.2206.05796 is OK
- 10.1038/s41550-021-01548-0 is OK
- 10.3847/1538-4357/ab2388 is OK
- 10.1051/0004-6361/202346851 is OK
- 10.48550/arXiv.2304.12350 is OK
- 10.1051/0004-6361/202346423 is OK
- 10.3847/1538-3881/acabc1 is OK
- 10.1051/0004-6361/202140486 is OK
- 10.1051/0004-6361/202243326 is OK
- 10.21105/joss.00695 is OK
- 10.21105/joss.01298 is OK
- 10.1086/427976 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1051/0004-6361/202243819 is OK
- 10.1103/PhysRevE.96.052104 is OK
- 10.1088/1475-7516/2021/04/071 is OK
- 10.48550/arXiv.2308.09176 is OK
- 10.3390/e25040652 is OK
- 10.3390/psf2022005033 is OK
- 10.1051/0004-6361/201935555 is OK

MISSING DOIs

- 10.1051/0004-6361/202038169 may be a valid DOI for title: Resolving nearby dust clouds

INVALID DOIs

- None

@dfm
Copy link

dfm commented Feb 19, 2024

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.35 s (744.5 files/s, 141301.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         238           7079          11063          27373
SVG                              3              3              3           1067
Markdown                         4            178              0            610
reStructuredText                 8            330            235            605
YAML                             1             23              0            161
Dockerfile                       1              3              9             15
Bourne Shell                     1              4              0             12
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                           257           7620          11310          29846
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Failed to discover a Statement of need section in paper

@dfm
Copy link

dfm commented Feb 19, 2024

@editorialbot set paper as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now paper

@dfm
Copy link

dfm commented Feb 19, 2024

@Edenhofer — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, there are a few issues with your paper ☝️ Can you check the affiliations and make sure you have a "Statement of need" section in the paper?

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Feb 19, 2024
@Edenhofer
Copy link

Edenhofer commented Feb 19, 2024

Thanks for opening the pre review issue so quickly!

I see that having the paper branch's history being unrelated to the main development branch's history is undesirable for JOSS. I merged both histories so that the paper and the code now share a history.

@editorialbot set paper_full as branch (EDIT: I apparently can't change branches and thus force pushed over the paper branch)

The paper has a "statement of need" section and Reimar not having an affiliation was intentional. Reimar left academia and his contribution to this work are not related to his employer. I added a placeholder affiliation for now to make the bot happy :) I will discuss further with Reimar what we want to put there.

@Edenhofer
Copy link

Edenhofer commented Feb 19, 2024

I talked with Reimar and he prefers to have no affiliation. I thus added a new affiliation with "No Affiliation" as title. I hope this is acceptable.

P.S. I also fixed the DOI warning while at it.

@dfm
Copy link

dfm commented Feb 20, 2024

Thanks! Our preferred notation for that is "Independent researcher", but otherwise all good.

@dfm
Copy link

dfm commented Feb 20, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

infotheory: A C++/Python package for multivariate information theoretic analysis
Submitting author: @madvn
Handling editor: @poulson (Retired)
Reviewers: @ajgates42, @artemyk
Similarity score: 0.8204

hIPPYlib: An Extensible Software Framework for Large-Scale Inverse Problems
Submitting author: @uvilla
Handling editor: @lheagy (Retired)
Reviewers: @IgorBaratta, @boehmc
Similarity score: 0.8200

FNFT: A Software Library for Computing Nonlinear Fourier Transforms
Submitting author: @wahls
Handling editor: @kyleniemeyer (Active)
Reviewers: @hafermann
Similarity score: 0.8131

fgivenx: A Python package for functional posterior plotting
Submitting author: @williamjameshandley
Handling editor: @arfon (Active)
Reviewers: @FaustinCarter, @zhampel
Similarity score: 0.8109

GPJax: A Gaussian Process Framework in JAX
Submitting author: @thomaspinder
Handling editor: @dfm (Active)
Reviewers: @gpleiss, @theorashid
Similarity score: 0.8108

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Edenhofer
Copy link

Edenhofer commented Feb 20, 2024

[...] if you have any suggestions for potential reviewers then please mention them here in this thread [...]

I think the following JOSS reviewers might be suitable for this submission

  • williamjameshandley
  • zhampel
  • dgerosa
  • Abinashbunty
  • thomaspinder
  • tbmiller-astro
  • apizzuto
  • prashjet (no collaboration but currently visiting the University of Vienna, prashjet's employer)

@Edenhofer
Copy link

I hate to bug you, but is there a rough ETA when this submission might be considered for review?

@dfm
Copy link

dfm commented Mar 16, 2024

@Edenhofer — Thanks for checking in. Unfortunately there are quite a few submissions in the queue before this one (there was a big burst of submissions a month ago) and all the editors in this track are working at capacity. I expect it will still be a couple more weeks. Thanks for your patience!

@Abinashbunty
Copy link

@dfm I've been following the paper for a while and it's interesting for me to dive deeper and review it. 👍🏻

@dfm
Copy link

dfm commented Mar 22, 2024

@Abinashbunty — Thanks for volunteering! Once an editor is assigned, they will follow up.

@dfm dfm removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 8, 2024
@dfm
Copy link

dfm commented Apr 8, 2024

@editorialbot assign me as editor

Hi all — I'm now available to edit this submission. Thanks for your patience! I'll work on recruiting reviewers now, and once we have two, the main review will get started in a new thread.

@editorialbot
Copy link
Collaborator Author

Assigned! @dfm is now the editor

@dfm
Copy link

dfm commented Apr 8, 2024

@editorialbot add @Abinashbunty as reviewer

@Abinashbunty — if your offer to review still stands, I've added you as a reviewer. If you don't have the capacity anymore, I'm happy to remove you. Either way, let me know and many thanks!!

@editorialbot
Copy link
Collaborator Author

@Abinashbunty added to the reviewers list!

@dfm
Copy link

dfm commented Apr 8, 2024

👋 @williamjameshandley, @thomaspinder, @apizzuto — Would any of you be available and willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@Abinashbunty
Copy link

@dfm I'm still available for the review. So it's fine. 👍🏻

I'll get started with the review already but will post my feedback in the new issue once that is initiated. 😄

@apizzuto
Copy link

apizzuto commented Apr 8, 2024

I am also happy to review this submission!

@dfm
Copy link

dfm commented Apr 9, 2024

@editorialbot add @apizzuto as reviewer

Thanks @apizzuto!!

I'll get the main review started in a new thread, and I'll have a lot more information for everyone over there. Thanks all!

@editorialbot
Copy link
Collaborator Author

@apizzuto added to the reviewers list!

@dfm
Copy link

dfm commented Apr 9, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

5 participants