-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: ATHENA: A Fortran package for neural networks #6364
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Five most similar historical JOSS papers: The nnlib2 library and nnlib2Rcpp R package for implementing neural networks nnde: A Python package for solving differential equations using neural networks h5fortran: object-oriented polymorphic Fortran interface for HDF5 file IO NeuroDiffEq: A Python package for solving differential equations with neural networks textnets: A Python package for text analysis with networks |
@nedtaylor – I note that this submission appears to be on an institutionally-hosted GitLab instance. Can you confirm that this environment meets this condition around account creation to provide feedback? https://joss.readthedocs.io/en/latest/review_criteria.html#where-can-i-host-the-repository |
Hi Arfon, Thank you for bringing this to my attention. Unfortunately, you are correct that my institutionally-hosted GitLab instance does not allow user creation or setting up issues without first logging in (I thought that it had and believed I had achieved this successfully earlier, but was clearly mistaken). Am I allowed to make a fork of my code on the general GitHub and then use that here instead? Will there be an issue with that? I assume that may require making a whole new submission, but as long as that's allowed, I will go ahead and do that. |
I'm sorry @nedtaylor, I'm afraid I can't do that. That's something only editors are allowed to do. |
Hi @arfon, I have moved my repository to GitHub. The new repository link is: https://github.com/nedtaylor/athena I have also updated the version number to: 1.2.2 The branch name has not changed though, that is still: paper Are these changes ones that you are allowed to implement? Hopefully the changes now allow the community to engage and provide feedback. |
@arfon I think I can handle this one |
Amazing, thanks @HaoZeke ! |
@editorialbot assign @HaoZeke as editor |
Assigned! @HaoZeke is now the editor |
@editorialbot set https://github.com/nedtaylor/athena as repository |
Done! repository is now https://github.com/nedtaylor/athena |
@nedtaylor thanks for the submission, do you have any suggested reviewers? |
hi @milancurcic @scivision @rouson 👋 would you be interested in and available to review this JOSS submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html If not, could you recommend any potential reviewers? I was hoping to have your insights because of your work on https://github.com/modern-fortran/neural-fortran |
I could begin a review after March 25 if that works. |
Hi @HaoZeke. I would definitely recommend authors of neural-fortran. I'm happy to wait until the 25th of March for Milan Curcic. If other reviewers are needed, from the JOSS reviewers list, it appears that José Luiz Rybarczyk Filho, Rocco Meli, and Pankaj K Mishra look like good fits. Additionally, am I allowed to update the version and branch? |
@editorialbot add @milancurcic as reviewer Thanks for the quick and affirmative response 🥳 @nedtaylor please feel free to update the version and branch as many times as necessary, only once all the reviews are in we will ask for a final archival version and zenodo tag. |
@milancurcic added to the reviewers list! |
hi @jrybarczyk @RMeli @pankajkmishra 👋 would you be interested in and available to review this JOSS submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html If not, could you recommend any potential reviewers? |
Hi @HaoZeke, I just started editing for JOSS and I'd rather edit than review at this time. However, if you struggle to find other reviewers quickly I'd be happy to review this. Maybe @awvwgk might be interested in reviewing this submission? (Or knows someone in the Fortran community that might be interested?) |
Happy to review this submission. |
@HaoZeke , I can to review this submission. |
@editorialbot add @awvwgk as reviewer Thanks for the prompt (and positive) response |
@awvwgk added to the reviewers list! |
@editorialbot add @jrybarczyk as reviewer Thanks for the affirmative response, will go ahead and open the review thread now :) |
@jrybarczyk added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #6492. |
Submitting author: @nedtaylor (Ned Thaddeus Taylor)
Repository: https://github.com/nedtaylor/athena
Branch with paper.md (empty if default branch): paper
Version: v1.2.1
Editor: @HaoZeke
Reviewers: @milancurcic, @awvwgk, @jrybarczyk
Managing EiC: Arfon Smith
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @nedtaylor. Currently, there isn't a JOSS editor assigned to your paper.
@nedtaylor if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: