Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: QSOnic: fast quasar continuum fitting #6254

Closed
editorialbot opened this issue Jan 20, 2024 · 26 comments
Closed

[PRE REVIEW]: QSOnic: fast quasar continuum fitting #6254

editorialbot opened this issue Jan 20, 2024 · 26 comments
Assignees
Labels
pre-review Python Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 20, 2024

Submitting author: @p-slash (Naim Göksel Karaçaylı)
Repository: https://github.com/p-slash/qsonic
Branch with paper.md (empty if default branch): paper
Version: v0.8.2
Editor: @ivastar
Reviewers: @gcalderone, @corentinravoux
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822"><img src="https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822/status.svg)](https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822)

Author instructions

Thanks for submitting your paper to JOSS @p-slash. Currently, there isn't a JOSS editor assigned to your paper.

@p-slash if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jan 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (767.5 files/s, 119307.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          24           1312           1941           3503
reStructuredText                18            259            409            177
TeX                              1              8              0            105
YAML                             4             15             12             90
Markdown                         1              9              0             30
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            51           1615           2370           3943
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 506

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/abb085 is OK
- 10.1103/PhysRevD.96.023522 is OK
- 10.1088/1475-7516/2015/02/045 is OK
- 10.1093/mnras/stab3201 is OK
- 10.1093/mnras/stae171 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@dfm
Copy link

dfm commented Jan 20, 2024

@p-slash — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 20, 2024
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PACMAN: A pipeline to reduce and analyze Hubble Wide Field Camera 3 IR Grism data
Submitting author: @sebastian-zieba
Handling editor: @xuanxu (Active)
Reviewers: @astrobel, @aureliocarnero
Similarity score: 0.8247

PyCS3: A Python toolbox for time-delay measurements in lensed quasars
Submitting author: @martin-millon
Handling editor: @arfon (Active)
Reviewers: @danhey, @coljac
Similarity score: 0.8228

The Dusty Evolved Star Kit (DESK): A Python package for fitting the Spectral Energy Distribution of Evolved Stars
Submitting author: @s-goldman
Handling editor: @arfon (Active)
Reviewers: @Deech08, @TomGoffrey
Similarity score: 0.8221

GoFish: Fishing for Line Observations in Protoplanetary Disks
Submitting author: @richteague
Handling editor: @arfon (Active)
Reviewers: @zhampel, @nespinoza
Similarity score: 0.8189

The Python Sky Model 3 software
Submitting author: @zonca
Handling editor: @christinahedges (Retired)
Reviewers: @patricialarsen, @smsharma
Similarity score: 0.8155

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ivastar ivastar removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 25, 2024
@ivastar
Copy link

ivastar commented Jan 25, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @ivastar, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@ivastar
Copy link

ivastar commented Jan 25, 2024

@editorialbot assign @ivastar as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @ivastar is now the editor

@ivastar
Copy link

ivastar commented Jan 25, 2024

Hi @p-slash! I will be your editor on this submission. I will be looking for reviewers over the next week or so. Please let me know if you have recommendations for reviewers (maybe some of the developers in DESI?) here or via e-mail. I would appreciate the assistance.

@p-slash
Copy link

p-slash commented Jan 29, 2024

Hi @ivastar ,

Here are my recommendations:

César Ramírez-Pérez - [email protected]
Corentin Ravoux - [email protected]

They have not used qsonic, but they are familiar with the algorithm and its application to Lyman-alpha forest analysis through another package called picca.

@p-slash
Copy link

p-slash commented Feb 13, 2024

@ivastar any updates?

@p-slash
Copy link

p-slash commented Feb 15, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PACMAN: A pipeline to reduce and analyze Hubble Wide Field Camera 3 IR Grism data
Submitting author: @sebastian-zieba
Handling editor: @xuanxu (Active)
Reviewers: @astrobel, @aureliocarnero
Similarity score: 0.8208

PyCS3: A Python toolbox for time-delay measurements in lensed quasars
Submitting author: @martin-millon
Handling editor: @arfon (Active)
Reviewers: @danhey, @coljac
Similarity score: 0.8185

GoFish: Fishing for Line Observations in Protoplanetary Disks
Submitting author: @richteague
Handling editor: @arfon (Active)
Reviewers: @zhampel, @nespinoza
Similarity score: 0.8176

The Dusty Evolved Star Kit (DESK): A Python package for fitting the Spectral Energy Distribution of Evolved Stars
Submitting author: @s-goldman
Handling editor: @arfon (Active)
Reviewers: @Deech08, @TomGoffrey
Similarity score: 0.8157

MCALF: Multi-Component Atmospheric Line Fitting
Submitting author: @ConorMacBride
Handling editor: @mbobra (Active)
Reviewers: @mgalloy, @Goobley
Similarity score: 0.8119

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ivastar
Copy link

ivastar commented Feb 19, 2024

@p-slash still looking for reviewers.

@ivastar
Copy link

ivastar commented Feb 19, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @ivastar, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@ivastar
Copy link

ivastar commented Feb 19, 2024

@editorialbot add @gcalderone as reviewer

@editorialbot
Copy link
Collaborator Author

@gcalderone added to the reviewers list!

@ivastar
Copy link

ivastar commented Feb 19, 2024

@editorialbot add @corentinravoux as reviewer

@editorialbot
Copy link
Collaborator Author

@corentinravoux added to the reviewers list!

@ivastar
Copy link

ivastar commented Feb 19, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

4 participants