Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ThermoParser: Streamlined Analysis of the Thermoelectric Properties #6218

Closed
editorialbot opened this issue Jan 12, 2024 · 34 comments
Assignees
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 12, 2024

Submitting author: @kbspooner (Kieran B. Spooner)
Repository: https://github.com/SMTG-Bham/ThermoParser
Branch with paper.md (empty if default branch): joss-paper
Version: 3.0.0
Editor: @mbarzegary
Reviewers: @enricgrau
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d39912754717d38988d16e0e001c4641"><img src="https://joss.theoj.org/papers/d39912754717d38988d16e0e001c4641/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d39912754717d38988d16e0e001c4641/status.svg)](https://joss.theoj.org/papers/d39912754717d38988d16e0e001c4641)

Author instructions

Thanks for submitting your paper to JOSS @kbspooner. Currently, there isn't a JOSS editor assigned to your paper.

@kbspooner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Jan 12, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.90 s (273.4 files/s, 240213.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            10           2758             64          86098
JSON                             2              0              0          45796
HTML                            78           3655            231          26107
JavaScript                      18           4504           4502          16705
Python                          64           2762           3765           9291
SVG                              2              0              0           5342
CSS                              8            475             73           1785
reStructuredText                56            597            644           1306
TeX                              1             28              1            276
Markdown                         3             37              0            126
Bourne Shell                     3              7              0             31
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           247          14835           9288         192898
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1337

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1103/PhysRevB.84.180301 is OK
- 10.1103/PhysRevB.88.144301 is OK
- 10.1103/PhysRevB.87.104111 is OK
- 10.1103/PhysRevB.91.094306 is OK
- 10.1016/j.scriptamat.2015.07.021 is OK
- 10.1016/j.cpc.2014.02.015 is OK
- 10.1039/d0ta00690d is OK
- 10.1039/d0ta02247k is OK
- 10.1109/mcse.2007.55 is OK
- 10.1016/j.commatsci.2012.10.028 is OK
- 10.1016/j.cpc.2006.03.007 is OK
- 10.21105/joss.00717 is OK
- 10.1088/0953-8984/26/22/225402 is OK
- 10.1038/s41467-021-22440-5 is OK

MISSING DOIs

- 10.1016/j.commatsci.2021.111152 may be a valid DOI for title: TOSSPB: Thermoelectric Optimization Based on Scattering-Dependent Single-Parabolic Band Model
- 10.1016/j.cpc.2010.08.027 may be a valid DOI for title: EPW: A Program for Calculating the Electron–Phonon Coupling Using Maximally Localized Wannier Functions
- 10.1016/j.cpc.2018.05.010 may be a valid DOI for title: BoltzTraP2, a Program for Interpolating Band Structures and Calculating Semi-Classical Transport Coefficients
- 10.1016/j.cpc.2021.107970 may be a valid DOI for title: Perturbo: A Software Package for ab Initio Electron–Phonon Interactions, Charge Transport and Ultrafast Dynamics
- 10.1038/s41524-020-0316-7 may be a valid DOI for title: EPIC STAR: a Reliable and Efficient Approach for Phonon-and Impurity-Limited Charge Transport Calculations
- 10.1016/j.cpc.2023.108670 may be a valid DOI for title: ElecTra Code: Full-Band Electronic Transport Properties of Materials
- 10.1002/adts.201800184 may be a valid DOI for title: The Hiphive Package for the Extraction of High-Order Force Constants by Machine Learning

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

spectrapepper: A Python toolbox for advanced analysis of spectroscopic data for materials and devices.
Submitting author: @enricgrau
Handling editor: @rkurchin (Active)
Reviewers: @stuartcampbell, @ksunden
Similarity score: 0.8411

OpenPelt: Python Framework for Thermoelectric Temperature Control System Development
Submitting author: @gdetor
Handling editor: @rkurchin (Active)
Reviewers: @tpurcell90, @danaraujocr
Similarity score: 0.8382

PYroMat: A Python package for thermodynamic properties
Submitting author: @jranalli
Handling editor: @jgostick (Active)
Reviewers: @espottesmith, @fwitte
Similarity score: 0.8363

ThermoFun: A C++/Python library for computing standard thermodynamic properties of substances and reactions across wide ranges of temperatures and pressures
Submitting author: @gdmiron
Handling editor: @lucydot (Active)
Reviewers: @hgandhi2411, @fnattino
Similarity score: 0.8282

impedance.py: A Python package for electrochemical impedance analysis
Submitting author: @mdmurbach
Handling editor: @mbobra (Active)
Reviewers: @ma-sadeghi, @EricaEgg
Similarity score: 0.8250

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kbspooner
Copy link

Our suggested reviewers are lucydot and mkhorton

@Kevin-Mattheus-Moerman
Copy link
Member

Note to other editors, this is an expanded/improved re-submission of: #3012

@Kevin-Mattheus-Moerman
Copy link
Member

@mbarzegary is this something you think you could help edit?

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @mbarzegary as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @mbarzegary is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

@kbspooner has agreed to edit this work. However he'll likely start towards the end of this month as he has several other papers to attend to as well.

@mbarzegary
Copy link

Hi @mkhorton @dyllamt 👋
Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06218/joss.06218/10.21105.joss.06218.pdf
Software: https://github.com/SMTG-Bham/ThermoParser

@mkhorton
Copy link

This looks like an excellent tool, I’d definitely have thoughts! Compliments to @kbspooner and team.

Unfortunately I have to decline the review due to time constraints. I was quite delayed with the last JOSS submission I reviewed and I’d prefer to defer to other people who would be able to review more promptly out of consideration to the authors.

@mbarzegary
Copy link

No problem @mkhorton. Thank you for informing me.

@mbarzegary
Copy link

Hi @enricgrau, @jranalli, @gdmiron 👋
Considering that you have already published your software in JOSS, would any of you be willing to review this submission? As you know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06218/joss.06218/10.21105.joss.06218.pdf
Software: https://github.com/SMTG-Bham/ThermoParser

@jranalli
Copy link

jranalli commented Feb 1, 2024

I'd be happy to do a review for JOSS at some point, but I'm sorry to say that this particular topic is well outside my area of expertise. I don't have any experience related to material science or with the types of data that this is designed to handle that would allow me to provide any real insight into this software. So, I don't think I'd be comfortable trying to review it. Sorry!

@enricgrau
Copy link

@mbarzegary I'm willing to review, however it is not exactly my area of expertise. If you think this is ok I'll be happy to participate 😉

@mbarzegary
Copy link

No problem @jranalli. Thank you for informing me.

@mbarzegary
Copy link

@enricgrau since the tool is focused on the visualization and data analysis (rather than the core computation) and you have experience in open source development of such tools in materials science, I believe than you can contribute to the review of this submission (and improving it if needed). Please let me know if you have time to do it.

@mbarzegary
Copy link

Hi @ksunden, @espottesmith, @hgandhi2411, @fnattino 👋
Considering that you have already reviewed for JOSS, would any of you be willing to review this submission? As you know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06218/joss.06218/10.21105.joss.06218.pdf
Software: https://github.com/SMTG-Bham/ThermoParser

@enricgrau
Copy link

@mbarzegary Yes I can start reviewing within the next four weeks. 😄

@fnattino
Copy link

fnattino commented Feb 6, 2024

I would also be happy to review @mbarzegary

@espottesmith
Copy link

Seems like this is covered, but if you need another reviewer, I'm happy to help.

@hgandhi2411
Copy link

Hi @mbarzegary! Happy to review this submission, if you need more reviewers. Thanks!

@mbarzegary
Copy link

Thank you @fnattino @espottesmith @hgandhi2411
@hgandhi2411 since we already have 3 reviewers for this submission, I will tag you later in other relevant JOSS reviews.

@mbarzegary
Copy link

@editorialbot add @enricgrau as reviewer

@mbarzegary
Copy link

@editorialbot add @fnattino as reviewer

@mbarzegary
Copy link

@editorialbot add @espottesmith as reviewer

@editorialbot
Copy link
Collaborator Author

@espottesmith added to the reviewers list!

@editorialbot
Copy link
Collaborator Author

@fnattino added to the reviewers list!

@editorialbot
Copy link
Collaborator Author

@enricgrau added to the reviewers list!

@mbarzegary
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

10 participants