Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Φ-ML: A Science-oriented Math and Neural Network Library for Jax, PyTorch, TensorFlow & NumPy #5823

Closed
editorialbot opened this issue Sep 10, 2023 · 42 comments
Assignees
Labels
C++ pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 10, 2023

Submitting author: @holl- (Philipp Holl)
Repository: https://github.com/tum-pbs/PhiML
Branch with paper.md (empty if default branch): joss-submission
Version: v1.0.0
Editor: @mstimberg
Reviewers: @wandeln, @chaoming0625
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0d2c475d01add330399e6d6bdb7a78d4"><img src="https://joss.theoj.org/papers/0d2c475d01add330399e6d6bdb7a78d4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0d2c475d01add330399e6d6bdb7a78d4/status.svg)](https://joss.theoj.org/papers/0d2c475d01add330399e6d6bdb7a78d4)

Author instructions

Thanks for submitting your paper to JOSS @holl-. Currently, there isn't a JOSS editor assigned to your paper.

@holl- if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 10, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (264.9 files/s, 52102.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1             37              0            245
Markdown                         1             67              0            218
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             3            105              4            481
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 3236

@editorialbot
Copy link
Collaborator Author

Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.25080/Majora-92bf1922-00a is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- 10.3390/atmos13020180 may be a valid DOI for title: Machine learning in weather prediction and climate analyses—applications and perspectives
- 10.52843/cassyni.g58sr4 may be a valid DOI for title: Machine learning for fluid mechanics
- 10.3847/1538-4357/abb9a7 may be a valid DOI for title: Full-sky cosmic microwave background foreground cleaning using machine learning
- 10.1111/j.1365-2966.2004.07442.x may be a valid DOI for title: Machine learning and image analysis for morphological galaxy classification
- 10.1088/0004-637x/803/2/50 may be a valid DOI for title: A machine learning approach for dynamical mass measurements of galaxy clusters
- 10.1016/j.oregeorev.2015.01.001 may be a valid DOI for title: Machine learning predictive models for mineral prospectivity: An evaluation of neural networks, random forest, regression trees and support vector machines
- 10.1016/j.jcp.2018.10.045 may be a valid DOI for title: Physics-informed neural networks: A deep learning framework for solving forward and inverse problems involving nonlinear partial differential equations
- 10.1007/978-1-4302-2758-8_14 may be a valid DOI for title: The zen of python

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Sep 10, 2023

@holl- – thanks for your submission to JOSS. Could you please merge main into your submission branch (joss-submission) so we can get a better understand of the size of the codebase using @editorialbot?

@holl-
Copy link

holl- commented Sep 11, 2023

@arfon I rebased the joss-submission branch onto main. Had to force push to make it work, hope that's not a problem.

@holl-
Copy link

holl- commented Sep 11, 2023

I also added the DOIs marked as MISSING above.

@gkthiruvathukal
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @gkthiruvathukal, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Reject paper
@editorialbot reject

# Withdraw paper
@editorialbot withdraw

# Invite an editor to edit a submission (sending them an email)
@editorialbot invite @(.*) as editor

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Accept and publish the paper
@editorialbot accept

# Update data on an accepted/published paper
@editorialbot reaccept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@gkthiruvathukal
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.29 s (349.5 files/s, 148005.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          62           4580           5861          18800
Jupyter Notebook                15              0           2534           6361
C++                             10            345            312           1891
Markdown                         8            246              0            595
C/C++ Header                     1             65             22            346
TeX                              1             37              0            253
YAML                             3             17              4             81
-------------------------------------------------------------------------------
SUM:                           100           5290           8733          28327
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 3236

@editorialbot
Copy link
Collaborator Author

Failed to discover a valid open source license

@gkthiruvathukal
Copy link

@arfon Which command generates the cloc report? (the one that is triggered automatically on submissions)

@holl-
Copy link

holl- commented Sep 22, 2023

@gkthiruvathukal Seems to me that the new report covers the repository.

Also, I have added the MIT license to the top-level directory now so the above message Failed to discover a valid open source license should hopefully be fixed.

@arfon
Copy link
Member

arfon commented Sep 28, 2023

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.34 s (292.5 files/s, 123868.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          62           4580           5861          18800
Jupyter Notebook                15              0           2534           6361
C++                             10            345            312           1891
Markdown                         8            246              0            595
C/C++ Header                     1             65             22            346
TeX                              1             37              0            253
YAML                             3             17              4             81
-------------------------------------------------------------------------------
SUM:                           100           5290           8733          28327
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 3236

@arfon
Copy link
Member

arfon commented Sep 28, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Flux: Elegant machine learning with Julia
Submitting author: @MikeInnes
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @ysimillides
Similarity score: 0.8305

MLJ: A Julia package for composable machine learning
Submitting author: @ablaom
Handling editor: @terrytangyuan (Retired)
Reviewers: @degleris1, @henrykironde
Similarity score: 0.8233

mlpack 3: a fast, flexible machine learning library
Submitting author: @rcurtin
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @rasbt, @MikeInnes, @mlgill
Similarity score: 0.8211

NiaAML: AutoML framework based on stochastic population-based nature-inspired algorithms
Submitting author: @lukapecnik
Handling editor: @arfon (Active)
Reviewers: @adi3, @sara-02
Similarity score: 0.8201

PyTeNet: A concise Python implementation of quantum tensor network algorithms
Submitting author: @cmendl
Handling editor: @jedbrown (Active)
Reviewers: @mlxd, @jcmgray
Similarity score: 0.8198

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Sep 28, 2023

@Holl - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

Also, please look at substantially reducing the length of your paper. As a guideline, JOSS papers should be typically around 1000 words. Thank you!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 28, 2023
@holl-
Copy link

holl- commented Sep 30, 2023

@arfon Okay, I reduced the paper length.

@mstimberg
Copy link

@arfon I'd be available to edit this submission, if needed 👋

@arfon
Copy link
Member

arfon commented Nov 11, 2023

Amazing. Thank you @mstimberg!

@arfon
Copy link
Member

arfon commented Nov 11, 2023

@editorialbot assign @mstimberg as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @mstimberg is now the editor

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 11, 2023
@mstimberg
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mstimberg
Copy link

👋 Hi @holl-, I will be supervising the review of your paper. I've started contacting potential reviewers over mail, but if you have any suggestions, could you please mention them here in this thread (without tagging them with @)?

@holl-
Copy link

holl- commented Nov 18, 2023

Hi @mstimberg , thanks for supervising!

@the-rccg was somewhat involved in the early development of PhiFlow, which originally contained the Φ-MLcode. This was years ago, though, so if that doesn't disqualify him, he'd be well-suited to the task.

As for external reviewers, there are various authors which have used PhiFlow, such as

  • Oskars Teikmanis
  • Nils Wandel
  • Gaurav Bokil

I'd have to look up their GitHub handles.

@mstimberg
Copy link

Thank you very much for these suggestions, I will take a look and contact them (and others) 👍

@mstimberg
Copy link

@holl- Just to give you an update, unfortunately I still haven't found reviewers so far. I'll be contacting more potential reviewers this week and I will also recontact those that haven't replied. Thanks for your patience 🙏

@holl-
Copy link

holl- commented Dec 5, 2023

@mstimberg Thanks for the update!

@mstimberg
Copy link

@editorialbot add @wandeln as reviewer

Thanks again for agreeing to review!

@editorialbot
Copy link
Collaborator Author

@wandeln added to the reviewers list!

@mstimberg
Copy link

@editorialbot add @chaoming0625 as reviewer

Thanks again for agreeing to review!

@editorialbot
Copy link
Collaborator Author

@chaoming0625 added to the reviewers list!

@mstimberg
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

5 participants