Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: TDLM: An R package for a systematic comparison of trip distribution laws and models #5426

Closed
editorialbot opened this issue Apr 29, 2023 · 26 comments
Assignees
Labels
pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 29, 2023

Submitting author: @maximelenormand (Maxime Lenormand)
Repository: https://github.com/EpiVec/TDLM
Branch with paper.md (empty if default branch): joss
Version: v0.1.0
Editor: @crvernon
Reviewers: @kanishkan91, @MAnalytics
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a117e7eaed38f373fda366bf900f4f02"><img src="https://joss.theoj.org/papers/a117e7eaed38f373fda366bf900f4f02/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a117e7eaed38f373fda366bf900f4f02/status.svg)](https://joss.theoj.org/papers/a117e7eaed38f373fda366bf900f4f02)

Author instructions

Thanks for submitting your paper to JOSS @maximelenormand. Currently, there isn't a JOSS editor assigned to your paper.

@maximelenormand if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Apr 29, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (493.7 files/s, 23366.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1              6              0             56
Markdown                         1              7              0             50
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             3             14              4            124
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 357

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1038/nature10856 may be a valid DOI for title: A universal model for mobility and migration patterns
- 10.1038/srep05662 may be a valid DOI for title: Limits of Predictability in Commuting Flows in the Absence of Data for Calibration
- 10.1371/journal.pone.0045985 may be a valid DOI for title: A Universal Model of Commuting Networks
- 10.1103/physreve.88.022812 may be a valid DOI for title: Gravity versus radiation models: On the importance of scale and heterogeneity in commuting flows

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Failed to discover a valid open source license

@arfon
Copy link
Member

arfon commented Apr 29, 2023

cloc output for default (master) branch:

cloc TDLM/
      41 text files.
      22 unique files.                              
      36 files ignored.

github.com/AlDanial/cloc v 1.96  T=0.02 s (941.5 files/s, 239065.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               12            183            972           2455
Java                             3            132            153            889
Rmd                              1            100            296            126
TeX                              1             12              0            112
YAML                             3             20              4             88
Markdown                         2             17              2             25
-------------------------------------------------------------------------------
SUM:                            22            464           1427           3695
-------------------------------------------------------------------------------

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented May 1, 2023

@editorialbot invite @crvernon as editor

👋 @crvernon – would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

crvernon commented May 1, 2023

@arfon - happy to do so!

@crvernon
Copy link

crvernon commented May 1, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@crvernon
Copy link

crvernon commented May 1, 2023

👋 @maximelenormand - I'll be your editor on this submission and we will get things started right away. First, let's find you at least two reviewers...

@crvernon
Copy link

crvernon commented May 1, 2023

👋 @gsapijaszko - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@crvernon
Copy link

crvernon commented May 1, 2023

👋 @MAnalytics - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@crvernon
Copy link

crvernon commented May 3, 2023

👋 @kanishkan91 want to take a crack at reviewing this one?

@kanishkan91
Copy link

@crvernon I can take this. Though will take me two weeks to complete. If that sounds fine, go ahead and add me!

@crvernon
Copy link

crvernon commented May 3, 2023

@editorialbot add @kanishkan91 as reviewer

@editorialbot
Copy link
Collaborator Author

@kanishkan91 added to the reviewers list!

@MAnalytics
Copy link

@crvernon I will be happy to review the submission. Cheers.

@crvernon
Copy link

crvernon commented May 3, 2023

Great @MAnalytics ! Thanks!

@crvernon
Copy link

crvernon commented May 3, 2023

@editorialbot add @MAnalytics as reviewer

@editorialbot
Copy link
Collaborator Author

@MAnalytics added to the reviewers list!

@crvernon
Copy link

crvernon commented May 3, 2023

👋 - Alright @maximelenormand , @kanishkan91 , and @MAnalytics I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

@crvernon
Copy link

crvernon commented May 3, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

5 participants