Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: xclim: xarray-based climate data analytics #5384

Closed
editorialbot opened this issue Apr 18, 2023 · 15 comments
Closed

[PRE REVIEW]: xclim: xarray-based climate data analytics #5384

editorialbot opened this issue Apr 18, 2023 · 15 comments
Assignees
Labels
Makefile pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 18, 2023

Submitting author: @Zeitsperre (Trevor James Smith)
Repository: https://github.com/Ouranosinc/xclim
Branch with paper.md (empty if default branch): joss_submission
Version: v0.42.0
Editor: @kthyng
Reviewers: @kthyng
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9cbcdf32aad971f794cc50f812a46c5f"><img src="https://joss.theoj.org/papers/9cbcdf32aad971f794cc50f812a46c5f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9cbcdf32aad971f794cc50f812a46c5f/status.svg)](https://joss.theoj.org/papers/9cbcdf32aad971f794cc50f812a46c5f)

Author instructions

Thanks for submitting your paper to JOSS @Zeitsperre. Currently, there isn't a JOSS editor assigned to your paper.

@Zeitsperre if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Apr 18, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.55 s (368.0 files/s, 131076.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         115           8739          13760          30495
YAML                            28             71             40           2826
reStructuredText                20            689            624           1852
TeX                              2            138              0           1851
Jupyter Notebook                19              0           5709           1722
JSON                             3              0              0           1331
SVG                              3              0              0            936
Markdown                         4             68              0            195
TOML                             1             12              3            176
make                             2             30              6             99
INI                              1              6             13             91
CSS                              1             13              3             51
DOS Batch                        1              8              1             27
HTML                             1              0              0              2
-------------------------------------------------------------------------------
SUM:                           201           9774          20159          41654
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1086

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-10-4619-2017 is OK
- 10.5334/jors.148 is OK
- 10.1002/essoar.10510291.1 is OK
- 10.5281/zenodo.7382653 is OK
- 10.5065/D6WW7G29 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kthyng
Copy link

kthyng commented Apr 18, 2023

Hi @Zeitsperre and thanks for your submission! We are happy to publish this after its review with pyOpenSci. However, we wait until after that point. It looks like it is still under review there? If so, I could add the "paused" label to this until it is finished, then pick it back up to go through the final steps. Sound good?

@Zeitsperre
Copy link

Hi @kthyng, thanks for following up!

The package has been accepted by pyOpenSci (pyOpenSci/software-submission#73 (comment), also see: https://www.pyopensci.org/python-packages.html) but we haven't yet created a release (will be v0.43.0) with their "Peer-Reviewed Accepted" tag yet (our next scheduled release is in around two weeks). From my understanding, that is the last thing left for us to do. If you'd like, I can bump this issue once all that is done.

The paper submission is ready for review in a branch and can be found in this PR: Ouranosinc/xclim#250.

@kthyng
Copy link

kthyng commented Apr 19, 2023

@Zeitsperre Ah sorry I just scrolled to the bottom of the pyOpenSci review issue and it looked on-going. Yes we can proceed on this end then. I need to work on other things for today but I'll be back tomorrow or Friday.

@kthyng
Copy link

kthyng commented Apr 27, 2023

@Zeitsperre Sorry for my delay — I had a stomach bug come through my household :(

I'll start the processing of your submission!

@kthyng
Copy link

kthyng commented Apr 27, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kthyng is now the editor

@kthyng
Copy link

kthyng commented Apr 27, 2023

@editorialbot add @kthyng as reviewer

@editorialbot
Copy link
Collaborator Author

@kthyng added to the reviewers list!

@kthyng kthyng added the pyOpenSci Submissions associated with pyOpenSci label Apr 27, 2023
@kthyng
Copy link

kthyng commented Apr 27, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Makefile pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

3 participants