Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ReSurfEMG: A Python library for preprocessing and analysis of respiratory EMG. #5192

Closed
editorialbot opened this issue Feb 27, 2023 · 31 comments
Assignees
Labels
Batchfile Dockerfile pre-review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 27, 2023

Submitting author: @drcandacemakedamoore (Candace Makeda Moore)
Repository: https://github.com/ReSurfEMG/ReSurfEMG
Branch with paper.md (empty if default branch):
Version: v0.0.8
Editor: @AJQuinn
Reviewers: @marcoghislieri, @ixjlyons
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d"><img src="https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d/status.svg)](https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d)

Author instructions

Thanks for submitting your paper to JOSS @drcandacemakedamoore . Currently, there isn't a JOSS editor assigned to your paper.

@drcandacemakedamoore if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Feb 27, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.42 s (189.5 files/s, 493060.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                36              0         193416           7987
Python                          12            673           1121           2557
CSS                              1            192             32            685
Markdown                         7            226              0            521
YAML                             6             36             23            232
TeX                              1              9              0            136
reStructuredText                12             84             64            128
Dockerfile                       1              2              0              4
JSON                             1              1              0              4
Bourne Shell                     1              0              0              3
DOS Batch                        1              0              0              2
SVG                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                            80           1223         194656          12260
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 871

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/10.661154 is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- 10.1007/978-3-642-34546-3_71 may be a valid DOI for title: Towards Improving the Usability of Electromyographic Interfaces

INVALID DOIs

- https://doi.org/10.1016/S0921-884X(96)95190-5 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0013-4694(86)90163-X is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1046/j.1365-2842.1998.00242.x is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@drcandacemakedamoore
Copy link

In terms of editors tuliofalmeida has good expertise from the list, but we will be happy with whatever editors are assigned.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @AJQuinn as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@AJQuinn is this submission something you can help with?

@AJQuinn
Copy link

AJQuinn commented Feb 28, 2023

Hi @Kevin-Mattheus-Moerman - yep, happy to take this one.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @AJQuinn as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @AJQuinn is now the editor

@AJQuinn
Copy link

AJQuinn commented Feb 28, 2023

👋 Hi @drcandacemakedamoore - I'm your topic editor for this submission. First job here is to find and assign some reviewers in this thread before starting the actual review in a new issue.

Please could you let me know if you have any suggestions for reviewers (without tagging them with an @) - you can use the list linked in the first comment or suggest others who may be able to help.

@AJQuinn
Copy link

AJQuinn commented Feb 28, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/10.661154 is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- 10.1007/978-3-642-34546-3_71 may be a valid DOI for title: Towards Improving the Usability of Electromyographic Interfaces

INVALID DOIs

- https://doi.org/10.1016/S0921-884X(96)95190-5 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0013-4694(86)90163-X is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1046/j.1365-2842.1998.00242.x is INVALID because of 'https://doi.org/' prefix

@AJQuinn
Copy link

AJQuinn commented Feb 28, 2023

I was about to ask about the DOIs but looks like you're already on it @drcandacemakedamoore! - resurfemg-org/ReSurfEMG#223

Let me know once you have a fix.

@drcandacemakedamoore
Copy link

@AJQuinn We think we have fixed the invalid DOIs, under the missing DOIs it states that "10.1007/978-3-642-34546-3_71 may be a valid DOI for title: Towards Improving the Usability of Electromyographic Interface", and it is, so I'm unsure what the problem is. Anyways, as mentioned above, in terms of editors we think tuliofalmeida probably has good expertise from the list we see, but we will be happy with whatever editors are assigned.

@AJQuinn
Copy link

AJQuinn commented Mar 6, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0921-884X(96)95190-5 is OK
- 10.1109/10.661154 is OK
- 10.1016/0013-4694(86)90163-X is OK
- 10.1046/j.1365-2842.1998.00242.x is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- 10.1007/978-3-642-34546-3_71 may be a valid DOI for title: Towards Improving the Usability of Electromyographic Interfaces

INVALID DOIs

- None

@AJQuinn
Copy link

AJQuinn commented Mar 6, 2023

@drcandacemakedamoore thanks for the fix. I'll let you know if the remaining DOI query needs further checking.

@AJQuinn
Copy link

AJQuinn commented Mar 6, 2023

👋 @marcoghislieri, @JanCBrammer & @ixjlyons would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@JanCBrammer
Copy link

@AJQuinn, thanks for the consideration, but I currently don't have the bandwidth for a review.

@marcoghislieri
Copy link

Dear @AJQuinn,
Thanks for considering me as a potential reviewer for this submission. I'll be happy to revise this library.
All the best

@ixjlyons
Copy link

ixjlyons commented Mar 7, 2023

I'd be happy to review.

@AJQuinn
Copy link

AJQuinn commented Mar 10, 2023

No problem @JanCBrammer , thanks for letting me know. And thanks to @ixjlyons @marcoghislieri !

@AJQuinn
Copy link

AJQuinn commented Mar 10, 2023

@editorialbot add @marcoghislieri as reviewer

@editorialbot
Copy link
Collaborator Author

@marcoghislieri added to the reviewers list!

@AJQuinn
Copy link

AJQuinn commented Mar 10, 2023

@editorialbot add @ixjlyons as reviewer

@editorialbot
Copy link
Collaborator Author

@ixjlyons added to the reviewers list!

@AJQuinn
Copy link

AJQuinn commented Mar 13, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5251.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Batchfile Dockerfile pre-review Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

7 participants