Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Nanomesh: A Python workflow tool for generating meshes from image data #4510

Closed
editorialbot opened this issue Jun 26, 2022 · 35 comments
Assignees
Labels
Jupyter Notebook pre-review Python Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 26, 2022

Submitting author: @stefsmeets (Stef Smeets)
Repository: https://github.com/hpgem/nanomesh
Branch with paper.md (empty if default branch): joss_paper
Version: 0.9.0
Editor: @prashjha
Reviewers: @jameshgrn, @vijaysm
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0fcbf050ec48e9f1aa2ec5d8f1d8770d"><img src="https://joss.theoj.org/papers/0fcbf050ec48e9f1aa2ec5d8f1d8770d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0fcbf050ec48e9f1aa2ec5d8f1d8770d/status.svg)](https://joss.theoj.org/papers/0fcbf050ec48e9f1aa2ec5d8f1d8770d)

Author instructions

Thanks for submitting your paper to JOSS @stefsmeets. Currently, there isn't an JOSS editor assigned to your paper.

@stefsmeets if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.37 s (398.4 files/s, 282331.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          62           1636           1944           4321
Markdown                        26            988              0           2438
Jupyter Notebook                20              0          90560            948
reStructuredText                24            258            342            225
YAML                             7             30             16            218
TeX                              1             12              0            134
DOS Batch                        2              8              1             28
Bourne Shell                     2              0              0             22
make                             1              5              3             22
TOML                             1              0              0              3
SVG                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                           147           2937          92866           8360
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1244

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/2629697 is OK
- 10.21105/joss.01450 is OK
- 10.5281/zenodo.1173115 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1103/PhysRevLett.94.033903 is OK
- 10.1103/PhysRevB.72.153102 is OK

MISSING DOIs

- 10.1007/bfb0014497 may be a valid DOI for title: Triangle: Engineering a 2D quality mesh generator and Delaunay triangulator

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Jun 26, 2022

@editorialbot invite @prashjha as editor

👋 @prashjha – would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @prashjha as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@prashjha
Copy link

Hi @arfon and @Kevin-Mattheus-Moerman, thanks for the invite.

@prashjha
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @prashjha is now the editor

@prashjha
Copy link

prashjha commented Aug 1, 2022

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/2629697 is OK
- 10.21105/joss.01450 is OK
- 10.5281/zenodo.1173115 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1103/PhysRevLett.94.033903 is OK
- 10.1103/PhysRevB.72.153102 is OK

MISSING DOIs

- 10.1007/bfb0014497 may be a valid DOI for title: Triangle: Engineering a 2D quality mesh generator and Delaunay triangulator

INVALID DOIs

- None

@prashjha
Copy link

prashjha commented Aug 1, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@prashjha
Copy link

prashjha commented Aug 1, 2022

Hi @stefsmeets, could you suggest a couple of reviewers for this submission? Also, please check one of the references in your paper (see the error above).

@prashjha
Copy link

prashjha commented Aug 1, 2022

Hi @KParas, would you be interested in reviewing this submission for JOSS? I believe it is related to your interest. Thank you!!

@prashjha
Copy link

prashjha commented Aug 1, 2022

Hello @jameshgrn, any chance you could review this submission for JOSS?

@jameshgrn
Copy link

@prashjha sure, what all do I need to do? would be a first time for me

@prashjha
Copy link

prashjha commented Aug 2, 2022

@jameshgrn, awesome. Generally speaking, reviewing software articles for JOSS entails testing the software/library and making sure software is well documented and general enough for broad usage. If you think something is not right with the software, for example, a test does not work or part of the code is not well documented, you can open an issue in the software repository and request authors to address these issues.

To make the review easy, you will be assigned a checklist designed to test various aspects of the open source library.

You can check out this JOSS guideline for carrying out reviews. You can also quickly look at one or two past reviews in JOSS to get the idea.

Let me know if you are still up for reviewing this submission and I will add you as a reviewer. Thanks.

@stefsmeets
Copy link

Hi @stefsmeets, could you suggest a couple of reviewers for this submission? Also, please check one of the references in your paper (see the error above).

Hi @prashjha , I'd suggest:

@vijaysm
@daniellivingston
@abhishekta
@krober10nd

@KParas
Copy link

KParas commented Aug 2, 2022

Hi @KParas, would you be interested in reviewing this submission for JOSS? I believe it is related to your interest. Thank you!!

@prashjha Thank you for the invite. The topic seems quite interesting, but unfortunately reviewing this one is not possible due to my current time schedule.

@vijaysm
Copy link

vijaysm commented Aug 2, 2022

@stefsmeets @prashjha I should be available to review this in 2-3 weeks.

@krober10nd
Copy link

Sorry have to turn this one down. Currently very busy. Thanks for the offer!

@jameshgrn
Copy link

@prashjha I can do it, feel free to add me.

@prashjha
Copy link

prashjha commented Aug 4, 2022

@editorialbot add @jameshgrn as reviewer

@editorialbot
Copy link
Collaborator Author

@jameshgrn added to the reviewers list!

@prashjha
Copy link

prashjha commented Aug 4, 2022

Hi, @vijaysm, thanks for the quick response. I am okay with the timeline. I am adding you as a reviewer.

@prashjha
Copy link

prashjha commented Aug 4, 2022

@editorialbot add @vijaysm as reviewer

@editorialbot
Copy link
Collaborator Author

@vijaysm added to the reviewers list!

@prashjha
Copy link

prashjha commented Aug 4, 2022

@krober10nd thank you for a prompt response...no problem. :)

@prashjha
Copy link

prashjha commented Aug 4, 2022

Hi @stefsmeets we got two reviewers...I will start the review soon in a new GitHub issue.

Thanks, @jameshgrn and @vijaysm, for agreeing to review this submission. I really appreciate your time and effort in advance.

@prashjha
Copy link

prashjha commented Aug 5, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4654.

@editorialbot editorialbot added the Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Notebook pre-review Python Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants