Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GHEtool: An open-source tool for borefield sizing in Python #4297

Closed
editorialbot opened this issue Apr 4, 2022 · 49 comments
Closed

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 4, 2022

Submitting author: @wouterpeer (Wouter Peere)
Repository: https://github.com/wouterpeere/GHEtool
Branch with paper.md (empty if default branch): main
Version: v2.0.0
Editor: @crvernon
Reviewers: @jasondegraw, @nmstreethran
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127"><img src="https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127/status.svg)](https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127)

Author instructions

Thanks for submitting your paper to JOSS @wouterpeer. Currently, there isn't an JOSS editor assigned to your paper.

@wouterpeer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Couldn't check the bibtex because branch name is incorrect: JOSS subfolder

1 similar comment
@editorialbot
Copy link
Collaborator Author

Couldn't check the bibtex because branch name is incorrect: JOSS subfolder

@editorialbot
Copy link
Collaborator Author

@wouterpeere
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@wouterpeere
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @wouterpeere, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@wouterpeere
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@wouterpeere
Copy link

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@wouterpeere
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@wouterpeere
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@wouterpeere
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.47 s (53.2 files/s, 50780.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          18            517           1552          21478
Markdown                         4             63              0            162
TeX                              1              8              0             57
YAML                             1              1              4             18
TOML                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                            25            589           1556          21721
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1101

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @crvernon as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

crvernon commented Apr 7, 2022

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@crvernon
Copy link

crvernon commented Apr 7, 2022

👋 @wouterpeere - I'll be your topic editor for this submission.

The first step in this pre-review will be to find at least 2 reviewers and get the review started. If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list). Thanks!

@wouterpeere
Copy link

Hi @crvernon ! I think this repository is somewhat related to the interests of jasondegraw and willu47.

@crvernon
Copy link

👋 - @jasondegraw Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@crvernon
Copy link

👋 - @willu47 Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@wouterpeere
Copy link

@crvernon Any more updates?

@jasondegraw
Copy link

@crvernon Yes, I can review this submission.

@crvernon
Copy link

crvernon commented May 2, 2022

@editorialbot assign @jasondegraw as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@crvernon
Copy link

crvernon commented May 2, 2022

@editorialbot add @jasondegraw as reviewer

@editorialbot
Copy link
Collaborator Author

@jasondegraw added to the reviewers list!

@crvernon
Copy link

crvernon commented May 2, 2022

@wouterpeere I'll find you one more reviewer and then we will move this to full review status.

@crvernon
Copy link

crvernon commented May 2, 2022

👋 - @meghanrjones Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@maxrjones
Copy link

Would you be willing to review this submission to JOSS?

Thanks for reaching out. Unfortunately I will not be able to review this submission to JOSS.

@wouterpeere
Copy link

@crvernon raoulcollenteur is perhaps also a potential reviewer.

@crvernon
Copy link

👋 - @raoulcollenteur Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@wouterpeere
Copy link

@crvernon also nmstreethran, mefuller and fwitte can be potential reviewers.

@crvernon
Copy link

👋 - @nmstreethran , @mefuller , or @fwitte Would either of you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@nmstreethran
Copy link

@crvernon Yes, I'd be happy to review this submission.

@crvernon
Copy link

Thanks @nmstreethran !

@crvernon
Copy link

@editorialbot add @nmstreethran as reviewer

@editorialbot
Copy link
Collaborator Author

@nmstreethran added to the reviewers list!

@crvernon
Copy link

👋 - Alright @wouterpeere , @jasondegraw , and @nmstreethran I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

@crvernon
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants