Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SimuPy Flight Vehicle Toolkit #4026

Closed
whedon opened this issue Dec 29, 2021 · 50 comments
Closed

[PRE REVIEW]: SimuPy Flight Vehicle Toolkit #4026

whedon opened this issue Dec 29, 2021 · 50 comments

Comments

@whedon
Copy link

whedon commented Dec 29, 2021

Submitting author: @ixjlyons (Kenneth Lyons)
Repository: https://github.com/nasa/simupy-flight
Branch with paper.md (empty if default branch):
Version: 0.0.1
Editor: @prashjha
Reviewers: @athulpg007, @aliaksei135
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d9c33e4d58c9c4722139138c4d9a67be"><img src="https://joss.theoj.org/papers/d9c33e4d58c9c4722139138c4d9a67be/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d9c33e4d58c9c4722139138c4d9a67be/status.svg)](https://joss.theoj.org/papers/d9c33e4d58c9c4722139138c4d9a67be)

Author instructions

Thanks for submitting your paper to JOSS @ixjlyons. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @dpsanders.

@ixjlyons if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 29, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 29, 2021

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Dec 29, 2021

Wordcount for paper.md is 378

@whedon
Copy link
Author

whedon commented Dec 29, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.16 s (354.2 files/s, 122761.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             15            801            445           8751
HTML                             2            167              0           3404
Python                          34            691            218           3007
Jupyter Notebook                 1              0           1216            443
TeX                              1             18              0            126
reStructuredText                 2             32             18             44
Markdown                         1              4              0             23
-------------------------------------------------------------------------------
SUM:                            56           1713           1897          15798
-------------------------------------------------------------------------------


Statistical information for the repository 'b43de56b30069440b4042c08' was
gathered on 2021/12/29.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Ben Margolis                    45          5091           1591           85.84
Kenneth Lyons                    3           270            343            7.88
ben                              1           489              0            6.28

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Ben Margolis               3160           62.1          6.8                1.80
Kenneth Lyons               267           98.9          1.8                1.50
ben                         489          100.0          1.9                6.34

@whedon
Copy link
Author

whedon commented Dec 29, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Dec 29, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00396 is OK
- 10.2514/6.2002-4482 is OK
- 10.7717/peerj-cs.103 is OK
- 10.2514/6.2019-2901 is OK
- 10.5281/zenodo.3940699 is OK
- 10.21105/joss.01745 is OK

MISSING DOIs

- 10.2514/6.2020-1012 may be a valid DOI for title: Pterodactyl: Development and comparison of control architectures for a mechanically deployed entry vehicle
- 10.1007/s40295-019-00191-2 may be a valid DOI for title: Nonlinear model predictive control of reentry vehicles based on Takagi-Sugeno fuzzy models
- 10.2514/6.2021-0762 may be a valid DOI for title: Pterodactyl: System Analysis of an Asymmetric and Symmetric Deployable Entry Vehicle for Precision Targeting Using Flaps
- 10.2514/6.2021-0764.vid may be a valid DOI for title: Pterodactyl: Guidance and Control of a Symmetric Deployable Entry Vehicle using an Aerodynamic Control System

INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Dec 29, 2021

@ixjlyons – many thanks for your submission to JOSS. While we look for an editor to handle this submission, if you want to fix the DOIs (noting that Whedon's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@whedon generate pdf
@whedon check references

@arfon
Copy link
Member

arfon commented Dec 29, 2021

@ixjlyons – I also see that your software is licensed under the NOSA agreement. Could you please update the PDF license to be a plain text file named LICENSE in your repository (with the NOSA agreement language).

@sixpearls
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 5, 2022

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@sixpearls
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Jan 5, 2022

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00396 is OK
- 10.2514/6.2002-4482 is OK
- 10.7717/peerj-cs.103 is OK
- 10.2514/6.2019-2901 is OK
- 10.2514/6.2020-1012 is OK
- 10.1007/s40295-019-00191-2 is OK
- 10.2514/6.2021-0762 is OK
- 10.5281/zenodo.3940699 is OK
- 10.21105/joss.01745 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.2514/6.2021-0764. is INVALID

@sixpearls
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 5, 2022

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@sixpearls
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Jan 5, 2022

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00396 is OK
- 10.2514/6.2002-4482 is OK
- 10.7717/peerj-cs.103 is OK
- 10.2514/6.2019-2901 is OK
- 10.2514/6.2020-1012 is OK
- 10.1007/s40295-019-00191-2 is OK
- 10.2514/6.2021-0762 is OK
- 10.2514/6.2021-0764 is OK
- 10.5281/zenodo.3940699 is OK
- 10.21105/joss.01745 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kthyng
Copy link

kthyng commented Jan 6, 2022

@prashjha are you interested in editing this submission?

@kthyng
Copy link

kthyng commented Jan 6, 2022

@whedon invite @prashjha as editor

@whedon
Copy link
Author

whedon commented Jan 6, 2022

@prashjha has been invited to edit this submission.

@prashjha
Copy link

@kthyng thank you. I will be glad to be editor of this submission.

@prashjha
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jan 10, 2022

OK, the editor is @prashjha

@prashjha
Copy link

Hi, @ixjlyons, it is a pleasure to handle your submission as the editor. Could you please suggest a couple of potential reviewers from this reviewers list. Let me know if you have trouble finding the names.

@prashjha
Copy link

@ixjlyons, while you and I are looking for potential reviewers, I have a few remarks for the draft of the paper:

As per the example JOSS paper here, you are missing 'Statement of Need'. For a software article, I would also like to see some details about the model and application using your code. You may also need to add the 'Acknowledgments' section if any. I would recommend keeping the article within 3 page limit (excluding references).

@prashjha
Copy link

Hi @ixjlyons, could you please respond to my comments above? Thanks!

@ixjlyons
Copy link

Hi @prashjha, apologies for the delay.

We are working on updates to the paper per your suggestions.

In the meantime, here are some reviewers that look like they might be interested in reviewing this submission:

  • aliaksei135
  • athulpg007
  • cknoll
  • crbinz
  • Juanlu001
  • helgee
  • ngoiz

(I haven't @'d them in case you want to downselect first)

Also, I saw a few others in the list that might be appropriate in case the above don't work out.

@prashjha
Copy link

Hi @aliaksei135, would you be interested in reviewing this submission for JOSS?

@prashjha
Copy link

Howdy @athulpg007, any chance you could review this JOSS submission?

@athulpg007
Copy link

I am happy to review this submission.

@aliaksei135
Copy link

Likewise happy to review.

@ixjlyons
Copy link

@whedon generate pdf

@editorialbot
Copy link
Collaborator

My name is now @editorialbot

@ixjlyons
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ixjlyons
Copy link

@prashjha we've made some updates to the paper including adding a statement of need section.

@ixjlyons
Copy link

ixjlyons commented Apr 2, 2022

@prashjha

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@prashjha
Copy link

prashjha commented Apr 5, 2022

Dear @athulpg007 and @aliaksei135, there was some delay in starting the review. I am hoping you both are still good to review this submission. I will kickstart the review today.

@prashjha
Copy link

prashjha commented Apr 5, 2022

@ixjlyons thanks...looks good in a quick glance.

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot check references

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00396 is OK
- 10.2514/6.2002-4482 is OK
- 10.7717/peerj-cs.103 is OK
- 10.2514/6.2019-2901 is OK
- 10.2514/6.2020-1012 is OK
- 10.1007/s40295-019-00191-2 is OK
- 10.2514/6.2021-0762 is OK
- 10.2514/6.2021-0764 is OK
- 10.5281/zenodo.3940699 is OK
- 10.21105/joss.01745 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator

Can't start a review without reviewers

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot add @athulpg007 as reviewer

@editorialbot
Copy link
Collaborator

@athulpg007 added to the reviewers list!

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot add @aliaksei135 as reviewer

@editorialbot
Copy link
Collaborator

@aliaksei135 added to the reviewers list!

@prashjha
Copy link

prashjha commented Apr 5, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator

OK, I've started the review over in #4299.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants