-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Cacatoo: building, exploring, and sharing spatially structured models of biological systems #3909
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
Hi @bramvandijk88, as we are getting started in this pre-review issue, could you fix those missing DOIs in the references? @Bisaloo could you edit this submission? |
@Bisaloo has been invited to edit this submission. |
Absolutely, I'll get on it. On a seperate note, it's hard to find reviewers for this I can imagine. Not a lot of javascript programmers are in your list. In any case, these usernames seemed somewhat appropriate for my submission: emilydolson |
@whedon assign me as editor |
OK, the editor is @Bisaloo |
👋 👋 @kyleniemeyer @bramvandijk88, yes I can edit this issue. Before we can get properly started, I notice that whedon severely overestimates the number of code lines. Whedon uses GitHub's linguist to detect the relevant files & languages. Could you edit your Should the I couldn't find good documentation on how to use linguist so if this is not clear, please let me know and I'll try to submit a PR myself. |
Thanks for editing.
Yeah, good point. I didn't even notice I had added the node modules, so I'll get on it.
I'll let you know when I've updated it, and let's see. |
@Bisaloo I have i) removed node modules from the repository and added it to .gitignore Let me know if this resolves the line count issues. |
@whedon check repository |
Wordcount for |
|
Thanks for your quick answer! I believe a couple of other changes are necessary:
Please let me know if I misunderstand something or if you disagree. I believe we should be good to go after this 👍. |
Regarding reviewers, we are not limited to the google spreadsheet. The list contains people who agreed to review for JOSS but if you know potential good reviewers who are not in the list, feel free to suggest them as well. |
No, I don't actually want to do that. I'm uploading the compiled library to the repository so that users can immediately dive into the examples without having to install anything. The zero-install is one of the selling points of this package ;D
Yes, thanks, I've added it.
Alright, good. The problem with finding reviewers is that this is a really niche library (javascript is not very common, and the type of models are also quite niche), so I don't know who to suggest except my close colleagues, which is clearly a conflict of interest... |
Okay, fair enough. I had a look at the jsfiddle examples and it looks very nice. I would still recommend you add This submission looks in scope and I'll start looking into reviewers. |
Actually, yes, I'll do that. |
👋 👋 @emilydolson @TimKam, based on the keywords and programming languages in listed when you volunteered to review for JOSS, you would be very good candidates to review this javascript library and associated paper. Would you please be available to review them? |
Yes! I would be happy to! |
Awesome, thanks for your quick answer 💯. Once I find the 2nd reviewer, I'll open the review thread and explain how it works. If you are already curious, all the information is summarized in our documentation at https://joss.readthedocs.io/en/latest/. |
@whedon add @emilydolson as reviewer |
OK, @emilydolson is now a reviewer |
I still need to review another JOSS paper (2nd round), but in roughly a week, I should be available. I had a quick look and I'd look forward to reviewing this project. |
Are you sure you're okay with reviewing two papers back to back? I can look for other reviewers. If you think it's fine, we can easily wait one week. |
Should be okay, as I am done with the other review by now. |
OK, @TimKam is now a reviewer |
@whedon start review |
OK, I've started the review over in #3948. |
Submitting author: @bramvandijk88 (Bram van Dijk)
Repository: https://github.com/bramvandijk88/cacatoo
Version: v1.0.0
Editor: @Bisaloo
Reviewers: @emilydolson, @TimKam
Managing EiC: Kyle Niemeyer
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @bramvandijk88. Currently, there isn't an JOSS editor assigned to your paper.
The author's suggestion for the handling editor is @sbenthall.
@bramvandijk88 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: