Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: iheatmapr: Interactive complex heatmaps in R #359

Closed
18 tasks done
whedon opened this issue Aug 11, 2017 · 11 comments
Closed
18 tasks done

[REVIEW]: iheatmapr: Interactive complex heatmaps in R #359

whedon opened this issue Aug 11, 2017 · 11 comments
Assignees
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci

Comments

@whedon
Copy link

whedon commented Aug 11, 2017

Submitting author: @AliciaSchep (Alicia Schep)
Repository: https://github.com/ropensci/iheatmapr
Version: v0.3.2
Editor: @arfon
Reviewer: @arfon
Archive: 10.5281/zenodo.841331

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/9ebcd154fd6df78155d1655ff677b823"><img src="http://joss.theoj.org/papers/9ebcd154fd6df78155d1655ff677b823/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/9ebcd154fd6df78155d1655ff677b823/status.svg)](http://joss.theoj.org/papers/9ebcd154fd6df78155d1655ff677b823)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

@rlbarter, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.

Conflict of interest

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v0.3.2)?
  • Authorship: Has the submitting author (@AliciaSchep) made major contributions to the software?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: Have any performance claims of the software been confirmed?

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon
Copy link
Author

whedon commented Aug 11, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @rlbarter it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

@karthik
Copy link
Contributor

karthik commented Aug 14, 2017

I notified @rlbarter about the mix up.

The review thread from ropensci is here: ropensci/software-review#107

@arfon Could you please switch yourself to editor and proceed with accepting this submission?

@arfon
Copy link
Member

arfon commented Aug 14, 2017

@arfon Could you please switch yourself to editor and proceed with accepting this submission?

Wilco.

@arfon
Copy link
Member

arfon commented Aug 14, 2017

@whedon assign @arfon as reviewer

@whedon
Copy link
Author

whedon commented Aug 14, 2017

OK, the reviewer is @arfon

@arfon
Copy link
Member

arfon commented Aug 14, 2017

@whedon assign @arfon as editor

@whedon
Copy link
Author

whedon commented Aug 14, 2017

OK, the editor is @arfon

@whedon whedon assigned arfon and unassigned arfon and karthik Aug 14, 2017
@arfon
Copy link
Member

arfon commented Aug 14, 2017

@whedon set 10.5281/zenodo.841331 as archive

@whedon
Copy link
Author

whedon commented Aug 14, 2017

OK. 10.5281/zenodo.841331 is the archive.

@arfon
Copy link
Member

arfon commented Aug 14, 2017

@AliciaSchep - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00359 ⚡️ 🚀 💥

@arfon arfon closed this as completed Aug 14, 2017
@arfon arfon added the accepted label Aug 14, 2017
@AliciaSchep
Copy link

Thanks @arfon and @karthik, and sorry for any confusion about the paper having gone through ropensci before, wasn't sure how this all worked!

@arfon arfon added the rOpenSci Submissions associated with rOpenSci label Feb 6, 2020
@whedon whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci
Projects
None yet
Development

No branches or pull requests

4 participants