-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: TsgFEM: Tensegrity Finite Element Method #3350
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
@Muhao-Chen thanks for this submission to JOSS. We have some questions in relation to this work. This looks like it is a continuation of work you and your co-workers previously submitted to JOSS, namely MOTES (paper, review, software repository). Indeed some functionality (e.g. tenseg_plot.m in MOTES and tenseg_plot.m in TsgFEM) seems fully duplicated. Also the README may have been copied from MOTES as the set-up section for TsgFEM refers to MOTES. Can you clarify how the current new submission, TsgFEM, differs from MOTES? Can you clearly make the case why TsgFEM requires an independent publication on top of, and distinct from MOTES? Can you please also comment on whether it would not be better to integrate TsgFEM+MOTES into a single library and to consider publishing that? Can you clarify the timeline of development for this work? Based on GitHub uploads it looks like development just started, but the user guide appears to refer to development from 2019. |
@Kevin-Mattheus-Moerman Thanks for your questions! Yes, our group push research work on the tensegrity structures. TsgFEM indeed has few functions in common with MOTES. But the major contribution of this work is quite different. All the duplicated and modified functions have been cited in the description of code files, and we also include their license. Sure, TsgFEM and MOTES are both analysis tools for tensegrity structures (a stable network of bars and strings). TsgFEM is developed based on the assumption that bars are not rigid (the bars and strings can be elastic or plastic), so the simulation and results are representing the physics. MOTES assumes that the bars are rigid and strings are elastic, so it has limitations. TsgFEM + MOTES is a good idea. Actually, TsgFEM is much more powerful, and now it is able to do what the MOTES can do and do more since we can set a really high stiffness of bars and view them as rigid ones in TsgFEM. Plus, TsgFEM also provides more functionalities in structure statics and dynamics, i.e., linearized dynamics, modal analysis, etc. Plus, rigid body assumption is very useful in research, but in real engineering constructions, no materials are rigid. Finite Element Method (FEM) analysis is more important, and it is almost a must-study process before putting any structures up. And the FEM information can also provide an insight into the local loadings of structure members. Yeah, the file structure and README of the two GitHub repositories are similar because I am the co-author of MOTES as well, and I wrote those description files. To be consistent and help people in the tensegrity community who is using our software understand better, I use the same file structure and format. Yes, we started this work in 2019, but it's not uploaded on GitHub. Until all the TsgFEM files ready, we submitted them to GitHub on 06/09/2021. That's why you only see two commits shown on GitHub. |
@Muhao-Chen thanks for this explanation. |
@Muhao-Chen can you check if all those references are actually cited in the paper? ☝️ Perhaps clean up the .bib file so it is only the papers from the paper and also add those missing DOIs please. You can call |
@whedon generate pdf |
@whedon generate pdf |
@Kevin-Mattheus-Moerman Thank you so much for your help! I removed all the unused bib files and also added the missing DOIs. The pdf format looks good now. Please let me know if there are any questions. Thank you! |
@whedon check references |
|
@Muhao-Chen - thanks for your submission. |
@danielskatz Sure, take your time! Thank you so much for helping! |
@danielskatz I can take this paper. |
OK, the editor is @diehlpk |
Hi @IgorBaratta @HaoZeke @mikaem @gassmoeller @chennachaos @yangbai90 @thelfer @capitalaslash would you be interested in reviewing this paper? |
I'd be happy to take this, but I just moved and might need some more time than usual. Am also a little backed up with other things. |
No worries if you need a little bit longer. |
OK, @HaoZeke is now a reviewer |
Hi @diehlpk, thank you for the opportunity! |
@chennachaos Can you recommend some reviewers for that paper? |
Hi @diehlpk. After briefly reading of the paper, I don't think I have enough experience in this domain to make a proper review. |
I think @likask, @bhajay, @agshvarts might be interested. |
@diehlpk thanks for handling this. FYI here are two other papers I was involved in which feature tensegrity modelling. Perhaps some of the authors/reviewers for these can help review too:
|
@diehlpk also I would not mind reviewing this as a (n+1)th reviewer |
@Kevin-Mattheus-Moerman I am happy to review. |
@whedon add @Kevin-Mattheus-Moerman as reviewer |
OK, @Kevin-Mattheus-Moerman is now a reviewer |
@whedon start review |
OK, I've started the review over in #3390. |
Thank you for the invitation to review. |
OK, @likask is now a reviewer |
Submitting author: @Muhao-Chen (Muhao Chen)
Repository: https://github.com/Muhao-Chen/Tensegrity_Finite_Element_Method_TsgFEM
Version: v1.1
Editor: @diehlpk
Reviewers: @HaoZeke, @Kevin-Mattheus-Moerman, @likask
Managing EiC: Kevin M. Moerman
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @Muhao-Chen. Currently, there isn't an JOSS editor assigned to your paper.
@Muhao-Chen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: