Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Sequana: a set of flexible genomic pipelines for processing and reporting NGS analysis #334

Closed
whedon opened this issue Jul 26, 2017 · 21 comments
Assignees

Comments

@whedon
Copy link

whedon commented Jul 26, 2017

Submitting author: @cokelaer (Thomas Cokelaer)
Repository: https://github.com/sequana/sequana/
Version: 0.4.1
Editor: @pjotrp
Reviewer: @bow

Author instructions

Thanks for submitting your paper to JOSS @cokelaer. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@cokelaer if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 26, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @pjotrp it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Jul 26, 2017

@pjotrp - the submitting author suggested you as a potential editor.

@pjotrp
Copy link

pjotrp commented Jul 27, 2017

@whedon commands

@whedon
Copy link
Author

whedon commented Jul 27, 2017

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

@pjotrp
Copy link

pjotrp commented Jul 27, 2017

@whedon assign @pjotrp as editor

@whedon
Copy link
Author

whedon commented Jul 27, 2017

OK, the editor is @pjotrp

@pjotrp
Copy link

pjotrp commented Aug 1, 2017

@cokelaer thank you for your submission! I'll be looking for a reviewer soon. In the mean time can you help out with a few things? I can't find the paper.md and paper.bib files. Can you point them to me? Also can you make the LICENSE file standard - if it is it will show up on github with the right license icon. Thanks!

@cokelaer
Copy link

cokelaer commented Aug 2, 2017

@ pjotrp
I've fixed the LICENSE and the icon now appears on github.
As for the paper.md and paper.bib, what do mean exactly ? Where shall I provide those files and what should be the content ? thanks

@pjotrp
Copy link

pjotrp commented Aug 2, 2017

Best is to check one of the existing publication. See https://github.com/genenetwork/genenetwork2/tree/master/doc/joss/2016

@cokelaer
Copy link

cokelaer commented Aug 2, 2017

Do the paper.bib and paper.md must be in the repository of the software or can they be put elsewhere ? Sequana is an organisation and we put the software in sequana/sequana but for papers, we'd like to keep it separate for instance in ./sequana/resources . Would it be fine with your policy ?

@arfon
Copy link
Member

arfon commented Aug 2, 2017

Would it be fine with your policy?

I think this is going to break some of our submission tooling (i.e. it's expected that the paper be in the software repository being reviewed). Let me check and get back to you.

For reference, some authors have made a folder in docs e.g..docs/paper/paper.md - might something like this work for you?

@pjotrp
Copy link

pjotrp commented Aug 3, 2017

As the final paper gets generated from the source tree it is tied to the commit of that release. You can remove the paper from the source tree once it is published. It will be in that particular source release and git history. So it is not intrusive. Makes sense to tie it to the project, right?

@cokelaer
Copy link

cokelaer commented Aug 3, 2017

okay, that's fine, I will add a ./joss directory in the ./doc
thanks

@cokelaer
Copy link

cokelaer commented Aug 3, 2017

FYI we have added a paper.bib paper.md in https://github.com/sequana/sequana/tree/master/doc/joss

@pjotrp
Copy link

pjotrp commented Aug 3, 2017

That looks great. @bow since since this is a snakemake application would you care to review this JOSS submission?

@bow
Copy link

bow commented Aug 4, 2017

@pjotrp & @cokelaer I'd be happy to review the submission. I would need a week's time, if that's ok.

@pjotrp
Copy link

pjotrp commented Aug 4, 2017

No problem. Thanks @bow.

@pjotrp
Copy link

pjotrp commented Aug 4, 2017

@whedon assign @bow as reviewer

@whedon whedon assigned bow and pjotrp and unassigned pjotrp Aug 4, 2017
@whedon
Copy link
Author

whedon commented Aug 4, 2017

OK, the reviewer is @bow

@pjotrp
Copy link

pjotrp commented Aug 4, 2017

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Aug 4, 2017

OK, I've started the review over in #352. Feel free to close this issue now!

@pjotrp pjotrp closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants