Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Visualizations with statistical details: The 'ggstatsplot' approach #3141

Closed
whedon opened this issue Mar 31, 2021 · 39 comments
Closed

Comments

@whedon
Copy link

whedon commented Mar 31, 2021

Submitting author: @IndrajeetPatil (Indrajeet Patil)
Repository: https://github.com/IndrajeetPatil/ggstatsplot
Version: 0.7.1
Editor: @csoneson
Reviewers: @njtierney, @kevinrue
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @IndrajeetPatil. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @csoneson.

@IndrajeetPatil if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 31, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@IndrajeetPatil
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 31, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Mar 31, 2021

@whedon check repository

@whedon
Copy link
Author

whedon commented Mar 31, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=1.21 s (210.0 files/s, 88722.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            69           4650            881          33854
JavaScript                      28           5168           5438          18920
SVG                             26              0              1           7721
R                               60           1035           2679           6091
Markdown                        23           1124              0           5625
Rmd                             22           2080           4400           5082
XML                              2              0              2            609
CSS                              7            108             58            474
YAML                            12             82             19            446
JSON                             2              1              0            381
TeX                              3             30              0            335
-------------------------------------------------------------------------------
SUM:                           254          14278          13478          79538
-------------------------------------------------------------------------------


Statistical information for the repository 'e3a349548944b834366cf7e3' was
gathered on 2021/03/31.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Indrajeet Patil                 48         54347          15043           99.42
IndrajeetPatil                   5           305             99            0.58

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Indrajeet Patil           39510           72.7          8.9               18.52

@kthyng
Copy link

kthyng commented Apr 2, 2021

@csoneson I see you're just finishing up a different submission... are you able to take on this new one?

@kthyng
Copy link

kthyng commented Apr 2, 2021

@whedon invite @csoneson as editor

@whedon
Copy link
Author

whedon commented Apr 2, 2021

@csoneson has been invited to edit this submission.

@csoneson
Copy link
Member

csoneson commented Apr 3, 2021

@whedon assign @csoneson as editor

@whedon
Copy link
Author

whedon commented Apr 3, 2021

OK, the editor is @csoneson

@IndrajeetPatil
Copy link

Thanks!

Potential reviewers:

  • RMHogervorst
  • cimentadaj
  • njtierney
  • humanfactors

@csoneson
Copy link
Member

csoneson commented Apr 5, 2021

👋 @RMHogervorst, @njtierney - would you be interested in reviewing this submission for JOSS?

Visualizations with statistical details: The 'ggstatsplot' approach

@csoneson
Copy link
Member

csoneson commented Apr 5, 2021

@IndrajeetPatil - I noticed that a couple of the references cited in your paper are listed as published by JOSS (Ludecke et al, 2021; Patil et al, 2021), but the DOIs go to a preprint server. Could you please correct these references?

@csoneson
Copy link
Member

csoneson commented Apr 5, 2021

@whedon check references

@whedon
Copy link
Author

whedon commented Apr 5, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3758/s13428-015-0664-2 is OK
- 10.3389/fpsyg.2015.01100 is OK
- 10.21105/joss.01686 is OK
- 10.31234/osf.io/ntbvy is OK
- 10.21105/joss.02815 is OK
- 10.21105/joss.02445 is OK
- 10.21105/joss.01541 is OK
- 10.31234/osf.io/vtq8f is OK
- 10.21105/joss.01412 is OK
- 10.3758/s13423-020-01798-5 is OK
- 10.21105/joss.02306 is OK

MISSING DOIs

- 10.1016/0003-2697(86)90183-1 may be a valid DOI for title: The Elements of Graphing Data

INVALID DOIs

- None

@IndrajeetPatil
Copy link

@csoneson Sorry about that. I have fixed the references.

@csoneson
Copy link
Member

csoneson commented Apr 5, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 5, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@IndrajeetPatil
Copy link

Do you know how can I avoid the duplicated affiliation index (two instances of 1) here?

Screenshot 2021-04-05 at 09 58 16

@csoneson
Copy link
Member

csoneson commented Apr 5, 2021

Good question - perhaps @openjournals/dev can help (don't know if it's because the .md is generated from the .Rmd)?

@xuanxu
Copy link
Member

xuanxu commented Apr 5, 2021

Do you know how can I avoid the duplicated affiliation index (two instances of 1) here?

The format of the affiliations section in the metadata is incorrect, should be something like:

affiliations:
 - name: Center for Humans and Machines, Max Planck Institute for Human Development, Berlin, Germany
   index: 1

@IndrajeetPatil
Copy link

Thanks, @xuanxu!

@whedon generate pdf

@IndrajeetPatil
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 5, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@IndrajeetPatil
Copy link

@xuanxu I changed my .md file according to your suggestion (https://raw.githubusercontent.com/IndrajeetPatil/ggstatsplot/master/paper/paper.md), but the second 1 has now moved to the end of the affiliation

Screenshot 2021-04-05 at 13 01 58

@xuanxu
Copy link
Member

xuanxu commented Apr 5, 2021

@IndrajeetPatil You have a dash before the index, so you are creating two affiliation entries.

Current:

affiliations:
  - name: Center for Humans and Machines, Max Planck Institute for Human Development, Berlin, Germany
  - index: 1

Correct:

affiliations:
  - name: Center for Humans and Machines, Max Planck Institute for Human Development, Berlin, Germany
    index: 1

@IndrajeetPatil
Copy link

Oops 🙈

Thanks, will fix it.

@IndrajeetPatil
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 6, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@njtierney
Copy link

Hi there!

I'd be happy to review this package. When is the due date?

@csoneson
Copy link
Member

csoneson commented Apr 7, 2021

Thanks @njtierney! We don't impose a fixed due date (and we're a bit more flexible right now given the challenges brought by the pandemic), but we encourage reviewers to post comments as they go through the submission (no need to collect them all in one big review), and to have an initial assessment for the authors to work on within two weeks from the start of the review.

@csoneson
Copy link
Member

csoneson commented Apr 7, 2021

@njtierney - I will add you as a reviewer now (and you can of course start looking at the submission), but the actual review will start once we have recruited one more reviewer. At that point I'll open the review issue, where you will find your review checklist etc.

@csoneson
Copy link
Member

csoneson commented Apr 7, 2021

@whedon assign @njtierney as reviewer

@whedon whedon assigned csoneson and njtierney and unassigned csoneson Apr 7, 2021
@whedon
Copy link
Author

whedon commented Apr 7, 2021

OK, @njtierney is now a reviewer

@csoneson
Copy link
Member

@whedon add @kevinrue as reviewer

@whedon whedon assigned csoneson and unassigned csoneson and njtierney Apr 12, 2021
@whedon
Copy link
Author

whedon commented Apr 12, 2021

OK, @kevinrue is now a reviewer

@csoneson
Copy link
Member

@njtierney, @kevinrue - thanks for accepting to review this submission! I'll start the review issue now, and we'll move the discussion over there.

@csoneson
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Apr 12, 2021

OK, I've started the review over in #3167.

@whedon whedon closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants