Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Empirical and non-parametric copula models with the cort R package #2634

Closed
whedon opened this issue Sep 2, 2020 · 37 comments
Closed

Comments

@whedon
Copy link

whedon commented Sep 2, 2020

Submitting author: @lrnv (Oskar Laverny)
Repository: https://github.com/lrnv/cort
Version: 0.3.1
Editor: @pdebuyl
Reviewers: @coatless, @agisga
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @lrnv. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @csoneson.

@lrnv if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 2, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 2, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.08 s (734.7 files/s, 51936.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               27            375            603           1209
C++                             11             75             39            517
YAML                             5             37             34            184
Markdown                         7             69              0            159
Rmd                              4            185            202            144
TeX                              2             12              0            134
CSS                              1             17              0             80
HTML                             1              4              0             21
-------------------------------------------------------------------------------
SUM:                            58            774            878           2448
-------------------------------------------------------------------------------


Statistical information for the repository '2634' was gathered on 2020/09/02.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Oskar Laverny                   17           999            368          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Oskar Laverny               631           63.2          0.5                6.18

@whedon
Copy link
Author

whedon commented Sep 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.ejor.2015.06.028 may be a valid DOI for title: Convergence results for patchwork copulas
- 10.1080/03610926.2017.1285929 may be a valid DOI for title: Density estimation via the random forest method
- 10.1016/j.jmva.2016.07.003 may be a valid DOI for title: Evading the curse of dimensionality in nonparametric density estimation with simplified vine copulas

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 2, 2020

@kthyng
Copy link

kthyng commented Sep 2, 2020

Hi @lrnv, thanks for your submission. Upon looking through your paper, I see that it does not have

A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience.

I cannot as a non-expert in your field understand enough to pass this onto a handling editor. Please make this change and ping back here when that is finished. While you are at it, please add the missing doi's listed above, too.

@lrnv
Copy link

lrnv commented Sep 3, 2020

I did correct the DOIs and rework the paper. Tell me if you think it's still not clear -- As the software solves a research-level problem, it's quite hard to describe to non-specialist, but i tried.

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 3, 2020

@lrnv
Copy link

lrnv commented Sep 3, 2020

Forgot to push..

@whedon generate pdf

@kthyng
Copy link

kthyng commented Sep 3, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 3, 2020

@kthyng
Copy link

kthyng commented Sep 3, 2020

Tell me if you think it's still not clear -- As the software solves a research-level problem, it's quite hard to describe to non-specialist, but i tried.

@lrnv Certainly, this is true for just about all the software we publish. Can you try again? I see that it is related to statistics, but then it degenerates directly into technical jargon. At the minimum, please try to find the words to connect it to the broader related fields. This will help people know if they are interested in using your software, and it will help in the review process.

@lrnv
Copy link

lrnv commented Sep 3, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 3, 2020

@lrnv
Copy link

lrnv commented Sep 3, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 3, 2020

@lrnv
Copy link

lrnv commented Sep 3, 2020

@kthyng What do you think about this last version ? If this is still not enough, i'll rethink it dont hesitate to tell me.

Thanks for taking care of that :)

@kthyng
Copy link

kthyng commented Sep 4, 2020

@lrnv I think that works, thanks.

@kthyng
Copy link

kthyng commented Sep 4, 2020

@pdebuyl Are you willing to edit this submission?

@kthyng
Copy link

kthyng commented Sep 4, 2020

@whedon invite @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Sep 4, 2020

@pdebuyl has been invited to edit this submission.

@pdebuyl
Copy link

pdebuyl commented Sep 7, 2020

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Sep 7, 2020

OK, the editor is @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Sep 7, 2020

@coatless @emilyriederer @agisga would you review the paper "Empirical and non-parametric copula models with the cort R package" for the Journal of Open Source Software?

@agisga
Copy link

agisga commented Sep 8, 2020

Hi @pdebuyl, I would be interested to review this paper but am not sure whether I can find sufficient amount of time for it in the next couple of weeks. What would be the review timeline (duration)?

@emilyriederer
Copy link

Hi @pdebuyl , I would love to help and this project looks very interesting. Unfortunately, I'd have to admit that it is far enough out of my domain that I worry I would add much of substance.

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

@agisga the expected review time is currently of six weeks. It is usually a bit shorter (four weeks) but is extended until the working conditions improve in regard to the covid-19 pandemic. Let me know if that would work for you.

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

@emilyriederer thank you for the quick reply! You may want to unsubscribe from this issue thread, else you will keep receiving emails while I look for other reviewers.

@coatless
Copy link

coatless commented Sep 9, 2020

@pdebuyl more than happy to review the software! I'm excited to see an improvement in copula estimation within R.

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

Thank you @coatless ! When the selection of a second reviewer is done, the review will start in a second github issue.

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

@whedon assign @coatless as reviewer

@whedon whedon assigned coatless and pdebuyl and unassigned pdebuyl Sep 9, 2020
@whedon
Copy link
Author

whedon commented Sep 9, 2020

OK, @coatless is now a reviewer

@agisga
Copy link

agisga commented Sep 9, 2020

Hi @pdebuyl , thank you, with a review time of 6 weeks I am available to review this submission.

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

Thank you @agisga !

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

@whedon add @agisga as reviewer

@whedon
Copy link
Author

whedon commented Sep 9, 2020

OK, @agisga is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Sep 9, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 9, 2020

OK, I've started the review over in #2653.

@whedon whedon closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants