Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: EFAtools: An R package with fast and flexible implementations of exploratory factor analysis tools #2499

Closed
whedon opened this issue Jul 22, 2020 · 17 comments

Comments

@whedon
Copy link

whedon commented Jul 22, 2020

Submitting author: @mdsteiner (Markus Steiner)
Repository: https://github.com/mdsteiner/EFAtools
Version: v0.1.1
Editor: @fboehm
Reviewers: @jacobsoj, @chainsawriot
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @mdsteiner. Currently, there isn't an JOSS editor assigned to your paper.

@mdsteiner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 22, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.89 s (107.7 files/s, 13801.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               82           1887           2796           5648
C++                              6            163            491            487
Markdown                         4             70              0            269
TeX                              1             15              0            148
Rmd                              2            104            144             73
YAML                             1              1              1              2
-------------------------------------------------------------------------------
SUM:                            96           2240           3432           6627
-------------------------------------------------------------------------------


Statistical information for the repository '2499' was gathered on 2020/07/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Markus Steiner                   1             4              4            0.28
Silvia Grieder                   3            34             33            2.38
mdsteiner                       26          1939            799           97.33

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Markus Steiner                4          100.0          8.6                0.00
Silvia Grieder               21           61.8          1.8               57.14
mdsteiner                  1116           57.6          5.8               42.92

@whedon
Copy link
Author

whedon commented Jul 22, 2020

Failed to discover a valid open source license.

@whedon
Copy link
Author

whedon commented Jul 22, 2020

Reference check summary:

OK DOIs

- 10.1177/1073191119845051 is OK
- 10.1007/BF02289209 is OK
- 10.7275/jyj1-4868 is OK
- 10.1177/0095798418771807 is OK
- 10.7287/peerj.preprints.3188v1 is OK
- 10.1016/j.csda.2013.02.005 is OK
- 10.1037/met0000200 is OK
- 10.1037/met0000074 is OK
- 10.1037/a0025697 is OK
- 10.1080/00273171.2011.564527 is OK
- 10.18637/jss.v048.i02 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jul 22, 2020

@Kevin-Mattheus-Moerman
Copy link
Member

@mdsteiner our system could not detect a license. Can you add a plain text LICENSE file to your repository? Adding it to the main repository folder is best (that way GitHub also easily discovers it and will render a clear license badge on your repo). The license needs to be an OSI approved open source license.

@Kevin-Mattheus-Moerman
Copy link
Member

@KristinaRiemer @fboehm @mikldk @csoneson could one of you handle this submission?

@mdsteiner
Copy link

thanks for the note! We have now added a LICENSE file to our repository.

As potential reviewers we think that maybe jacobsoj, navmayan, ihrke, or mmrabe (all from the linked list) might be suitable based on their descriptions on the domains/ topics they are comfortable to review.

@fboehm
Copy link

fboehm commented Jul 22, 2020

Yes, thank you, @Kevin-Mattheus-Moerman. I'm happy to handle this submission.

@fboehm
Copy link

fboehm commented Jul 22, 2020

@whedon assign @fboehm as editor

@whedon
Copy link
Author

whedon commented Jul 22, 2020

OK, the editor is @fboehm

@fboehm
Copy link

fboehm commented Jul 23, 2020

@whedon assign @jacobsoj as reviewer

@whedon whedon assigned fboehm and unassigned fboehm Jul 23, 2020
@whedon
Copy link
Author

whedon commented Jul 23, 2020

OK, @jacobsoj is now a reviewer

@fboehm
Copy link

fboehm commented Jul 26, 2020

@whedon add @chainsawriot as reviewer

@whedon whedon assigned fboehm and unassigned fboehm Jul 26, 2020
@whedon
Copy link
Author

whedon commented Jul 26, 2020

OK, @chainsawriot is now a reviewer

@fboehm
Copy link

fboehm commented Jul 26, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 26, 2020

OK, I've started the review over in #2521.

@whedon whedon closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants