Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: lattice_mc: A Python Lattice-Gas Monte Carlo Module #241

Closed
whedon opened this issue Apr 16, 2017 · 17 comments
Closed

[PRE REVIEW]: lattice_mc: A Python Lattice-Gas Monte Carlo Module #241

whedon opened this issue Apr 16, 2017 · 17 comments
Assignees

Comments

@whedon
Copy link

whedon commented Apr 16, 2017

Submitting author: @bjmorgan (Benjamin J. Morgan)
Repository: https://github.com/bjmorgan/lattice_mc
Version: 1.0.0
Editor: @labarba
Reviewer: @asmit3

Author instructions

Thanks for submitting your paper to JOSS @bjmorgan. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@bjmorgan if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 16, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @labarba it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Apr 16, 2017

👋 @labarba - the submitting author suggested you as an editor for this submission.

@labarba
Copy link
Member

labarba commented Apr 16, 2017

The code repository needs A statement of need, which means ...

The authors should clearly state what problems the software is designed to solve and who the target audience is.

I was not able to find this, @bjmorgan.

@bjmorgan
Copy link

bjmorgan commented Apr 17, 2017

@labarba I have amended the README.md and paper.md. Hopefully the additional information is suitable and appropriate for the JOSS requirements.

In solid electrolytes, ionic motion is typically effected by a series of discrete "jumps" where ions move between adjacent lattice sites [1]. For dilute mobile ions, ionic trajectories are random walks, and simple analytical expressions exits that relate macroscopic transport coefficients, i.e. diffusion coefficients and ionic conductivities, to the microscopic jump frequency of individual ions [2,3]. Practical solid electrolytes have high mobile ion concentrations, with significnat interparticle interactions producing deviations from the dilute limit random walk behaviour. In general, the quantitative effect of interparticle interactions cannot be determined analytically. As an alternative, numerical simulations, such as lattice-gas Monte Carlo methods, can be used to directly calculate these relationships. Lattice-gas Monte Carlo methods are particularly suited to studying how varying properties across broad classes of materials give quantitative differences in macroscopic ionic transport, and can be used to understand the different transport properties of materials with, for example, different crystal structures or mobile ion stoichiometries.

lattice_mc has been written to allow materials scientists and solid-state chemists model how the microscopic physics of solid electrolytes (crystal structure, stoichiometry, interaction models) determine macroscopic transport behaviour (diffusion and ionic conduction), with the goal of understand the factors that make different materials more or less useful for specific applications (e.g. Li-ion batteries or fuel cells).

@labarba
Copy link
Member

labarba commented Apr 18, 2017

The title in the paper metadata appears as "lattice_mc: A Python Lattice-Gas Monte Carlo Module". I"m not sure why this full title does not appear in the title of the pre-review issue ... it should also probably match the heading in the README.

I'm looking for a reviewer now.

@arfon arfon changed the title [PRE REVIEW]: lattice_mc [PRE REVIEW]: lattice_mc: A Python Lattice-Gas Monte Carlo Module Apr 19, 2017
@arfon
Copy link
Member

arfon commented Apr 19, 2017

The title in the paper metadata appears as "lattice_mc: A Python Lattice-Gas Monte Carlo Module". I"m not sure why this full title does not appear in the title of the pre-review issue ... it should also probably match the heading in the README.

I just updated this.

@labarba labarba closed this as completed Apr 20, 2017
@whedon whedon assigned labarba and unassigned labarba Apr 20, 2017
@labarba labarba reopened this Apr 20, 2017
@labarba
Copy link
Member

labarba commented Apr 20, 2017

Sorry ... I was demonstrating the JOSS bot to a chief librarian and hit "Enter" in the process ... Ignore the actions just above!

@labarba
Copy link
Member

labarba commented Apr 20, 2017

@whedon commands

@whedon
Copy link
Author

whedon commented Apr 20, 2017

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

@labarba
Copy link
Member

labarba commented Apr 20, 2017

@arfon : Does our bot have a command to unassign a reviewer? I assigned myself by mistake.

@arfon
Copy link
Member

arfon commented Apr 20, 2017

@arfon : Does our bot have a command to unassign a reviewer? I assigned myself by mistake.

Not right now sorry, you're on the hook for reviewing now :trollface:. In all seriousness, when we find a reviewer just use the @whedon assign username as reviewer and it will clobber your assignment.

@labarba
Copy link
Member

labarba commented Apr 22, 2017

@whedon assign asmit3 as reviewer

@whedon whedon assigned asmit3 and labarba and unassigned labarba Apr 22, 2017
@whedon
Copy link
Author

whedon commented Apr 22, 2017

OK, the reviewer is asmit3

@labarba
Copy link
Member

labarba commented Apr 22, 2017

@whedon start review

@whedon
Copy link
Author

whedon commented Apr 22, 2017

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas

@labarba
Copy link
Member

labarba commented Apr 22, 2017

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Apr 22, 2017

OK, I've started the review over in #247. Feel free to close this issue now!

@labarba labarba closed this as completed Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants