Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Excimontec v1.0: An Open-Source Software Tool for Kinetic Monte Carlo Simulations of Organic Electronic Devices #2248

Closed
whedon opened this issue May 24, 2020 · 28 comments

Comments

@whedon
Copy link

whedon commented May 24, 2020

Submitting author: @MikeHeiber (Michael Heiber)
Repository: https://github.com/MikeHeiber/Excimontec
Version: v1.0.0
Editor: @pdebuyl
Reviewers: @mdavezac
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @MikeHeiber. Currently, there isn't an JOSS editor assigned to your paper.

@MikeHeiber if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 24, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 24, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.92 s (437.1 files/s, 99268.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                             19           2236              5          36176
HTML                           227           1801           1628          32321
C++                              6            158            664           5572
JavaScript                     125            164            245           3838
CSS                              4            359             80           1743
TeX                              3            196              4            910
XML                              6              0              0            766
C/C++ Header                     4            308            553            657
Markdown                         5            138              0            628
make                             1             18              7             50
YAML                             1              5              5             35
Bourne Shell                     1              5             12             11
-------------------------------------------------------------------------------
SUM:                           402           5388           3203          82707
-------------------------------------------------------------------------------


Statistical information for the repository '2248' was gathered on 2020/05/24.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Joshua S Brown                   1             2              2            0.01
JoshuaSBrown                     1            16              0            0.03
Michael C. Heiber               87         27717          18085           90.94
MikeHeiber                      12          3752            792            9.02

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
JoshuaSBrown                  6           37.5         22.0                0.00
Michael C. Heiber         12206           44.0         22.5               12.25

@whedon
Copy link
Author

whedon commented May 24, 2020

Reference check summary:

OK DOIs

- 10.1002/pssb.201350339 is OK
- 10.1088/1361-6633/80/2/026502 is OK
- 10.21105/joss.01072 is OK
- 10.1016/B978-0-08-102284-9.00010-3 is OK
- 10.21105/joss.01168 is OK
- 10.1002/aelm.201800821 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented May 24, 2020

@arfon
Copy link
Member

arfon commented May 24, 2020

Copying an excerpt of the author submission comment for future editors which includes potential reviewers:

I'd like to suggest several expert reviewers that may not already be current JOSS reviewers: Prof. Geoff Hutchison, University of Pittsburgh, @ghutchis on GitHub. Dr. Christoph Junghans, Los Alamos National Lab,@junghans on GitHub Prof. Bjoern Baumeier, Eindhoven University of Technology, @baumeier on GitHub

@arfon
Copy link
Member

arfon commented May 24, 2020

👋 @MikeHeiber - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 24, 2020
@kyleniemeyer
Copy link

Hi @pdebuyl, can you take this submission on as your first editorial assignment?

@kyleniemeyer
Copy link

@whedon invite @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Jun 7, 2020

@pdebuyl has been invited to edit this submission.

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@kyleniemeyer yes [note that I self-assigned already for another submission :-) ]

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@elena-pascal , @dalonsoa are you willing to review this paper for JOSS ?

@dalonsoa
Copy link

dalonsoa commented Jun 8, 2020

Hi @pdebuyl , I'm afraid I'm packed with other stuff at the moment. Sorry, maybe next time.

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@dalonsoa thank you for the quick reply!

@arfon
Copy link
Member

arfon commented Jun 8, 2020

@whedon assign @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Jun 8, 2020

OK, the editor is @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@mdavezac would you review the article "Excimontec v1.0: An Open-Source Software Tool for Kinetic Monte Carlo Simulations of Organic Electronic Devices" for the Journal of Open Source Software?

@mdavezac
Copy link

mdavezac commented Jun 8, 2020

@pdebuyl, I'll will be a bit slow in reviewing because of other commitments. If that's okay, then I'm happy to take it on.

@elena-pascal
Copy link

@pdebuyl sorry my C++ is not good enough to review this.

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@whedon assign @liangtianumich as reviewer

@whedon whedon assigned pdebuyl and unassigned pdebuyl Jun 8, 2020
@whedon
Copy link
Author

whedon commented Jun 8, 2020

OK, @liangtianumich is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@whedon assign @mdavezac as reviewer

@whedon whedon assigned mdavezac and pdebuyl and unassigned pdebuyl Jun 8, 2020
@whedon
Copy link
Author

whedon commented Jun 8, 2020

OK, @mdavezac is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@mdavezac thank you, we are still recovering from our pause so this should be ok

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@elena-pascal thank you for the quick reply!

@pdebuyl
Copy link

pdebuyl commented Jun 8, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Jun 8, 2020

OK, I've started the review over in #2307.

@whedon whedon closed this as completed Jun 8, 2020
@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 8, 2020
@arfon
Copy link
Member

arfon commented Jun 8, 2020

@whedon assign @mdavezac as reviewer

Heads up @pdebuyl, assign clobbers existing reviewer assignments which means you actually only have a single reviewer assigned now on #2307.

If you do @whedon add @liangtianumich as reviewer in #2307, you will then have to edit the issue at the top of #2307 to manually add a checklist for @ liangtianumich to work through.

@pdebuyl
Copy link

pdebuyl commented Jun 9, 2020

Thanks @arfon it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants