Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pyscses - a python space charge site explicit solver #1163

Closed
whedon opened this issue Jan 11, 2019 · 18 comments
Closed

[PRE REVIEW]: pyscses - a python space charge site explicit solver #1163

whedon opened this issue Jan 11, 2019 · 18 comments

Comments

@whedon
Copy link

whedon commented Jan 11, 2019

Submitting author: @georgiewellock (Georgina Wellock)
Repository: https://github.com/bjmorgan/pyscses
Version: v 0.9.3.2
Editor: @labarba
Reviewers: @ncclementi, @vyasr

Author instructions

Thanks for submitting your paper to JOSS @georgiewellock. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@georgiewellock if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 11, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@labarba) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jan 11, 2019

Attempting PDF compilation. Reticulating splines etc...

@arfon
Copy link
Member

arfon commented Jan 11, 2019

👋 @labarba - the submitting author suggested you as the handling editor.

@whedon
Copy link
Author

whedon commented Jan 11, 2019

@labarba
Copy link
Member

labarba commented Jan 15, 2019

@ncclementi — Would you be willing to volunteer a review for this submission to JOSS? You've experienced the review process as an author, so you'll know what is entailed, but have a look at the documentation to imagine what it's like from the other side.
Let me know!

@ncclementi
Copy link

@labarba Sure, I'll be happy to do it.

@labarba
Copy link
Member

labarba commented Jan 17, 2019

@whedon assign @ncclementi as reviewer

@whedon whedon assigned labarba and unassigned labarba Jan 17, 2019
@whedon
Copy link
Author

whedon commented Jan 17, 2019

OK, the reviewer is @ncclementi

@labarba
Copy link
Member

labarba commented Jan 17, 2019

👋 @vyasr — Have you reviewed for JOSS? You've published with us, I remember (quaternions!). Would you be able to help us out as second reviewer for this submission?

[UPDATE] Email sent to @vyasr today, Jan. 27.

@labarba
Copy link
Member

labarba commented Jan 27, 2019

@whedon check references

@whedon
Copy link
Author

whedon commented Jan 27, 2019

Attempting to check references...

@whedon
Copy link
Author

whedon commented Jan 27, 2019


OK DOIs

- http://doi.org/10.1002/bbpc.198400007 is OK
- http://doi.org/10.1016/0022-3697(85)90172-6 is OK
- http://doi.org/10.1016/S0167-2738(98)00502-5 is OK
- http://doi.org/10.1016/0167-2738(96)00316-5 is OK
- http://doi.org/10.1016/S0167-2738(02)00229-1 is OK
- http://doi.org/10.1149/1.1507597 is OK
- http://doi.org/10.1016/j.ssi.2011.07.001 is OK
- http://doi.org/10.1002/fuce.201200071 is OK
- http://doi.org/10.1016/j.ssi.2016.10.010 is OK
- http://doi.org/10.1063/1.3681169 is OK
- http://doi.org/10.1002/0470020229.ch1 is OK
- http://doi.org/10.1039/B300170A is OK
- http://doi.org/10.1023/A:1009998114205 is OK
- http://doi.org/10.1039/C6CP02177H is OK

MISSING DOIs

- https://doi.org/10.32607/20758251-2018-10-1-24-33 may be missing for title: The Surface Motion of Particles in Crystals and the Natural Roughness of Crystalline Faces
- https://doi.org/10.1063/1.117366 may be missing for title: Defect and transport properties of nanocrystalline CeO_2-x
- https://doi.org/10.1016/0079-6786(95)00004-e may be missing for title: Ionic Conduction in Space Charge Regions
- https://doi.org/10.1557/proc-492-377 may be missing for title: Combined atomistic and continuum modelling of space charge formation at the CeO_2 (111) grain boundary.

INVALID DOIs

- None

@labarba
Copy link
Member

labarba commented Jan 27, 2019

👋 @georgiewellock — have a look at your references list and check on @whedon's suggestions ☝️

@vyasr
Copy link

vyasr commented Jan 27, 2019

@labarba sorry I missed this request somehow. Yes, I reviewed for JOSS a few months ago. I'm happy to help out here too.

@labarba
Copy link
Member

labarba commented Jan 27, 2019

@whedon add @vyasr as reviewer

@whedon
Copy link
Author

whedon commented Jan 27, 2019

OK, @vyasr is now a reviewer

@labarba
Copy link
Member

labarba commented Jan 27, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Jan 27, 2019

OK, I've started the review over in #1209. Feel free to close this issue now!

@labarba labarba closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants