Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: estez: Create and Query a Local Copy of GenBank in R #1101

Closed
whedon opened this issue Nov 27, 2018 · 28 comments
Closed

[PRE REVIEW]: estez: Create and Query a Local Copy of GenBank in R #1101

whedon opened this issue Nov 27, 2018 · 28 comments
Assignees
Labels
pre-review R rOpenSci Submissions associated with rOpenSci TeX

Comments

@whedon
Copy link

whedon commented Nov 27, 2018

Submitting author: @DomBennett (Dominic Bennett)
Repository: https://github.com/ropensci/restez
Version: v1.0.0
Editor: @karthik
Reviewers: @arfon

Author instructions

Thanks for submitting your paper to JOSS @DomBennett. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@DomBennett if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 27, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @karthik it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@karthik) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@ooo
Copy link

ooo bot commented Nov 27, 2018

👋 Hey @whedon...

Letting you know, @karthik is currently OOO until Saturday, December 1st 2018. ❤️

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@arfon
Copy link
Member

arfon commented Nov 27, 2018

@DomBennett - could you link to the rOpenSci onboarding thread here please?

Also, please take a look a the preview PDF - I think there needs to be a space between the # and your headers.

@DomBennett
Copy link

Hi @arfon,

I've updated the headers and I've switched the image insertion from html to markdown (there was no figure in the pdf proof).

ROpenSci onboarding thread: ropensci/software-review#232

@arfon
Copy link
Member

arfon commented Nov 27, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@arfon
Copy link
Member

arfon commented Nov 27, 2018

@DomBennett does this look OK? ☝️

@DomBennett
Copy link

@arfon better! But I didn't realise the figure caption was generated from the image caption. I've updated the paper to reflect this. I've also changed the code snippets for R syntax highlighting.

Can I ask whedon to re-compile?

@whedon generate pdf

@DomBennett
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@DomBennett
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@DomBennett
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@DomBennett
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 27, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 27, 2018

@DomBennett
Copy link

@arfon sorry, my error! Had to do a bit of wrangling of the markdown to get the figure placement correct.

I'm now happy with it. Thanks!

@arfon
Copy link
Member

arfon commented Nov 27, 2018

@whedon assign @arfon as reviewer

@whedon
Copy link
Author

whedon commented Nov 27, 2018

OK, the reviewer is @arfon

@arfon
Copy link
Member

arfon commented Nov 27, 2018

@whedon start review

@arfon arfon closed this as completed Nov 27, 2018
@whedon
Copy link
Author

whedon commented Nov 27, 2018

OK, I've started the review over in #1102. Feel free to close this issue now!

@arfon arfon added the rOpenSci Submissions associated with rOpenSci label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R rOpenSci Submissions associated with rOpenSci TeX
Projects
None yet
Development

No branches or pull requests

4 participants