-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application run cannot find javafx.web module on Java 17 #117
Comments
Do you have an example |
I am encountering this (or a similar) problem. For comparison, I'm using both Eclipse and Gradle to run and build. version
|
@abhinayagarwal Can you have a look at the reproduction cases? I tested both 0.0.11 and 0.0.12 with a sample project. |
Similar problem for me running JDK 17 and trying to upgrade from
|
@nlisker Can you confirm if you are still facing this issue in 0.0.13 and JFX 19 ? |
@abhinayagarwal I have the same issue "Could not find or load main" in 0.0.13 and JFX 19 (JDK17) |
Same thing here, I am using:
But the problem goes away when downgrading to JFX gradle plugin 0.0.11. Note that this problem only happens when we add a module-info.java under src/main/java. If the file is removed from there it works with latest version. |
@abhinayagarwal Let's look at this sample so we have a common ground: https://github.com/openjfx/samples/tree/master/IDE/Eclipse/Modular/Gradle/hellofx (or for other IDEs, I personally use this one because I use Eclipse). I only updated the JavaFX version to 19, grade wrapper to 7.5.1 and 'org.beryx.jlink' to version '2.25.0'. Gradle runs on Java 18 (better to add toolchain support in these examples so Gradle and the application can use different Java versions). The results are:
'org.openjfx.javafxplugin' version '0.0.13': same as '0.0.12' With this sample you can test directly what works and what doesn't. |
I hit the same issue :-( |
Same issue here. I tried different combinations of versions with the @nlisker's hellofx example:
|
I did some further testing. This commit seems to break the plugin: 02d36b8 Moduleplugin versions 1.8.2 - 1.8.9 all work, but 1.8.10 triggers the bug, also 1.8.11 and 1.8.12 fail. |
@nlisker. Ok added this to
Now it works with Java 19, Gradle 8.0.1 and JavaFX 19.0.2. Apparently this change (java9-modularity/gradle-modules-plugin@fda9c7e#diff-ae589711150c3780c06898bd2c6583a49c3bfe8f6918f6f4549ade459fd500aa) in moduleplugin 1.8.10 affects Gradle versions 6.4+. A wrong module name gets passed to --module? Manually overriding it seems to fix it for me. edit: now that I tried it again, I noticed that I had forgotten to comment out the |
Thanks, I'll try it out. Maybe @abhinayagarwal can use this info to create a fix. |
The Gradle Application Plugin
run
task doesn't work when running with Java 17.Works fine on Java 11, but when updated to run Java 17 and JavaFX 17, I get
java.lang.module.FindException: Module javafx.web not found
Workaround:
Remove the javafxplugin
Add JavaFX dependencies
I wonder if there is still any use for this plugin. It saves a few more lines, but seems to do just the same as my workaround.
The text was updated successfully, but these errors were encountered: