Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903850: JCStress: Upgrade GitHub Action Runner image for macOS #152

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 1, 2024

This PR upgrades GitHub Action Runner image for macOS to macos-12 as macos-11 seems to have been removed.

See https://github.com/actions/runner-images?tab=readme-ov-file#available-images and actions/runner-images#9255


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903850: JCStress: Upgrade GitHub Action Runner image for macOS (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jcstress.git pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/152.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back izeye! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@izeye This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903850: JCStress: Upgrade GitHub Action Runner image for macOS

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

@shipilev shipilev changed the title Upgrade GitHub Action Runner image for macOS to macos-12 7903850: JCStress: Upgrade GitHub Action Runner image for macOS Oct 1, 2024
.github/workflows/pre-integration.yml Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@izeye Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024
@izeye
Copy link
Contributor Author

izeye commented Oct 1, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@izeye
Your change (at version b33edc6) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Oct 1, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

Going to push as commit eb1a23c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2024
@openjdk openjdk bot closed this Oct 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@shipilev @izeye Pushed as commit eb1a23c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@izeye izeye deleted the macos-12 branch October 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants