From 13fdd51c93e4df47e159298ac601a805461a84f0 Mon Sep 17 00:00:00 2001
From: olewandowski1 <olewandowski@soldevelo.com>
Date: Mon, 8 Jan 2024 16:34:02 +0100
Subject: [PATCH 1/3] OP-1725: remove null/empty option from dropdowns

---
 src/components/ContractHeadPanel.js        | 3 +--
 src/dialogs/CreateContractDetailsDialog.js | 4 ++--
 src/dialogs/UpdateContractDetailsDialog.js | 4 ++--
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/components/ContractHeadPanel.js b/src/components/ContractHeadPanel.js
index cff61f6..9ff4616 100644
--- a/src/components/ContractHeadPanel.js
+++ b/src/components/ContractHeadPanel.js
@@ -174,8 +174,7 @@ class ContractHeadPanel extends FormPanel {
             <PublishedComponent
               pubRef="policyHolder.PolicyHolderPicker"
               module="contract"
-              withNull
-              nullLabel={formatMessage(intl, "contract", "emptyLabel")}
+              withNull={false}
               value={!!edited && !!edited.policyHolder && edited.policyHolder}
               onChange={(v) => this.updateAttribute("policyHolder", v)}
               readOnly={
diff --git a/src/dialogs/CreateContractDetailsDialog.js b/src/dialogs/CreateContractDetailsDialog.js
index 6ddd2dc..c2d4b4f 100644
--- a/src/dialogs/CreateContractDetailsDialog.js
+++ b/src/dialogs/CreateContractDetailsDialog.js
@@ -139,7 +139,7 @@ class CreateContractDetailsDialog extends Component {
                                 <PublishedComponent
                                     pubRef="policyHolder.PolicyHolderInsureePicker"
                                     required
-                                    withNull
+                                    withNull={false}
                                     policyHolderId={contract?.policyHolder?.id}
                                     value={!!contractDetails.insuree && contractDetails.insuree}
                                     onChange={v => this.updateAttribute('insuree', v)}
@@ -148,7 +148,7 @@ class CreateContractDetailsDialog extends Component {
                             <Grid item className={classes.item}>
                                 <PublishedComponent
                                     pubRef="policyHolder.PolicyHolderContributionPlanBundlePicker"
-                                    withNull
+                                    withNull={false}
                                     nullLabel={formatMessage(intl, "contract", "emptyLabel")}
                                     policyHolderId={contract?.policyHolder?.id}
                                     value={!!contractDetails.contributionPlanBundle && contractDetails.contributionPlanBundle}
diff --git a/src/dialogs/UpdateContractDetailsDialog.js b/src/dialogs/UpdateContractDetailsDialog.js
index 501a27e..64759a3 100644
--- a/src/dialogs/UpdateContractDetailsDialog.js
+++ b/src/dialogs/UpdateContractDetailsDialog.js
@@ -149,7 +149,7 @@ class CreateContractDetailsDialog extends Component {
                                 <PublishedComponent
                                     pubRef="policyHolder.PolicyHolderInsureePicker"
                                     required
-                                    withNull
+                                    withNull={false}
                                     policyHolderId={contract?.policyHolder?.id}
                                     value={!!contractDetails.insuree && contractDetails.insuree}
                                     readOnly
@@ -158,7 +158,7 @@ class CreateContractDetailsDialog extends Component {
                             <Grid item className={classes.item}>
                                 <PublishedComponent
                                     pubRef="policyHolder.PolicyHolderContributionPlanBundlePicker"
-                                    withNull
+                                    withNull={false}
                                     nullLabel={formatMessage(intl, "contract", "emptyLabel")}
                                     policyHolderId={contract?.policyHolder?.id}
                                     value={!!contractDetails.contributionPlanBundle && contractDetails.contributionPlanBundle}

From ca66584c4df5fefb52e8fd931383ce444f70ec51 Mon Sep 17 00:00:00 2001
From: olewandowski1 <olewandowski@soldevelo.com>
Date: Thu, 8 Feb 2024 14:37:14 +0100
Subject: [PATCH 2/3] OP-1806: fix calendar picker to allow selecting future
 dates

---
 src/components/ContractHeadPanel.js | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/components/ContractHeadPanel.js b/src/components/ContractHeadPanel.js
index 9ff4616..9f12f9e 100644
--- a/src/components/ContractHeadPanel.js
+++ b/src/components/ContractHeadPanel.js
@@ -280,10 +280,13 @@ class ContractHeadPanel extends FormPanel {
               module="contract"
               label="dateValidFrom"
               required
-              maxDate={!!edited && !!edited.dateValidTo && edited.dateValidTo}
               value={!!edited && !!edited.dateValidFrom && edited.dateValidFrom}
               onChange={(v) => this.updateAttribute("dateValidFrom", v)}
               readOnly={readOnlyFields.includes("dateValidFrom") || isAmendment}
+              // NOTE: maxDate cannot be passed if endDate does not exist.
+              // Passing any other falsy value will block months manipulation.
+              // eslint-disable-next-line react/jsx-props-no-spreading
+              {...(edited.dateValidTo ? { maxDate: edited.dateValidTo } : null)}
             />
           </Grid>
           <Grid item xs={2} className={classes.item}>
@@ -292,12 +295,13 @@ class ContractHeadPanel extends FormPanel {
               module="contract"
               label="dateValidTo"
               required
-              minDate={
-                !!edited && !!edited.dateValidFrom && edited.dateValidFrom
-              }
               value={!!edited && !!edited.dateValidTo && edited.dateValidTo}
               onChange={(v) => this.updateAttribute("dateValidTo", v)}
               readOnly={readOnlyFields.includes("dateValidTo")}
+              // NOTE: minDate cannot be passed if startDate does not exist.
+              // Passing any other falsy value will block months manipulation.
+              // eslint-disable-next-line react/jsx-props-no-spreading
+              {...(edited.dateValidFrom ? { minDate: edited.dateValidFrom } : null)}
             />
           </Grid>
         </Grid>

From 03fdd7ce2bea80ba8efb4a15a0eb5d2de134b2d2 Mon Sep 17 00:00:00 2001
From: olewandowski1 <olewandowski@soldevelo.com>
Date: Thu, 8 Feb 2024 14:40:55 +0100
Subject: [PATCH 3/3] OP-1806: fix docs

---
 src/components/ContractHeadPanel.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/ContractHeadPanel.js b/src/components/ContractHeadPanel.js
index 9f12f9e..5cbb82b 100644
--- a/src/components/ContractHeadPanel.js
+++ b/src/components/ContractHeadPanel.js
@@ -283,7 +283,7 @@ class ContractHeadPanel extends FormPanel {
               value={!!edited && !!edited.dateValidFrom && edited.dateValidFrom}
               onChange={(v) => this.updateAttribute("dateValidFrom", v)}
               readOnly={readOnlyFields.includes("dateValidFrom") || isAmendment}
-              // NOTE: maxDate cannot be passed if endDate does not exist.
+              // NOTE: maxDate cannot be passed if dateValidTo does not exist.
               // Passing any other falsy value will block months manipulation.
               // eslint-disable-next-line react/jsx-props-no-spreading
               {...(edited.dateValidTo ? { maxDate: edited.dateValidTo } : null)}
@@ -298,7 +298,7 @@ class ContractHeadPanel extends FormPanel {
               value={!!edited && !!edited.dateValidTo && edited.dateValidTo}
               onChange={(v) => this.updateAttribute("dateValidTo", v)}
               readOnly={readOnlyFields.includes("dateValidTo")}
-              // NOTE: minDate cannot be passed if startDate does not exist.
+              // NOTE: minDate cannot be passed if dateValidFrom does not exist.
               // Passing any other falsy value will block months manipulation.
               // eslint-disable-next-line react/jsx-props-no-spreading
               {...(edited.dateValidFrom ? { minDate: edited.dateValidFrom } : null)}