Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(partially) fix RVFI integration issues #719

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

MikeOpenHWGroup
Copy link
Member

This PR resolves SV compile errors and warnings flagged by dsim:

  • bhv/cv32e40p_rvfi.sv: nonblocking assignments to automatic variables are not allowed (object variables are automatic by default). Dsim won't compile this but I expect VCS does.
  • bhv/cv32e40p_tb_wrapper.sv: dsim warns about several width mismatches. I did not resolve this, but they are flagged with FIXMEs.

@MikeOpenHWGroup MikeOpenHWGroup added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Aug 10, 2022
@davideschiavone
Copy link
Contributor

Hi @MikeOpenHWGroup - you should download Verible, checkout the version mentioned in the README and run verible (the script is in the util folder)

@MikeOpenHWGroup
Copy link
Member Author

Done. Verible wanted to make a lot of changes to both bhv and rtl files. I only pushed in the verible-ized versions of the files modified in this pull-request, namely bhv/cv32e40p_rvfi.sv and bhv/cv32e40p_tb_wrapper.sv.

@davideschiavone
Copy link
Contributor

Done. Verible wanted to make a lot of changes to both bhv and rtl files. I only pushed in the verible-ized versions of the files modified in this pull-request, namely bhv/cv32e40p_rvfi.sv and bhv/cv32e40p_tb_wrapper.sv.

probably you.are not using the right version, indeed the CI still fails. if you want we can set a meeting and fix it

@MikeOpenHWGroup
Copy link
Member Author

Ha! I resubmitted using verible-verilog-format version v0.0-1149-g7eae750 and it seems to work.

@davideschiavone davideschiavone merged commit 958ecee into openhwgroup:dev Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants