-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default impi version should match intel compiler #524
Comments
Hi @chuckatkins, thanks for testing out the updated approach over in #479. I personally think we need to be careful about making impi versions default to matching the compiler version. While that likely happens the majority of the time, there is nothing to prevent a user from installing impi separately (since it is available as a standalone entity) and there are also times when we see updates for the compiler without a matching update in impi. As an example, the most recent 2017 pxse cluster studio collection contains Basing things off of the raw versioning string from the corresponding RPM seems to me, to be a more accurate and transparent way to track the version in cases like this. What do you think - you can live with an approach where the impi versioning matches the rpm that installed it? |
Hi @koomie,
Yes, I think that's great. The problem before was that both the compiler and impi ohpc packages each used a different means of introspection to determine their respective module versions, both of which were disjoint from the actual RPM version of the product itself. I think keeping the module version in line with the product rpm version works great and removes any "interpretation" that might need to be done.
Yep, things get even messier when you throw 2016 in to the mix since you'll have compiler version
Agreed. The problem I'm specifically trying to address is when multiple compiler and impi versions are available:
Because the default version is always to use the newest available, you end up with the 2016u4 compiler and 2018b1 impi, which is almost certainly not what would be expected. I took a crack at this over in #523. Essentially, durring the compiler module install, it looks to see if there's an impi installed in the same prefis. If there is, it sets up the default impi version when that compiler version is loaded. |
So really the intent here is not for the default impi version to match the compiler version, but more so to have the default impi version be the one associated with the currently loaded compiler. |
Closing this issue but leaving #523 open for future discussion |
Now that the version parsing is fixed in 0863c5c , it would be great if somehow the default impi version was aligned with the compiler version it was shipped with. i.e. intel compiler version
16.0.3.210
would use a default impi version of5.1.3.210
, compiler version17.0.4.196
would default to impi version2017.3.196
, etc. A preliminary implementation can be found in #523 .The text was updated successfully, but these errors were encountered: