Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dark mode #207

Closed
wborn opened this issue Oct 4, 2019 · 4 comments
Closed

Add support for dark mode #207

wborn opened this issue Oct 4, 2019 · 4 comments

Comments

@wborn
Copy link
Member

wborn commented Oct 4, 2019

At night the website (especially documentation) can be blinding to the eyes. Maybe we can also support dark mode?

Such a user preference can be detected using the prefers-color-scheme user preference media query. Detection is currently supported by ~76% of all browsers used world wide (see caniuse). For some examples see also MDN.

@Confectrician
Copy link
Contributor

I have found https://github.com/tolking/vuepress-theme-default-prefers-color-scheme which seems to add the prefers-colors-scheme mediea query to the default theme.
Also this is discussed in an vuepress issue already.
Ref:
vuejs/vuepress#1865

@ghys
Copy link
Member

ghys commented Jan 5, 2020

This plugin is for VuePress 1.x ;)
We're still on 0.x, 1.x has quite a few differences, so there should be some breaking changes to expect and we'll have to be careful if/when we migrate.

@Confectrician
Copy link
Contributor

I think we had some more issues where 1.x was topic.
We should maybe think about doing an update anyways in the nearer future.

@wborn
Copy link
Member Author

wborn commented Dec 17, 2020

I see https://next.openhab.org/ now has a proper dark mode so this issue should be fixed soon. 😎

@wborn wborn closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants