Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcn] Reference modules and groups by segment id and module/group id instead of serial number #8097

Closed
toweosp opened this issue Jul 9, 2020 · 1 comment · Fixed by #8120
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@toweosp
Copy link

toweosp commented Jul 9, 2020

I would like to propose to use a combination of segment and module/group id instead of the serial number to identify LCN things (when using automatic discovery).

It could be represented e.g. in the format

S<segment_id>M<module_id>
resp.
S<segment_id>G<group_id>

LCN modules (smart/bus modules) are uniquely identified by this combination. Furthermore - as far as I know - using the module id (in combination with the segment id, if in bigger environments the installation is splitted into segments) is the common approach to identify modules when planning/programming LCN bus systems. (Logical) LCN groups are handled analogously.

In my opinion this would make textual item and rule definitions much more readable and maintainable.

@toweosp toweosp added the enhancement An enhancement or new feature for an existing add-on label Jul 9, 2020
@toweosp toweosp changed the title [LCN] Reference modules and groups by segment id and module/group id instead of serial number [lcn] Reference modules and groups by segment id and module/group id instead of serial number Jul 10, 2020
@fwolter
Copy link
Member

fwolter commented Jul 10, 2020

You might be right. From the usability perspective that would be better. Do you want to file a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants