Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test coverage for RedirectController #251

Closed
liangyuanruo opened this issue Jul 2, 2020 · 0 comments · Fixed by #482 or #94
Closed

Expand test coverage for RedirectController #251

liangyuanruo opened this issue Jul 2, 2020 · 0 comments · Fixed by #482 or #94
Labels
P2 Not urgent, but work on it once you're done with current tasks

Comments

@liangyuanruo
Copy link
Contributor

Blocked by #250

Is your feature request related to a problem? Please describe.
We need to expand test coverage in order to Increase reliability of the critical redirect route in the application.

Describe the solution you'd like
Controller test coverage to ensure any functions and services implemented after #250 are being called correctly and in the right order.
@liangyuanruo liangyuanruo added the P1 Urgent, do it asap label Jul 2, 2020
@liangyuanruo liangyuanruo changed the title Test coverage for RedirectController Expand test coverage for RedirectController Jul 2, 2020
@liangyuanruo liangyuanruo added P2 Not urgent, but work on it once you're done with current tasks and removed P1 Urgent, do it asap labels Jul 3, 2020
@LoneRifle LoneRifle mentioned this issue Aug 26, 2020
Merged
@LoneRifle LoneRifle linked a pull request Aug 26, 2020 that will close this issue
Add additional tests on redirect middleware #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Not urgent, but work on it once you're done with current tasks
Projects
None yet
Milestone
No milestone
1 participant
@liangyuanruo