Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login sometimes fails even with correct OTP #2254

Closed
mantariksh opened this issue Jun 25, 2021 · 0 comments · Fixed by #2261
Closed

Login sometimes fails even with correct OTP #2254

mantariksh opened this issue Jun 25, 2021 · 0 comments · Fixed by #2261
Assignees
@karrui
Labels
P1 highest priority - pick up as soon as available

Comments

@mantariksh
Copy link
Contributor

mantariksh commented Jun 25, 2021 •
edited
Loading

To replicate:

  1. Go to an admin form URL, e.g. form.gov.sg/<formId>/adminform without being signed in
  2. You should be redirected to the sign in page
  3. Enter the correct OTP
  4. The "OTP verified!" success message is shown, but then will not subsequently redirect to the dashboard. User is then subsequently stuck; if they enter the OTP again it will show that the OTP is incorrect, but they have no other way to move forward. Refreshing will bring the user to the admin dashboard.
@liangyuanruo liangyuanruo added the P1 highest priority - pick up as soon as available label Jun 25, 2021
@karrui karrui mentioned this issue Jun 28, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karrui karrui

Labels
P1 highest priority - pick up as soon as available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly retrieve targetFormId for redirect state opengovsg/FormSG
3 participants
@liangyuanruo @karrui @mantariksh