Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other updates for v1.2 #472

Closed
wants to merge 35 commits into from
Closed

Other updates for v1.2 #472

wants to merge 35 commits into from

Conversation

m-burgoyne
Copy link
Collaborator

Add changes for limit query parameter and other informative text

Modify to reference the  CoverageJSON community standard issue #479
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ghobona
ghobona previously requested changes Jan 9, 2024
Copy link
Contributor

@ghobona ghobona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 22 in the file position.yaml has strin instead of string. See attached.

Screenshot 2024-01-09 at 17 01 20

@chris-little chris-little added the API EDR V1.2 Non-breaking change for Version 1.2 label Jan 12, 2024
@chris-little
Copy link
Contributor

@m-burgoyne Typo spotted by @ghobona.

@m-burgoyne
Copy link
Collaborator Author

@ghobona Thanks

Copy link
Collaborator

@solson-nws solson-nws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with typo fixes

@m-burgoyne m-burgoyne closed this Sep 16, 2024
@m-burgoyne
Copy link
Collaborator Author

Replaced by #577

@chris-little chris-little deleted the Other-updates-for-v1.2 branch October 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API EDR V1.2 Non-breaking change for Version 1.2
Projects
None yet
4 participants