Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lockSomeFeatures sends invalid GetFeatureWithLock request #32

Closed
dstenger opened this issue Jun 6, 2016 · 1 comment
Closed

Test lockSomeFeatures sends invalid GetFeatureWithLock request #32

dstenger opened this issue Jun 6, 2016 · 1 comment
Assignees
Labels

Comments

@dstenger
Copy link
Contributor

dstenger commented Jun 6, 2016

The Test lockSomeFeatures sends a request with two Filter:

<wfs:GetFeatureWithLock xmlns:wfs="http://www.opengis.net/wfs/2.0" count="10" expiry="60" lockAction="SOME"
  resultType="results" service="WFS" startIndex="0" version="2.0.0">
  <wfs:Query xmlns:ns84="http://www.deegree.org/app" typeNames="ns84:gns_iceland">
    <Filter xmlns="http://www.opengis.net/fes/2.0">
      <ResourceId rid="gns_iceland_-2643274" />
    </Filter>
    <Filter xmlns="http://www.opengis.net/fes/2.0">
      <ResourceId rid="gns_iceland_-2643274" />
      <ResourceId rid="gns_iceland_-2647445" />
      <ResourceId rid="gns_iceland_-2649558" />
      <ResourceId rid="gns_iceland_-2647523" />
      <ResourceId rid="gns_iceland_-2642297" />
      <ResourceId rid="gns_iceland_-2641862" />
      <ResourceId rid="gns_iceland_-2651772" />
      <ResourceId rid="gns_iceland_-2651068" />
      <ResourceId rid="gns_iceland_-2649172" />
      <ResourceId rid="gns_iceland_-2654429" />
    </Filter>
  </wfs:Query>
</wfs:GetFeatureWithLock>

In org.opengis.cite.iso19142.locking.GetFeatureWithLockTests.lockSomeFeatures() first Q1 is requested by adding a Filter using org.opengis.cite.iso19142.util.WFSRequest.addResourceIdPredicate(), this is repeated in the second part of the test requesting Q2.

org.opengis.cite.iso19142.util.WFSRequest.addResourceIdPredicate() does not check if a filter already exists but adds one at the end inside the Query-Element.

Expected is that the Request contains only one Filter.

@rjmartell
Copy link
Contributor

In the second request the filter from the previous request was not cleared. Fixed in 1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants