Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling test should allow having one GridCoverage or one RectifiedGridCoverage #141

Open
aaime opened this issue Nov 23, 2024 · 2 comments

Comments

@aaime
Copy link

aaime commented Nov 23, 2024

Describe the bug
Looking at a test run, I can see the following:

         Testing wcs2:get-scal-req3-kvp type Mandatory in Test Mode with defaultResult Pass (s0001/d14820e89_1/d4566e24999_1)...
            Assertion: Req3:Test GridCoverage,RectifiedGridCoverage.
            [FAILURE] The service should offer at least one GridCoverage.
            [MESSAGE] The server does not support the gml coverage.
         Test wcs2:get-scal-req3-kvp Failed

Now, the server in question only has RectifiedGridCoverage, it does not support general GridCoverage.
The test is however written to fail if at least one is not found:

https://github.com/opengeospatial/ets-wcs20/blob/master/src/main/scripts/ctl/ext_get-scal.xml#L357

I don't think this is what the ATS requires... requirement 3 states:

The coverage identifier in a GetCoverage request shall address a coverage which is a GridCoverage, RectifiedGridCoverage, ReferenceableGridCoverage, or a subtype of one of these."

ReferenceableGridCoverage is commented out through the tests, but I think in order to pass the test a server should offer at least a GridCoverage or a RectifiedGridCoverage, but not both?

@pebau
Copy link

pebau commented Nov 23, 2024

@aaime yes, you are right: the intention of the test was that at least one coverage of whatever type, dimension, range type must be provided for executing a test. So indeed it is an "or".

BTW, GridCoverage is a deprecated initial attempt dating back 20+ years and known to be flawed. CIS 1.1 adds a GeneralGridCoverage which unifies it all, and to add this into the game WCS 2.1 has been issued (no further technical change).

@aaime
Copy link
Author

aaime commented Nov 24, 2024

@pebau thanks for confirming. I'll see if I can issue a pull request to fix the issue then.

@dstenger dstenger added this to CITE Nov 26, 2024
@github-project-automation github-project-automation bot moved this to To do in CITE Nov 26, 2024
@aaime aaime changed the title Scaling test requires at least one GridCoverage Scaling test should allow having one GridCoverage or one RectifiedGridCoverage Dec 8, 2024
aaime added a commit to geoserver/ets-wcs20 that referenced this issue Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

2 participants