Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added supported_extensions list to discovery #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bhox
Copy link
Contributor

@bhox bhox commented May 17, 2018

No description provided.

@bhox bhox requested a review from samdozor May 17, 2018 21:17

`supported_extensions`

**REQUIRED** array of extension keys as defined in 7.1.2.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why is it required? If a processor does not support any extension - must they return an empty-list vs. null?
  • is it worth noting that this is with the intention that requests could be federated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It keeps it in line with the others: all required. Someone could conceivably have 0 supported public identities (passing an empty array) and one or more supported extensions. What do you think?
  • I don't think it needs to be called out since it could work by aggregating the discovery info.

@bhox
Copy link
Contributor Author

bhox commented May 18, 2018

Updated pull to update:

  • extension definitions: namespacing, naming, definition structure, json-schema
  • extension representation in /discovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants