From f16eed9a6df6de60549fb1c127ebc1c6a0b8184a Mon Sep 17 00:00:00 2001
From: Nathan Vasse <nathan.vasse@gmail.com>
Date: Fri, 2 Feb 2024 15:14:10 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(react)=20fix=20Select=20submit=20b?=
 =?UTF-8?q?utton?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As the default type of button is "submit", when including a Select
inside a form, clicking on any of its button was triggering form
submission.
---
 .changeset/hungry-knives-rescue.md                          | 5 +++++
 packages/react/src/components/Forms/Select/mono-common.tsx  | 2 ++
 packages/react/src/components/Forms/Select/multi-common.tsx | 2 ++
 3 files changed, 9 insertions(+)
 create mode 100644 .changeset/hungry-knives-rescue.md

diff --git a/.changeset/hungry-knives-rescue.md b/.changeset/hungry-knives-rescue.md
new file mode 100644
index 000000000..b77e42d9a
--- /dev/null
+++ b/.changeset/hungry-knives-rescue.md
@@ -0,0 +1,5 @@
+---
+"@openfun/cunningham-react": patch
+---
+
+fix Select submit button
diff --git a/packages/react/src/components/Forms/Select/mono-common.tsx b/packages/react/src/components/Forms/Select/mono-common.tsx
index 94bdbed1d..c622db06a 100644
--- a/packages/react/src/components/Forms/Select/mono-common.tsx
+++ b/packages/react/src/components/Forms/Select/mono-common.tsx
@@ -145,6 +145,7 @@ export const SelectMonoAux = ({
                         e.stopPropagation();
                       }}
                       icon={<span className="material-icons">close</span>}
+                      type="button"
                     />
                     <div className="c__select__inner__actions__separator" />
                   </>
@@ -164,6 +165,7 @@ export const SelectMonoAux = ({
                     </span>
                   }
                   disabled={disabled}
+                  type="button"
                   {...downshiftReturn.toggleButtonProps}
                 />
               </div>
diff --git a/packages/react/src/components/Forms/Select/multi-common.tsx b/packages/react/src/components/Forms/Select/multi-common.tsx
index a8aca7864..a64092019 100644
--- a/packages/react/src/components/Forms/Select/multi-common.tsx
+++ b/packages/react/src/components/Forms/Select/multi-common.tsx
@@ -125,6 +125,7 @@ export const SelectMultiAux = ({ children, ...props }: SelectMultiAuxProps) => {
                           props.onSelectedItemsChange([]);
                         }}
                         icon={<span className="material-icons">close</span>}
+                        type="button"
                       />
                       <div className="c__select__inner__actions__separator" />
                     </>
@@ -143,6 +144,7 @@ export const SelectMultiAux = ({ children, ...props }: SelectMultiAuxProps) => {
                     </span>
                   }
                   disabled={props.disabled}
+                  type="button"
                 />
               </div>
               <div className="c__select__inner__value">