Skip to content

History / Code Conventions

Edit page New page

Revisions

  • Remove outdated Capybara `have_no` recommendation (now enforced by rubocop in https://github.com/openfoodfoundation/openfoodnetwork/pull/12224)

    @dacook dacook committed Mar 4, 2024
    6f404e7

  • Remove outdated viewport-units restriction (it's been supported for over 10 years now)

    @dacook dacook committed Mar 4, 2024
    66e518c

  • Add note about query services (https://github.com/openfoodfoundation/openfoodnetwork/pull/12203)

    @dacook dacook committed Mar 3, 2024
    6a3e2c3

  • Remove redundant note about public_send (It's already verified by rubocop)

    @dacook dacook committed Mar 3, 2024
    754295b

  • Add introduction

    @dacook dacook committed Mar 3, 2024
    2c3352e

  • Explain I18n.t in spec convention because it has been divisive

    @mkllnk mkllnk committed Feb 1, 2023
    ed95d5a

  • Invert convention on using I18n in specs

    @mkllnk mkllnk committed Feb 1, 2023
    48cc574

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Sep 19, 2019
    eb768e5

  • Move Test > Gotchas section to new page /Automated-Testing-Gotchas (HEAD 5b34302)

    @kristinalim kristinalim committed Feb 7, 2019
    177cb85

  • Add section for designing tests to pass regardless of time of execution

    @kristinalim kristinalim committed Feb 7, 2019
    d6952ee

  • Add section for testing gotcha related to multiple consecutive spaces in HTML

    @kristinalim kristinalim committed Feb 7, 2019
    fce451d

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Nov 26, 2018
    a8f2966

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Sep 21, 2018
    8951c5d

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Sep 17, 2018
    580bcb2

  • Add section about using escape_javascript when inserting Ruby strings into JS or Angular expressions

    @kristinalim kristinalim committed Sep 13, 2018
    b82e719

  • Updated Code Conventions (markdown)

    @sauloperez sauloperez committed Aug 30, 2018
    c235ba1

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Aug 23, 2018
    df42510

  • Updated Code Conventions (markdown)

    @luisramos0 luisramos0 committed Aug 19, 2018
    d75c05f

  • Created Code Conventions (markdown)

    @luisramos0 luisramos0 committed Aug 19, 2018
    495ce36