-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMethodError in AmendBackorderJob@default #13056
Comments
AmendBackorderJobs are failing because there is no backorder to amend. The jobs started failing after the order cycle closed. At that point, the backorder is finalised and not available for amendments any more. Technically, I can just add a guard-clause to not try amend a missing backorder. But let's go through some scenarios to see if it's the right fit, thinking out loud.
So I would propose:
|
That makes sense to me. We will need to think about the final point (linking OFN Orders to DFC Orders) in the future, but I agree it's out of scope for now. We prob need a warning (on the import screen? ) about back order finalisation. Could have the delay finalise by X time there too. I'll add that to the wishlist! |
Error in Open Food Network (Rails)
NoMethodError in AmendBackorderJob@default
undefined method `lines' for nil:NilClass
View on Bugsnag
Stacktrace
View full stacktrace
Created by Maikel via Bugsnag
The text was updated successfully, but these errors were encountered: